From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Boris Brezillon <boris.brezillon@collabora.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
linux-media@vger.kernel.org
Cc: Tomasz Figa <tfiga@chromium.org>, Hirokazu Honda <hiroh@chromium.org>
Subject: Re: [RFC PATCH 2/3] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)
Date: Tue, 19 Mar 2019 14:07:32 -0400 [thread overview]
Message-ID: <53351fc1d3be8a268171162bc68939d38953d13a.camel@ndufresne.ca> (raw)
In-Reply-To: <20190319145243.25047-3-boris.brezillon@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
Le mardi 19 mars 2019 à 15:52 +0100, Boris Brezillon a écrit :
> +/**
> + * struct v4l2_plane_ext_pix_format - additional, per-plane format definition
> + * @modifier: modifier applied to the format (used for tiled formats
> + * and other kind of HW-specific formats, like compressed
> + * formats)
I have never seen HW that would allow per-plane modifiers on the DRM
side, and I believe the newer API (enumeration) ignores this per-plane
idea. Would be nice to investigate/verify this and avoid doing the same
mistake.
> + * @sizeimage: maximum size in bytes required for data, for which
> + * this plane will be used
> + * @bytesperline: distance in bytes between the leftmost pixels in two
> + * adjacent lines
> + */
> +struct v4l2_plane_ext_pix_format {
> + __u64 modifier;
> + __u32 sizeimage;
> + __u32 bytesperline;
> +};
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2019-03-19 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 14:52 [RFC PATCH 0/3] media: v4l2: Add extended fmt and buffer ioctls Boris Brezillon
2019-03-19 14:52 ` [RFC PATCH 1/3] media: v4l2: Get rid of ->vidioc_enum_fmt_vid_{cap,out}_mplane Boris Brezillon
2019-03-19 14:52 ` [RFC PATCH 2/3] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more) Boris Brezillon
2019-03-19 17:37 ` Brian Starkey
2019-03-19 20:21 ` Boris Brezillon
2019-03-19 18:07 ` Nicolas Dufresne [this message]
2019-03-19 20:02 ` Boris Brezillon
2019-03-19 14:52 ` [RFC PATCH 3/3] media: v4l2: Add extended buffer operations Boris Brezillon
2019-03-20 17:30 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53351fc1d3be8a268171162bc68939d38953d13a.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=boris.brezillon@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=hiroh@chromium.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).