linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: poma <pomidorabelisima@gmail.com>
To: Jose Alberto Reguero <jareguero@telefonica.net>
Cc: Antti Palosaari <crope@iki.fi>,
	linux-media <linux-media@vger.kernel.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Manu Abraham <abraham.manu@gmail.com>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Re: dvb_usb_af9015: command failed=1 _ kernel >= 4.1.x
Date: Fri, 31 Jul 2015 17:03:13 +0200	[thread overview]
Message-ID: <55BB8E31.8030907@gmail.com> (raw)
In-Reply-To: <55A38988.80404@gmail.com>

On 13.07.2015 11:48, poma wrote:
> On 07.07.2015 10:48, poma wrote:
>> On 06.07.2015 22:17, Jose Alberto Reguero wrote:
>>> I made the patch for the af9035. I have not a af9015 whith mxl5007 and dual channel. Revert it, if it cause regresions.
>>>
>>> Jose Alberto
>>>
>>
>> Thanks.
>>
>> From e19560ea038e54dc57be717db55f19d449df63f0 Mon Sep 17 00:00:00 2001
>> From: poma <pomidorabelisima@gmail.com>
>> Date: Tue, 7 Jul 2015 10:26:13 +0200
>> Subject: [PATCH] Fix for AF9015 DVB-T USB2.0 stick
>>
>> This reverts commitas:
>>
>> - 02f9cf96df57575acea2e6eb4041e9f3ecd32548
>>   "[media] [PATH,2/2] mxl5007 move loop_thru to attach"
>> - fe4860af002a4516dd878f7297b61e186c475b35
>>   "[media] [PATH,1/2] mxl5007 move reset to attach"
>>
>> This is the conclusion after extensive testing,
>> these two commitas produce:
>>
>> mxl5007t_soft_reset: 521: failed!
>> mxl5007t_attach: error -121 on line 907
>>
>> causing AF9015 DVB-T USB2.0 stick completely unusable.
>>
>>
>> Tested-by: poma <pomidorabelisima@gmail.com>
>> ---
>>  drivers/media/tuners/mxl5007t.c | 30 +++++-------------------------
>>  1 file changed, 5 insertions(+), 25 deletions(-)
>>
>> diff --git a/drivers/media/tuners/mxl5007t.c b/drivers/media/tuners/mxl5007t.c
>> index f4ae04c..f8c4ba2 100644
>> --- a/drivers/media/tuners/mxl5007t.c
>> +++ b/drivers/media/tuners/mxl5007t.c
>> @@ -374,6 +374,7 @@ static struct reg_pair_t *mxl5007t_calc_init_regs(struct mxl5007t_state *state,
>>  	mxl5007t_set_if_freq_bits(state, cfg->if_freq_hz, cfg->invert_if);
>>  	mxl5007t_set_xtal_freq_bits(state, cfg->xtal_freq_hz);
>>  
>> +	set_reg_bits(state->tab_init, 0x04, 0x01, cfg->loop_thru_enable);
>>  	set_reg_bits(state->tab_init, 0x03, 0x08, cfg->clk_out_enable << 3);
>>  	set_reg_bits(state->tab_init, 0x03, 0x07, cfg->clk_out_amp);
>>  
>> @@ -530,6 +531,10 @@ static int mxl5007t_tuner_init(struct mxl5007t_state *state,
>>  	struct reg_pair_t *init_regs;
>>  	int ret;
>>  
>> +	ret = mxl5007t_soft_reset(state);
>> +	if (mxl_fail(ret))
>> +		goto fail;
>> +
>>  	/* calculate initialization reg array */
>>  	init_regs = mxl5007t_calc_init_regs(state, mode);
>>  
>> @@ -895,32 +900,7 @@ struct dvb_frontend *mxl5007t_attach(struct dvb_frontend *fe,
>>  		/* existing tuner instance */
>>  		break;
>>  	}
>> -
>> -	if (fe->ops.i2c_gate_ctrl)
>> -		fe->ops.i2c_gate_ctrl(fe, 1);
>> -
>> -	ret = mxl5007t_soft_reset(state);
>> -
>> -	if (fe->ops.i2c_gate_ctrl)
>> -		fe->ops.i2c_gate_ctrl(fe, 0);
>> -
>> -	if (mxl_fail(ret))
>> -		goto fail;
>> -
>> -	if (fe->ops.i2c_gate_ctrl)
>> -		fe->ops.i2c_gate_ctrl(fe, 1);
>> -
>> -	ret = mxl5007t_write_reg(state, 0x04,
>> -		state->config->loop_thru_enable);
>> -
>> -	if (fe->ops.i2c_gate_ctrl)
>> -		fe->ops.i2c_gate_ctrl(fe, 0);
>> -
>> -	if (mxl_fail(ret))
>> -		goto fail;
>> -
>>  	fe->tuner_priv = state;
>> -
>>  	mutex_unlock(&mxl5007t_list_mutex);
>>  
>>  	memcpy(&fe->ops.tuner_ops, &mxl5007t_tuner_ops,
>>
> 
> 
> Guys, any chance to push this any time soon?
> 
> 

Will someone finally push this?


  reply	other threads:[~2015-07-31 15:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 20:17 dvb_usb_af9015: command failed=1 _ kernel >= 4.1.x Jose Alberto Reguero
2015-07-07  8:48 ` poma
2015-07-13  9:48   ` poma
2015-07-31 15:03     ` poma [this message]
     [not found]       ` <CAAZRmGym49dG6Jj-ZeKZmy0rgr4ozph7-ggjLoWtGOvT1m4oBA@mail.gmail.com>
2015-08-10 21:46         ` poma
2015-08-10 22:40           ` Antti Palosaari
2015-08-12 23:52             ` poma
  -- strict thread matches above, loose matches on Subject: below --
2015-05-08 10:20 dvb_usb_af9015: command failed=1 - stable: 4.0.2 poma
2015-05-08 10:59 ` poma
2015-05-10 10:38   ` dvb_usb_af9015: command failed=1 >= 3.19.x poma
2015-05-10 22:25     ` dvb_usb_af9015: command failed=1 _ lsdvb " poma
2015-05-11 18:43       ` dvb_usb_af9015: command failed=1 _ kernel >= 4.1.x poma
2015-05-12 14:11         ` Antti Palosaari
2015-05-13  3:56           ` poma
2015-05-16 23:07             ` Antti Palosaari
2015-05-18 19:15               ` poma
2015-05-21 21:23                 ` poma
2015-05-26 12:24                   ` poma
2015-07-02 23:02                     ` poma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BB8E31.8030907@gmail.com \
    --to=pomidorabelisima@gmail.com \
    --cc=abraham.manu@gmail.com \
    --cc=crope@iki.fi \
    --cc=jareguero@telefonica.net \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=mkrufky@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).