From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 126AFC3A5A2 for ; Tue, 10 Sep 2019 10:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D94DE2067B for ; Tue, 10 Sep 2019 10:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388075AbfIJKOX (ORCPT ); Tue, 10 Sep 2019 06:14:23 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40240 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726084AbfIJKOX (ORCPT ); Tue, 10 Sep 2019 06:14:23 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id B932128C51D Message-ID: <56f8886353ced71426e2ce6442eed18fe349cdab.camel@collabora.com> Subject: Re: [PATCH 02/12] media: hantro: Do not reorder H264 scaling list From: Ezequiel Garcia To: Jonas Karlman , Philipp Zabel Cc: Mauro Carvalho Chehab , Hans Verkuil , Boris Brezillon , Paul Kocialkowski , "linux-media@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Tue, 10 Sep 2019 11:14:17 +0100 In-Reply-To: References: <20190901124531.23645-1-jonas@kwiboo.se> <1567432843.3666.6.camel@pengutronix.de> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Jonas, Thanks for your patch. On Mon, 2019-09-02 at 16:18 +0000, Jonas Karlman wrote: [..] > > > > diff --git a/drivers/staging/media/hantro/hantro_h264.c b/drivers/staging/media/hantro/hantro_h264.c > > > index 0d758e0c0f99..e2d01145ac4f 100644 > > > --- a/drivers/staging/media/hantro/hantro_h264.c > > > +++ b/drivers/staging/media/hantro/hantro_h264.c > > > @@ -20,7 +20,7 @@ > > > /* Size with u32 units. */ > > > #define CABAC_INIT_BUFFER_SIZE (460 * 2) > > > #define POC_BUFFER_SIZE 34 > > > -#define SCALING_LIST_SIZE (6 * 16 + 6 * 64) > > > +#define SCALING_LIST_SIZE (6 * 16 + 2 * 64) > > This changes the size of struct hantro_h264_dec_priv_tbl. Did this > > describe the auxiliary buffer format incorrectly before? > > Based on RKMPP and Hantro SDK the HW expects the 8x8 inter/intra list for > Y-component to be located at indices 0 and 1, lists for Cr/Cb is only used for > 4:4:4 and HW only supports 4:0:0/4:2:0 if I am not mistaken. So the unused > extra 4 lists at the end of the auxiliary buffer seemed like a waste, > also RKMPP and Hantro SDK only seemed to allocate space for 2 lists. > I think it would make a lot of sense to document what the hardware expects somewhere, perhaps as part of the struct hantro_h264_dec_priv_tbl documentation? Thanks, Ezequiel