From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-media@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [PATCH v4 1/6] media: Add video processing entity functions
Date: Mon, 23 May 2016 11:06:59 +0200 [thread overview]
Message-ID: <5742C833.50204@xs4all.nl> (raw)
In-Reply-To: <1463701232-22008-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 05/20/2016 01:40 AM, Laurent Pinchart wrote:
> Add composer, pixel formatter, pixel encoding converter and scaler
> functions.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Looks good!
Hans
> ---
> Documentation/DocBook/media/v4l/media-types.xml | 55 +++++++++++++++++++++++++
> include/uapi/linux/media.h | 9 ++++
> 2 files changed, 64 insertions(+)
>
> diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml
> index 5e3f20fdcf17..60fe841f8846 100644
> --- a/Documentation/DocBook/media/v4l/media-types.xml
> +++ b/Documentation/DocBook/media/v4l/media-types.xml
> @@ -121,6 +121,61 @@
> <entry><constant>MEDIA_ENT_F_AUDIO_MIXER</constant></entry>
> <entry>Audio Mixer Function Entity.</entry>
> </row>
> + <row>
> + <entry><constant>MEDIA_ENT_F_PROC_VIDEO_COMPOSER</constant></entry>
> + <entry>Video composer (blender). An entity capable of video
> + composing must have at least two sink pads and one source
> + pad, and composes input video frames onto output video
> + frames. Composition can be performed using alpha blending,
> + color keying, raster operations (ROP), stitching or any other
> + means.
> + </entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER</constant></entry>
> + <entry>Video pixel formatter. An entity capable of pixel formatting
> + must have at least one sink pad and one source pad. Read
> + pixel formatters read pixels from memory and perform a subset
> + of unpacking, cropping, color keying, alpha multiplication
> + and pixel encoding conversion. Write pixel formatters perform
> + a subset of dithering, pixel encoding conversion and packing
> + and write pixels to memory.
> + </entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_ENT_F_PROC_VIDEO_PIXEL_ENC_CONV</constant></entry>
> + <entry>Video pixel encoding converter. An entity capable of pixel
> + enconding conversion must have at least one sink pad and one
> + source pad, and convert the encoding of pixels received on
> + its sink pad(s) to a different encoding output on its source
> + pad(s). Pixel encoding conversion includes but isn't limited
> + to RGB to/from HSV, RGB to/from YUV and CFA (Bayer) to RGB
> + conversions.
> + </entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_ENT_F_PROC_VIDEO_LUT</constant></entry>
> + <entry>Video look-up table. An entity capable of video lookup table
> + processing must have one sink pad and one source pad. It uses
> + the values of the pixels received on its sink pad to look up
> + entries in internal tables and output them on its source pad.
> + The lookup processing can be performed on all components
> + separately or combine them for multi-dimensional table
> + lookups.
> + </entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_ENT_F_PROC_VIDEO_SCALER</constant></entry>
> + <entry>Video scaler. An entity capable of video scaling must have
> + at least one sink pad and one source pad, and scale the
> + video frame(s) received on its sink pad(s) to a different
> + resolution output on its source pad(s). The range of
> + supported scaling ratios is entity-specific and can differ
> + between the horizontal and vertical directions (in particular
> + scaling can be supported in one direction only). Binning and
> + skipping are considered as scaling.
> + </entry>
> + </row>
> </tbody>
> </tgroup>
> </table>
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index e226bc35c639..bff3ffdfd55f 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -96,6 +96,15 @@ struct media_device_info {
> #define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03003)
>
> /*
> + * Processing entities
> + */
> +#define MEDIA_ENT_F_PROC_VIDEO_COMPOSER (MEDIA_ENT_F_BASE + 0x4001)
> +#define MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER (MEDIA_ENT_F_BASE + 0x4002)
> +#define MEDIA_ENT_F_PROC_VIDEO_PIXEL_ENC_CONV (MEDIA_ENT_F_BASE + 0x4003)
> +#define MEDIA_ENT_F_PROC_VIDEO_LUT (MEDIA_ENT_F_BASE + 0x4004)
> +#define MEDIA_ENT_F_PROC_VIDEO_SCALER (MEDIA_ENT_F_BASE + 0x4005)
> +
> +/*
> * Connectors
> */
> /* It is a responsibility of the entity drivers to add connectors and links */
>
next prev parent reply other threads:[~2016-05-23 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 23:40 [PATCH v4 0/6] R-Car VSP: Add and set media entities functions Laurent Pinchart
2016-05-19 23:40 ` [PATCH v4 1/6] media: Add video processing entity functions Laurent Pinchart
2016-05-23 9:06 ` Hans Verkuil [this message]
2016-05-19 23:40 ` [PATCH v4 2/6] media: Add video statistics computation functions Laurent Pinchart
2016-05-23 9:10 ` Hans Verkuil
2016-05-19 23:40 ` [PATCH v4 3/6] v4l: vsp1: Base link creation on availability of entities Laurent Pinchart
2016-05-19 23:40 ` [PATCH v4 4/6] v4l: vsp1: Don't register media device when userspace API is disabled Laurent Pinchart
2016-05-19 23:40 ` [PATCH v4 5/6] v4l: vsp1: Don't create LIF entity when the userspace API is enabled Laurent Pinchart
2016-05-19 23:40 ` [PATCH v4 6/6] v4l: vsp1: Set entities functions Laurent Pinchart
2016-05-23 13:52 ` [PATCH v4 0/6] R-Car VSP: Add and set media " Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5742C833.50204@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).