Hello Hans,

On 23.05.2016 12:45, Hans Verkuil wrote:
>> +static int sur40_ioctl_parm(struct file *file, void *priv,
>> +			    struct v4l2_streamparm *p)
>> +{
>> +	if (p->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
>> +		p->parm.capture.timeperframe.numerator = 1;
>> +		p->parm.capture.timeperframe.denominator = 60;
>> +	}
> 
> It should return -EINVAL if it is not of type VIDEO_CAPTURE. You should also set the
> V4L2_CAP_TIMEPERFRAME capability for this to work. The readbuffers field should also
> be set (typically to the minimum required number of buffers).

One question: should this be the same number of buffers as reported in
sur40_queue_setup (i.e. 3)? And is this still relevant with the pending
changes to alloc_ctx?

> Please check with v4l2-compliance! It would have warned about these issues.
Sorry for the noise (again ;-)

Best, Florian
-- 
SENT FROM MY DEC VT50 TERMINAL