From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: g.liakhovetski@gmx.de
Subject: Re: [PATCH 5/6] v4l: Add 14-bit raw bayer pixel format definitions
Date: Mon, 20 Jun 2016 18:05:47 +0200 [thread overview]
Message-ID: <5768145B.2010306@xs4all.nl> (raw)
In-Reply-To: <576813B9.9050407@linux.intel.com>
On 06/20/2016 06:03 PM, Sakari Ailus wrote:
> Hi Hans,
>
> Hans Verkuil wrote:
>> On 05/27/2016 02:44 PM, Sakari Ailus wrote:
>>> The formats added by this patch are:
>>>
>>> V4L2_PIX_FMT_SBGGR14
>>> V4L2_PIX_FMT_SGBRG14
>>> V4L2_PIX_FMT_SGRBG14
>>> V4L2_PIX_FMT_SRGGB14
>>>
>>> Signed-off-by: Jouni Ukkonen <jouni.ukkonen@intel.com>
>>> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>>> ---
>>> Documentation/DocBook/media/v4l/pixfmt-srggb14.xml | 90 ++++++++++++++++++++++
>>> Documentation/DocBook/media/v4l/pixfmt.xml | 1 +
>>> include/uapi/linux/videodev2.h | 4 +
>>> 3 files changed, 95 insertions(+)
>>> create mode 100644 Documentation/DocBook/media/v4l/pixfmt-srggb14.xml
>>>
>>> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb14.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb14.xml
>>> new file mode 100644
>>> index 0000000..7e82d7e
>>> --- /dev/null
>>> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb14.xml
>>> @@ -0,0 +1,90 @@
>>> + <refentry>
>>> + <refmeta>
>>> + <refentrytitle>V4L2_PIX_FMT_SRGGB14 ('RG14'),
>>> + V4L2_PIX_FMT_SGRBG14 ('BA14'),
>>> + V4L2_PIX_FMT_SGBRG14 ('GB14'),
>>> + V4L2_PIX_FMT_SBGGR14 ('BG14'),
>>
>> Same comma problem.
>
> Fixed.
>
>>
>>> + </refentrytitle>
>>> + &manvol;
>>> + </refmeta>
>>> + <refnamediv>
>>> + <refname id="V4L2-PIX-FMT-SRGGB14"><constant>V4L2_PIX_FMT_SRGGB14</constant></refname>
>>> + <refname id="V4L2-PIX-FMT-SGRBG14"><constant>V4L2_PIX_FMT_SGRBG14</constant></refname>
>>> + <refname id="V4L2-PIX-FMT-SGBRG14"><constant>V4L2_PIX_FMT_SGBRG14</constant></refname>
>>> + <refname id="V4L2-PIX-FMT-SBGGR14"><constant>V4L2_PIX_FMT_SBGGR14</constant></refname>
>>> + <refpurpose>14-bit Bayer formats expanded to 16 bits</refpurpose>
>>> + </refnamediv>
>>> + <refsect1>
>>> + <title>Description</title>
>>> +
>>> + <para>These four pixel formats are raw sRGB / Bayer formats with
>>> +14 bits per colour. Each colour component is stored in a 16-bit word, with 2
>>> +unused high bits filled with zeros. Each n-pixel row contains n/2 green samples
>>> +and n/2 blue or red samples, with alternating red and blue rows. Bytes are
>>> +stored in memory in little endian order. They are conventionally described
>>> +as GRGR... BGBG..., RGRG... GBGB..., etc. Below is an example of one of these
>>> +formats</para>
>>
>> s/formats/formats:/
>
> Fixed.
>
>>> +
>>> + <example>
>>> + <title><constant>V4L2_PIX_FMT_SBGGR14</constant> 4 × 4
>>> +pixel image</title>
>>> +
>>> + <formalpara>
>>> + <title>Byte Order.</title>
>>> + <para>Each cell is one byte, high 2 bits in high bytes are 0.
>>
>> s/high 2/the high 2/
>
> After re-reading the patch, I changed this to "Each cell is one byte,
> the 2 most significant bits in the high bytes are 0".
That is indeed better, although I would also say "two most" instead of "2 most".
It's slightly weird to have "one byte" followed by "2 most". Could be me, though.
Regards,
Hans
next prev parent reply other threads:[~2016-06-20 16:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 12:44 [PATCH 0/6] New raw bayer format definitions, fixes Sakari Ailus
2016-05-27 12:44 ` [PATCH 1/6] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats Sakari Ailus
2016-06-20 15:12 ` Hans Verkuil
2016-06-20 15:34 ` Sakari Ailus
2016-05-27 12:44 ` [PATCH 2/6] v4l: Fix number of zeroed high order bits in 12-bit raw format defs Sakari Ailus
2016-06-20 15:13 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 3/6] v4l: Add packed Bayer raw12 pixel formats Sakari Ailus
2016-06-20 15:21 ` Hans Verkuil
2016-06-20 15:37 ` Sakari Ailus
2016-05-27 12:44 ` [PATCH 4/6] media: Add 1X14 14-bit raw bayer media bus code definitions Sakari Ailus
2016-06-20 15:23 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 5/6] v4l: Add 14-bit raw bayer pixel format definitions Sakari Ailus
2016-06-20 15:24 ` Hans Verkuil
2016-06-20 16:03 ` Sakari Ailus
2016-06-20 16:05 ` Hans Verkuil [this message]
2016-05-27 12:44 ` [PATCH 6/6] v4l: Add packed Bayer raw14 pixel formats Sakari Ailus
2016-06-20 15:29 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5768145B.2010306@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).