From: Ezequiel Garcia <ezequiel@collabora.com>
To: Boris Brezillon <boris.brezillon@collabora.com>,
Helen Koike <helen.koike@collabora.com>
Cc: linux-media@vger.kernel.org, hverkuil-cisco@xs4all.nl,
kernel@collabora.com, ezequiel.garcia@collabora.com,
andrealmeid@collabora.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: vimc: fix component match compare
Date: Tue, 21 May 2019 15:39:00 -0300 [thread overview]
Message-ID: <5f51eb6be411ae9afb08a9b315fe51e754dc0077.camel@collabora.com> (raw)
In-Reply-To: <20190521145548.27844fa6@collabora.com>
On Tue, 2019-05-21 at 14:55 +0200, Boris Brezillon wrote:
> On Fri, 17 May 2019 14:20:11 -0300
> Helen Koike <helen.koike@collabora.com> wrote:
>
> > If the system has other devices being registered in the component
> > framework, the compare function will be called with a device that
> > doesn't belong to vimc.
> > This device is not necessarily a platform_device, nor have a
> > platform_data (which causes a NULL pointer dereference error) and if it
> > does have a pdata, it is not necessarily type of struct vimc_platform_data.
> > So casting to any of these types is wrong.
> >
> > Instead of expecting a given pdev with a given pdata, just expect for
> > the device it self. vimc-core is the one who creates them, we know in
> > advance exactly which object to expect in the match.
> >
> > Fixes: 4a29b7090749 ("[media] vimc: Subdevices as modules")
>
> Oh, and you forgot to add
>
> Cc: <stable@vger.kernel.org>
>
Although it's not really documented (not in process/stable-rules
at least) that a "Fixes" tag alone would be automatically picked by
the stable team, it has been the case for me since always,
as I've never Cced stable explicitly.
next prev parent reply other threads:[~2019-05-21 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 17:20 [PATCH] media: vimc: fix component match compare Helen Koike
2019-05-21 12:53 ` Boris Brezillon
2019-05-21 12:55 ` Boris Brezillon
2019-05-21 18:39 ` Ezequiel Garcia [this message]
2019-05-21 18:53 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f51eb6be411ae9afb08a9b315fe51e754dc0077.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=andrealmeid@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=ezequiel.garcia@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).