From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: agross@kernel.org, linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: venus: core: Fix msm8996 frequency table
Date: Wed, 11 Sep 2019 18:03:59 +0300 [thread overview]
Message-ID: <689fba99-a631-8e7e-8d75-d84390f45122@linaro.org> (raw)
In-Reply-To: <CAMZdPi82ZCJK1QOXHo7hq9iCOq5vzuJF1shq=4ut+zRJ5FfmMw@mail.gmail.com>
On 9/11/19 5:40 PM, Loic Poulain wrote:
> On Wed, 11 Sep 2019 at 11:29, Stanimir Varbanov <
> stanimir.varbanov@linaro.org> wrote:
>
>> Hi Loic,
>>
>> Thanks for the patch!
>>
>> On 9/4/19 1:06 PM, Loic Poulain wrote:
>>> In downstream driver, there are two frequency tables defined,
>>> one for the encoder and one for the decoder:
>>>
>>> /* Encoders /
>>> <972000 490000000 0x55555555>, / 4k UHD @ 30 /
>>> <489600 320000000 0x55555555>, / 1080p @ 60 /
>>> <244800 150000000 0x55555555>, / 1080p @ 30 /
>>> <108000 75000000 0x55555555>, / 720p @ 30 */
>>>
>>> /* Decoders /
>>> <1944000 490000000 0xffffffff>, / 4k UHD @ 60 /
>>> < 972000 320000000 0xffffffff>, / 4k UHD @ 30 /
>>> < 489600 150000000 0xffffffff>, / 1080p @ 60 /
>>> < 244800 75000000 0xffffffff>; / 1080p @ 30 */
>>>
>>> It shows that encoder always needs a higher clock than decoder.
>>>
>>> In current venus driver, the unified frequency table is aligned
>>> with the downstream decoder table which causes performance issues
>>> in decoding scenarios. Fix that by aligning frequency table on
>>
>> s/decoding scenarios/encoding scenarios
>>
>>> worst case (encoding).
>>
>> Did you checked the exact rate from clk_summary? Checking the frequency
>> table for subcore0|1 from mmcc-msm8996.c clock driver shows that the
>> tables are slightly different for higher rates.
>>
>> Otherwise, I'd take the patch but it would be better to align the
>> frequency tables to avoid confusions.
>>
>
> Thanks, yes I'm going to send a V2 with aligned freqs, note however that
> with my setup (DB820C), debugfs reported clk rates seem to be a bit
> misaligned.
> I get either 75000000, 150000000, 326666666 or 490000000... regardless
> frequency table.
What kernel version is that?
--
regards,
Stan
prev parent reply other threads:[~2019-09-11 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 10:06 [PATCH] media: venus: core: Fix msm8996 frequency table Loic Poulain
2019-09-11 9:29 ` Stanimir Varbanov
[not found] ` <CAMZdPi82ZCJK1QOXHo7hq9iCOq5vzuJF1shq=4ut+zRJ5FfmMw@mail.gmail.com>
2019-09-11 15:03 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=689fba99-a631-8e7e-8d75-d84390f45122@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=agross@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).