From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from mga09.intel.com ([134.134.136.24]:22964 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751699AbdLBAAQ (ORCPT <rfc822;linux-media@vger.kernel.org>);
        Fri, 1 Dec 2017 19:00:16 -0500
From: "Mani, Rajmohan" <rajmohan.mani@intel.com>
To: "sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>
CC: Sakari Ailus <sakari.ailus@iki.fi>,
        "Zhi, Yong" <yong.zhi@intel.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "Zheng, Jian Xu" <jian.xu.zheng@intel.com>,
        "Toivonen, Tuukka" <tuukka.toivonen@intel.com>,
        "Hu, Jerry W" <jerry.w.hu@intel.com>
Subject: RE: [PATCH v4 04/12] intel-ipu3: Add user space ABI definitions
Date: Sat, 2 Dec 2017 00:00:10 +0000
Message-ID: <6F87890CF0F5204F892DEA1EF0D77A5972FD8165@FMSMSX114.amr.corp.intel.com>
References: <1508298896-26096-1-git-send-email-yong.zhi@intel.com>
 <20171020093020.jo2vktc62sx52w4v@valkosipuli.retiisi.org.uk>
 <6F87890CF0F5204F892DEA1EF0D77A5972FD24A5@FMSMSX114.amr.corp.intel.com>
 <20171121172154.h6bzixu4phmqiria@paasikivi.fi.intel.com>
In-Reply-To: <20171121172154.h6bzixu4phmqiria@paasikivi.fi.intel.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

Hi Sakari,

> -----Original Message-----
> From: sakari.ailus@linux.intel.com [mailto:sakari.ailus@linux.intel.com]
> Sent: Tuesday, November 21, 2017 9:22 AM
> To: Mani, Rajmohan <rajmohan.mani@intel.com>
> Cc: Sakari Ailus <sakari.ailus@iki.fi>; Zhi, Yong <yong.zhi@intel.com>; linux-
> media@vger.kernel.org; Zheng, Jian Xu <jian.xu.zheng@intel.com>; Toivonen,
> Tuukka <tuukka.toivonen@intel.com>; Hu, Jerry W <jerry.w.hu@intel.com>
> Subject: Re: [PATCH v4 04/12] intel-ipu3: Add user space ABI definitions
> 
> Hi Rajmohan,
> 
> My apologies for the late reply.
> 
> On Sat, Nov 11, 2017 at 04:07:22AM +0000, Mani, Rajmohan wrote:
> > Hi Sakari,
> >
> > > -----Original Message-----
> > > From: Sakari Ailus [mailto:sakari.ailus@iki.fi]
> > > Sent: Friday, October 20, 2017 2:30 AM
> > > To: Zhi, Yong <yong.zhi@intel.com>
> > > Cc: linux-media@vger.kernel.org; sakari.ailus@linux.intel.com;
> > > Zheng, Jian Xu <jian.xu.zheng@intel.com>; Mani, Rajmohan
> > > <rajmohan.mani@intel.com>; Toivonen, Tuukka
> > > <tuukka.toivonen@intel.com>; Hu, Jerry W <jerry.w.hu@intel.com>
> > > Subject: Re: [PATCH v4 04/12] intel-ipu3: Add user space ABI
> > > definitions
> > >
> > > Hi Yong,
> > >
> > > On Tue, Oct 17, 2017 at 10:54:49PM -0500, Yong Zhi wrote:
> 
> ...
> 
> > > > +struct ipu3_uapi_params {
> > > > +	__u32 fourcc;			/* V4L2_PIX_FMT_IPU3_PARAMS */
> > > > +	__u32 version;			/* Must be 0x100 */
> > >
> > > These were called padding1 and padding2 in the previous version.
> > > What happened?
> > >
> > > I'd just call them reserved, and maybe also make the use field the
> > > first member of the struct.
> > >
> >
> > These fields were repurposed after v3 of this patch series. Please see the user
> space code that uses these fields.
> > https://chromium.googlesource.com/chromiumos/platform/arc-
> camera/+/mas
> > ter/hal/intel/psl/ipu3/workers/IPU3AicToFwEncoder.cpp
> 
> They were fourcc and version in the beginning, and then replaced by
> padding1 and padding 2. Is there a particular reason for changing them back?
> 

We looked into this further to see that we have no compelling reasons to use these variables.
I will revert these names back to padding1 and padding2, along with the required user space code changes.