From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Stefan Herdler <herdler@nurfuerspam.de>
Cc: linux-media@vger.kernel.org,
Manu Abraham <abraham.manu@gmail.com>,
Tomasz Maciej Nowak <tmn505@gmail.com>,
Corinna Vinschen <vinschen@redhat.com>,
Soeren Moch <smoch@web.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: saa7146: please test the vb2 conversion!
Date: Fri, 24 Mar 2023 11:40:41 +0100 [thread overview]
Message-ID: <6c5433ff-a6c8-10f3-789b-bc231291c642@xs4all.nl> (raw)
In-Reply-To: <016c57b2-8538-c630-b72f-a3c608c33a02@xs4all.nl>
On 24/03/2023 11:37, Hans Verkuil wrote:
> Hi all,
>
> I finished the vb2 conversion and tested what I could test. I am missing
> 'full featured' hardware, so I could not test the analog video capture part
> of that. It's not clear to me if VBI capture is also supported on those
> cards, if so, then that needs to be tested as well.
>
> Note that there is one userspace-facing change: the VBI output settings
> are kept, even if the vbi device is closed by the application.
>
> Before you had to open the vbi device, format the slice VBI output, and
> write sliced VBI data to it. Closing the device would reset how VBI output
> behaves. That is not in spec with the V4L2 API. The format is kept after
> the device is closed.
>
> Any application that uses VBI output and that wants to keep the same
> behavior would have to call VIDIOC_S_FMT with a struct v4l2_sliced_vbi_format
> with a service_set field set to 0 to indicate that you don't want to
> output any VBI anymore.
>
> If this is a problem, then I can make a module option that selects the old
> behavior.
>
> BTW, if anyone has a spare full-featured card (i.e. with analog video capture
> as well), then I would love to take it off your hands so that I can test that
> myself!
>
> This series has been tested on the two Hexium boards, the mxb board, and two
> av7710 boards (DVB-C and DVB-T).
It does help if I point to the patches :-)
The patch series is here:
https://patchwork.linuxtv.org/project/linux-media/list/?series=10140
It's also in my git tree:
https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=saa7146-clean
Regards,
Hans
next prev parent reply other threads:[~2023-03-24 10:40 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 22:19 Future of the SAA7146 drivers Stefan Herdler
2023-01-31 8:45 ` Hans Verkuil
2023-01-31 23:56 ` Stefan Herdler
2023-02-01 9:15 ` Hans Verkuil
2023-02-01 11:35 ` Soeren Moch
2023-02-01 13:51 ` Hans Verkuil
2023-02-01 15:20 ` Soeren Moch
2023-02-01 16:37 ` Hans Verkuil
2023-02-08 8:42 ` Mauro Carvalho Chehab
2023-02-01 23:12 ` Stefan Herdler
2023-02-02 9:43 ` Soeren Moch
2023-02-02 21:26 ` Stefan Herdler
2023-02-03 0:58 ` Stefan Herdler
2023-02-03 8:50 ` Hans Verkuil
2023-02-06 0:06 ` Stefan Herdler
2023-02-08 9:08 ` Mauro Carvalho Chehab
2023-02-12 23:10 ` Stefan Herdler
2023-03-24 10:37 ` saa7146: please test the vb2 conversion! Hans Verkuil
2023-03-24 10:40 ` Hans Verkuil [this message]
2023-03-24 21:21 ` Stefan Herdler
2023-03-27 17:13 ` Tomasz Maciej Nowak
2023-04-06 22:43 ` Stefan Herdler
2023-04-07 7:04 ` Hans Verkuil
2023-04-09 22:36 ` Stefan Herdler
2023-04-11 7:29 ` Hans Verkuil
2023-04-12 10:11 ` Hans Verkuil
2023-04-12 11:16 ` Hans Verkuil
2023-04-14 0:15 ` Stefan Herdler
2023-04-14 8:36 ` Hans Verkuil
2023-04-15 21:15 ` Stefan Herdler
2023-03-25 1:44 ` [PATCH] Legacy DVB API: completion of documentation Stefan Herdler
2023-03-25 8:47 ` kernel test robot
2023-03-26 21:34 ` [PATCH v2] " Stefan Herdler
2023-03-27 18:28 ` Mauro Carvalho Chehab
2023-04-02 22:25 ` Stefan Herdler
2023-07-17 2:04 ` [PATCH v3 0/6] " Stefan Herdler
2023-07-17 2:04 ` [PATCH v3 1/6] Add documentation for legacy DVB decoder API Stefan Herdler
2023-07-17 2:04 ` [PATCH v3 2/6] Add documentation for osd.h Stefan Herdler
2023-07-17 2:04 ` [PATCH v3 3/6] Add documentation for audio.h (data types) Stefan Herdler
2023-07-19 9:09 ` kernel test robot
2023-07-17 2:04 ` [PATCH v3 4/6] Add documentation for audio.h (function calls) Stefan Herdler
2023-07-17 2:04 ` [PATCH v3 5/6] Add documentation for video.h (data types) Stefan Herdler
2023-07-17 2:04 ` [PATCH v3 6/6] Add documentation for video.h (function calls) Stefan Herdler
2024-01-28 23:32 ` [PATCH v4 0/6] media: docs: uAPI: dvb/decoder: completing the documentation Stefan Herdler
2024-01-28 23:32 ` [PATCH v4 1/6] " Stefan Herdler
2024-01-28 23:32 ` [PATCH v4 2/6] media: docs: uAPI: dvb/osd: " Stefan Herdler
2024-01-28 23:32 ` [PATCH v4 3/6] media: docs: uAPI: dvb/audio: completing the documentation (data types) Stefan Herdler
2024-01-28 23:32 ` [PATCH v4 4/6] media: docs: uAPI: dvb/audio: completing the documentation (function calls) Stefan Herdler
2024-01-28 23:32 ` [PATCH v4 5/6] media: docs: uAPI: dvb/video: completing the documentation (data types) Stefan Herdler
2024-01-28 23:32 ` [PATCH v4 6/6] media: docs: uAPI: dvb/video: completing the documentation (function calls) Stefan Herdler
2024-02-07 5:10 ` [PATCH v4 0/6] media: docs: uAPI: dvb/decoder: completing the documentation Mauro Carvalho Chehab
2024-02-08 23:56 ` Stefan Herdler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c5433ff-a6c8-10f3-789b-bc231291c642@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=abraham.manu@gmail.com \
--cc=herdler@nurfuerspam.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=smoch@web.de \
--cc=tmn505@gmail.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).