From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 988EAC31E40 for ; Mon, 12 Aug 2019 13:28:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7727920651 for ; Mon, 12 Aug 2019 13:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728871AbfHLN2W (ORCPT ); Mon, 12 Aug 2019 09:28:22 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57144 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbfHLN2V (ORCPT ); Mon, 12 Aug 2019 09:28:21 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 97A362834A8 Message-ID: <6c78d1343b92e08c92e568a9e349fe22ac2f4aed.camel@collabora.com> Subject: Re: [PATCH 1/7] media: cedrus: Disable engine after each slice decoding From: Ezequiel Garcia To: Maxime Ripard , Jernej Skrabec Cc: paul.kocialkowski@bootlin.com, wens@csie.org, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 12 Aug 2019 10:28:11 -0300 In-Reply-To: <20190603113827.2nmm5wkycf44aqox@flea> References: <20190530211516.1891-1-jernej.skrabec@siol.net> <20190530211516.1891-2-jernej.skrabec@siol.net> <20190603113827.2nmm5wkycf44aqox@flea> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Jernej, On Mon, 2019-06-03 at 13:38 +0200, Maxime Ripard wrote: > Hi, > > On Thu, May 30, 2019 at 11:15:10PM +0200, Jernej Skrabec wrote: > > libvdpau-sunxi always disables engine after each decoded slice. > > Do same in Cedrus driver. > > > > Presumably this also lowers power consumption which is always nice. > > > > Signed-off-by: Jernej Skrabec > > Is it fixing anything though? > > I indeed saw that cedar did disable it everytime, but I couldn't find > a reason why. > > Also, the power management improvement would need to be measured, it > can even create the opposite situation where the device will draw more > current from being woken up than if it had just remained disabled. > While reviewing this, I'm noticing that cedrus_engine_disable can be marked for static storage (with or without this patch). Regards, Eze