* [PATCH] vimc: add USERPTR support
@ 2019-01-14 14:58 Hans Verkuil
2019-01-14 17:04 ` Helen Koike
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2019-01-14 14:58 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Helen Koike
Add VB2_USERPTR to the vimc capture device.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/drivers/media/platform/vimc/vimc-capture.c b/drivers/media/platform/vimc/vimc-capture.c
index 3f7e9ed56633..35c730f484a7 100644
--- a/drivers/media/platform/vimc/vimc-capture.c
+++ b/drivers/media/platform/vimc/vimc-capture.c
@@ -431,7 +431,7 @@ static int vimc_cap_comp_bind(struct device *comp, struct device *master,
/* Initialize the vb2 queue */
q = &vcap->queue;
q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
- q->io_modes = VB2_MMAP | VB2_DMABUF;
+ q->io_modes = VB2_MMAP | VB2_DMABUF | VB2_USERPTR;
q->drv_priv = vcap;
q->buf_struct_size = sizeof(struct vimc_cap_buffer);
q->ops = &vimc_cap_qops;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] vimc: add USERPTR support
2019-01-14 14:58 [PATCH] vimc: add USERPTR support Hans Verkuil
@ 2019-01-14 17:04 ` Helen Koike
2019-01-14 17:05 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Helen Koike @ 2019-01-14 17:04 UTC (permalink / raw)
To: Hans Verkuil, Linux Media Mailing List
Hi Hans,
Thanks for the patch.
On 1/14/19 12:58 PM, Hans Verkuil wrote:
> Add VB2_USERPTR to the vimc capture device.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
> diff --git a/drivers/media/platform/vimc/vimc-capture.c b/drivers/media/platform/vimc/vimc-capture.c
> index 3f7e9ed56633..35c730f484a7 100644
> --- a/drivers/media/platform/vimc/vimc-capture.c
> +++ b/drivers/media/platform/vimc/vimc-capture.c
> @@ -431,7 +431,7 @@ static int vimc_cap_comp_bind(struct device *comp, struct device *master,
> /* Initialize the vb2 queue */
> q = &vcap->queue;
> q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
> - q->io_modes = VB2_MMAP | VB2_DMABUF;
> + q->io_modes = VB2_MMAP | VB2_DMABUF | VB2_USERPTR;
> q->drv_priv = vcap;
> q->buf_struct_size = sizeof(struct vimc_cap_buffer);
> q->ops = &vimc_cap_qops;
>
I remember at the time I was having some issues regarding userptr, I
just want to make a few tests first.
Regards,
Helen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vimc: add USERPTR support
2019-01-14 17:04 ` Helen Koike
@ 2019-01-14 17:05 ` Hans Verkuil
2019-02-07 15:37 ` Helen Koike
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2019-01-14 17:05 UTC (permalink / raw)
To: Helen Koike, Linux Media Mailing List
On 1/14/19 6:04 PM, Helen Koike wrote:
> Hi Hans,
>
> Thanks for the patch.
>
> On 1/14/19 12:58 PM, Hans Verkuil wrote:
>> Add VB2_USERPTR to the vimc capture device.
>>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> ---
>> diff --git a/drivers/media/platform/vimc/vimc-capture.c b/drivers/media/platform/vimc/vimc-capture.c
>> index 3f7e9ed56633..35c730f484a7 100644
>> --- a/drivers/media/platform/vimc/vimc-capture.c
>> +++ b/drivers/media/platform/vimc/vimc-capture.c
>> @@ -431,7 +431,7 @@ static int vimc_cap_comp_bind(struct device *comp, struct device *master,
>> /* Initialize the vb2 queue */
>> q = &vcap->queue;
>> q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
>> - q->io_modes = VB2_MMAP | VB2_DMABUF;
>> + q->io_modes = VB2_MMAP | VB2_DMABUF | VB2_USERPTR;
>> q->drv_priv = vcap;
>> q->buf_struct_size = sizeof(struct vimc_cap_buffer);
>> q->ops = &vimc_cap_qops;
>>
>
> I remember at the time I was having some issues regarding userptr, I
> just want to make a few tests first.
Make sure you update to the latest v4l-utils first: there was a v4l2-compliance bug
that caused an incorrect FAIL for vimc.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vimc: add USERPTR support
2019-01-14 17:05 ` Hans Verkuil
@ 2019-02-07 15:37 ` Helen Koike
0 siblings, 0 replies; 4+ messages in thread
From: Helen Koike @ 2019-02-07 15:37 UTC (permalink / raw)
To: Hans Verkuil, Linux Media Mailing List
Hi Hans,
Sorry about my delay.
On 1/14/19 3:05 PM, Hans Verkuil wrote:
> On 1/14/19 6:04 PM, Helen Koike wrote:
>> Hi Hans,
>>
>> Thanks for the patch.
>>
>> On 1/14/19 12:58 PM, Hans Verkuil wrote:
>>> Add VB2_USERPTR to the vimc capture device.
>>>
>>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Helen Koike <helen.koike@collabora.com>
>>> ---
>>> diff --git a/drivers/media/platform/vimc/vimc-capture.c b/drivers/media/platform/vimc/vimc-capture.c
>>> index 3f7e9ed56633..35c730f484a7 100644
>>> --- a/drivers/media/platform/vimc/vimc-capture.c
>>> +++ b/drivers/media/platform/vimc/vimc-capture.c
>>> @@ -431,7 +431,7 @@ static int vimc_cap_comp_bind(struct device *comp, struct device *master,
>>> /* Initialize the vb2 queue */
>>> q = &vcap->queue;
>>> q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
>>> - q->io_modes = VB2_MMAP | VB2_DMABUF;
>>> + q->io_modes = VB2_MMAP | VB2_DMABUF | VB2_USERPTR;
>>> q->drv_priv = vcap;
>>> q->buf_struct_size = sizeof(struct vimc_cap_buffer);
>>> q->ops = &vimc_cap_qops;
>>>
>>
>> I remember at the time I was having some issues regarding userptr, I
>> just want to make a few tests first.
>
> Make sure you update to the latest v4l-utils first: there was a v4l2-compliance bug
> that caused an incorrect FAIL for vimc.
Indeed, seems to be working with latest v4l-utils.
>
> Regards,
>
> Hans
>
Thanks
Helen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-07 15:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 14:58 [PATCH] vimc: add USERPTR support Hans Verkuil
2019-01-14 17:04 ` Helen Koike
2019-01-14 17:05 ` Hans Verkuil
2019-02-07 15:37 ` Helen Koike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).