From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Heiko Stübner" <heiko@sntech.de>,
"Emmanuel Gil Peyrot" <linkmauve@linkmauve.fr>,
linux-kernel@vger.kernel.org
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Dragan Simic <dsimic@manjaro.org>,
Shreeya Patel <shreeya.patel@collabora.com>,
Chris Morgan <macromorgan@hotmail.com>,
Andy Yan <andy.yan@rock-chips.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux.dev
Subject: Re: [PATCH 2/4] media: dt-binding: media: Document rk3588’s vepu121
Date: Thu, 21 Mar 2024 10:19:54 +0100 [thread overview]
Message-ID: <70439a01-7949-46bf-a701-c82ba961171a@linaro.org> (raw)
In-Reply-To: <855507987.0ifERbkFSE@diego>
On 21/03/2024 09:47, Heiko Stübner wrote:
>>> enum:
>>> - rockchip,rk3568-vepu
>>> + - rockchip,rk3588-vepu121
>>
>> What is 121?
>
> That is the strange naming of the ip block inside the soc.
>
> I.e. the rk3588 TRM lists a number of different video encoders and decoders:
> - VDPU121 is decoding h.263 and mpeg1,2,4
> - VDPU381 is decoding h.265, h.264 and some more
> - VDPU720 is decoding jpeg
> - VDPU981 decodes AV1
> - VEPU121 is the jpeg encoder above
> - VEPU580 encodes h.264 and h.265
>
> Each of those are separate IP blocks with their own io-memory, their own
> interrupts and their own iommus, etc.
Thanks for explanation. Short introduction in commit msg would be nice
(e.g. VEPU121, one of two VEPU encoders). OTOH, why not documenting all
of them? Bindings are supposed to be as complete as possible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-21 9:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240320173736.2720778-1-linkmauve@linkmauve.fr>
[not found] ` <20240320173736.2720778-2-linkmauve@linkmauve.fr>
2024-03-20 19:15 ` [PATCH 1/4] dt-bindings: iommu: rockchip: Fix rk3588 variant Sebastian Reichel
2024-03-21 8:14 ` Krzysztof Kozlowski
[not found] ` <20240320173736.2720778-3-linkmauve@linkmauve.fr>
2024-03-20 20:16 ` [PATCH 2/4] media: dt-binding: media: Document rk3588’s vepu121 Sebastian Reichel
2024-03-21 8:14 ` Krzysztof Kozlowski
2024-03-21 8:47 ` Heiko Stübner
2024-03-21 9:19 ` Krzysztof Kozlowski [this message]
2024-03-21 9:32 ` Heiko Stübner
2024-03-22 14:57 ` Nicolas Dufresne
[not found] ` <20240320173736.2720778-4-linkmauve@linkmauve.fr>
2024-03-21 8:15 ` [PATCH 3/4] arm64: dts: rockchip: Add VEPU121 to rk3588 Krzysztof Kozlowski
2024-03-27 12:40 ` Link Mauve
2024-03-27 13:09 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70439a01-7949-46bf-a701-c82ba961171a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linkmauve@linkmauve.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sebastian.reichel@collabora.com \
--cc=shreeya.patel@collabora.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).