From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
niklas.soderlund+renesas@ragnatech.se
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Pratyush Yadav <p.yadav@ti.com>
Subject: Re: [PATCH v9 02/36] media: subdev: add active state to struct v4l2_subdev
Date: Tue, 12 Oct 2021 16:32:10 +0200 [thread overview]
Message-ID: <710f80a6-81a4-3c98-70d5-364e015d8bfd@xs4all.nl> (raw)
In-Reply-To: <20211005085750.138151-3-tomi.valkeinen@ideasonboard.com>
On 05/10/2021 10:57, Tomi Valkeinen wrote:
> Add a new 'state' field to struct v4l2_subdev to which we can store the
> active state of a subdev. This will place the subdev configuration into
> a known place, allowing us to use the state directly from the v4l2
> framework, thus simplifying the drivers.
>
> Also add functions v4l2_subdev_init_finalize() and
> v4l2_subdev_cleanup(), which will allocate and free the active state.
> The functions are named in a generic way so that they can be also used
> for other subdev initialization work.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
> drivers/media/v4l2-core/v4l2-subdev.c | 21 +++++++++++
> include/media/v4l2-subdev.h | 51 +++++++++++++++++++++++++++
> 2 files changed, 72 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index fe49c86a9b02..bcaf66a1e3d9 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -943,3 +943,24 @@ void v4l2_subdev_notify_event(struct v4l2_subdev *sd,
> v4l2_subdev_notify(sd, V4L2_DEVICE_NOTIFY_EVENT, (void *)ev);
> }
> EXPORT_SYMBOL_GPL(v4l2_subdev_notify_event);
> +
> +int v4l2_subdev_init_finalize(struct v4l2_subdev *sd)
> +{
> + struct v4l2_subdev_state *state;
> +
> + state = __v4l2_subdev_state_alloc(sd);
> + if (IS_ERR(state))
> + return PTR_ERR(state);
> +
> + sd->state = state;
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(v4l2_subdev_init_finalize);
> +
> +void v4l2_subdev_cleanup(struct v4l2_subdev *sd)
> +{
> + __v4l2_subdev_state_free(sd->state);
> + sd->state = NULL;
> +}
> +EXPORT_SYMBOL_GPL(v4l2_subdev_cleanup);
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index e52bf508c75b..3aaa7146e5ff 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -898,6 +898,8 @@ struct v4l2_subdev_platform_data {
> * @subdev_notifier: A sub-device notifier implicitly registered for the sub-
> * device using v4l2_async_register_subdev_sensor().
> * @pdata: common part of subdevice platform data
> + * @state: active state for the subdev (NULL for subdevs tracking the state
> + * internally)
> *
> * Each instance of a subdev driver should create this struct, either
> * stand-alone or embedded in a larger struct.
> @@ -929,6 +931,19 @@ struct v4l2_subdev {
> struct v4l2_async_notifier *notifier;
> struct v4l2_async_notifier *subdev_notifier;
> struct v4l2_subdev_platform_data *pdata;
> +
> + /*
> + * The fields below are private, and should only be accessed via
> + * appropriate functions.
> + */
> +
> + /*
> + * TODO: state should most likely be changed from a pointer to an
> + * embedded field. For the time being it's kept as a pointer to more
> + * easily catch uses of state in the cases where the driver doesn't
> + * support it.
> + */
> + struct v4l2_subdev_state *state;
Hmm:
struct v4l2_subdev_state {
struct v4l2_subdev_pad_config *pads;
};
and:
struct v4l2_subdev_pad_config {
struct v4l2_mbus_framefmt try_fmt;
struct v4l2_rect try_crop;
struct v4l2_rect try_compose;
};
So why is this the active state if struct v4l2_subdev_pad_config has try_* fields?
At the very least it should be mentioned somewhere in the code (and probably commit
log as well) that the try_ prefix is historical, or will be removed later, or something
like that.
Regards,
Hans
> };
>
>
> @@ -1217,4 +1232,40 @@ extern const struct v4l2_subdev_ops v4l2_subdev_call_wrappers;
> void v4l2_subdev_notify_event(struct v4l2_subdev *sd,
> const struct v4l2_event *ev);
>
> +/**
> + * v4l2_subdev_init_finalize() - Finalize the initialization of the subdevice
> + * @sd: The subdev
> + *
> + * This finalizes the initialization of the subdev, including allocation of
> + * the active state for the subdev.
> + *
> + * This must be called by the subdev drivers that use the centralized active
> + * state, after the subdev struct has been initialized and
> + * media_entity_pads_init() has been called.
> + *
> + * Must call v4l2_subdev_cleanup() when the subdev is being removed.
> + */
> +int v4l2_subdev_init_finalize(struct v4l2_subdev *sd);
> +
> +/**
> + * v4l2_subdev_cleanup() - Release the resources needed by the subdevice
> + * @sd: The subdevice
> + *
> + * This will release the resources allocated in v4l2_subdev_init_finalize.
> + */
> +void v4l2_subdev_cleanup(struct v4l2_subdev *sd);
> +
> +/**
> + * v4l2_subdev_get_active_state() - Return the active subdev state for subdevice
> + * @sd: The subdevice
> + *
> + * Return the active state for the subdevice, or NULL if the subdev does not
> + * support active state.
> + */
> +static inline struct v4l2_subdev_state *
> +v4l2_subdev_get_active_state(struct v4l2_subdev *sd)
> +{
> + return sd->state;
> +}
> +
> #endif
>
next prev parent reply other threads:[~2021-10-12 14:32 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 8:57 [PATCH v9 00/36] v4l: subdev internal routing and streams Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 01/36] media: subdev: rename subdev-state alloc & free Tomi Valkeinen
2021-10-12 13:46 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 02/36] media: subdev: add active state to struct v4l2_subdev Tomi Valkeinen
2021-10-12 14:32 ` Hans Verkuil [this message]
2021-11-04 10:59 ` Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 03/36] media: subdev: pass also the active state to subdevs from ioctls Tomi Valkeinen
2021-10-12 13:53 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 04/36] media: subdev: add subdev state locking Tomi Valkeinen
2021-10-12 14:36 ` Hans Verkuil
2021-11-04 11:11 ` Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 05/36] media: subdev: Add v4l2_subdev_validate_and_lock_state() Tomi Valkeinen
2021-10-12 14:16 ` Hans Verkuil
2021-11-04 11:15 ` Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 06/36] media: Documentation: add documentation about subdev state Tomi Valkeinen
2021-10-12 14:36 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 07/36] media: entity: Use pad as a starting point for graph walk Tomi Valkeinen
2021-10-12 14:46 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 08/36] media: entity: Use pads instead of entities in the media graph walk stack Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 09/36] media: entity: Walk the graph based on pads Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 10/36] media: mc: Start walk from a specific pad in use count calculation Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 11/36] media: entity: Add iterator helper for entity pads Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 12/36] media: entity: Move the pipeline from entity to pads Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 13/36] media: entity: Use pad as the starting point for a pipeline Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 14/36] media: entity: Add has_route entity operation Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 15/36] media: entity: Add media_entity_has_route() function Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 16/36] media: entity: Use routing information during graph traversal Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 17/36] media: entity: Skip link validation for pads to which there is no route Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 18/36] media: entity: Add an iterator helper for connected pads Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 19/36] media: entity: Add only connected pads to the pipeline Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 20/36] media: entity: Add debug information in graph walk route check Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 21/36] media: Add bus type to frame descriptors Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 22/36] media: Add CSI-2 bus configuration " Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 23/36] media: Add stream to frame descriptor Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 24/36] media: subdev: increase V4L2_FRAME_DESC_ENTRY_MAX to 8 Tomi Valkeinen
2021-10-12 14:44 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 25/36] media: add V4L2_SUBDEV_FL_MULTIPLEXED Tomi Valkeinen
2021-10-12 14:48 ` Hans Verkuil
2021-11-04 12:06 ` Tomi Valkeinen
2021-10-12 14:55 ` Hans Verkuil
2021-11-04 12:40 ` Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 26/36] media: Documentation: Add GS_ROUTING documentation Tomi Valkeinen
2021-10-12 14:56 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 27/36] media: subdev: Add [GS]_ROUTING subdev ioctls and operations Tomi Valkeinen
2021-10-06 6:47 ` Tomi Valkeinen
2021-10-10 7:36 ` Laurent Pinchart
2021-10-11 7:57 ` Tomi Valkeinen
2021-10-12 15:04 ` Hans Verkuil
2021-10-15 12:13 ` Jacopo Mondi
2021-10-15 12:36 ` Tomi Valkeinen
2021-10-15 14:05 ` Jacopo Mondi
2021-10-15 15:17 ` Tomi Valkeinen
2021-10-15 15:28 ` Jacopo Mondi
2021-10-15 16:10 ` Tomi Valkeinen
2021-10-15 16:47 ` Jacopo Mondi
2021-10-15 16:55 ` Tomi Valkeinen
2021-10-15 17:51 ` Jacopo Mondi
2021-11-18 10:54 ` Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 28/36] media: subdev: add v4l2_subdev_has_route() Tomi Valkeinen
2021-10-12 15:05 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 29/36] media: subdev: add v4l2_subdev_set_routing helper() Tomi Valkeinen
2021-10-10 10:21 ` Laurent Pinchart
2021-10-11 8:13 ` Tomi Valkeinen
2021-10-11 21:06 ` Laurent Pinchart
2021-10-12 5:09 ` Tomi Valkeinen
2021-10-12 15:07 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 30/36] media: Documentation: add multiplexed streams documentation Tomi Valkeinen
2021-10-12 15:34 ` Hans Verkuil
2021-11-04 13:27 ` Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 31/36] media: subdev: add stream based configuration Tomi Valkeinen
2021-10-13 7:17 ` Hans Verkuil
2021-11-30 11:40 ` Tomi Valkeinen
2021-10-05 8:57 ` [PATCH v9 32/36] media: subdev: use streams in v4l2_subdev_link_validate() Tomi Valkeinen
2021-10-13 7:27 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 33/36] media: subdev: add "opposite" stream helper funcs Tomi Valkeinen
2021-10-10 14:15 ` Laurent Pinchart
2021-10-10 14:18 ` Laurent Pinchart
2021-10-11 8:21 ` Tomi Valkeinen
2021-10-11 15:01 ` Laurent Pinchart
2021-10-13 7:30 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 34/36] media: subdev: add v4l2_subdev_get_fmt() helper function Tomi Valkeinen
2021-10-13 7:32 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 35/36] media: subdev: add v4l2_subdev_set_routing_with_fmt() helper Tomi Valkeinen
2021-10-13 7:32 ` Hans Verkuil
2021-10-05 8:57 ` [PATCH v9 36/36] media: subdev: add v4l2_routing_simple_verify() helper Tomi Valkeinen
2021-10-10 1:23 ` Laurent Pinchart
2021-10-11 7:25 ` Tomi Valkeinen
2021-10-11 21:08 ` Laurent Pinchart
2021-10-13 7:34 ` Hans Verkuil
2021-10-05 9:08 ` [PATCH v9 00/36] v4l: subdev internal routing and streams Tomi Valkeinen
2021-10-11 15:29 ` Hans Verkuil
2021-10-26 11:54 ` Tomi Valkeinen
2021-10-26 12:32 ` Jacopo Mondi
2021-10-26 12:40 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=710f80a6-81a4-3c98-70d5-364e015d8bfd@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=p.yadav@ti.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).