From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
laurent.pinchart@ideasonboard.com
Cc: niklas.soderlund+renesas@ragnatech.se,
kieran.bingham@ideasonboard.com, dave.stevenson@raspberrypi.com,
hyun.kwon@xilinx.com, linux-media@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/8] media: v4l2-subdv: Introduce [s|g]et_mbus_config pad ops
Date: Mon, 18 May 2020 11:53:38 +0200 [thread overview]
Message-ID: <71508b06-878d-ab11-417c-455dfc3fd6a5@xs4all.nl> (raw)
In-Reply-To: <20200514164540.507233-3-jacopo+renesas@jmondi.org>
For v4 can you fix the subject? It's v4l2-subdev, not v4l2-subdv.
Regards,
Hans
On 14/05/2020 18:45, Jacopo Mondi wrote:
> Introduce two new pad operations to allow retrieving and configuring the
> media bus configuration on a subdevice pad.
>
> The newly introduced operations aims to replace the s/g_mbus_config video
> operations, which have been on their way to be deprecated since a long
> time.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> include/media/v4l2-subdev.h | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index a4848de59852..8d5f4a255b87 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -670,6 +670,32 @@ struct v4l2_subdev_pad_config {
> *
> * @set_frame_desc: set the low level media bus frame parameters, @fd array
> * may be adjusted by the subdev driver to device capabilities.
> + *
> + * @get_mbus_config: get the current media bus configuration. This operation is
> + * intended to be used to synchronize the media bus
> + * configuration parameters between receivers and
> + * transmitters. The static bus configuration is usually
> + * received from the firmware interface, and updated
> + * dynamically using this operation to retrieve bus
> + * configuration parameters which could change at run-time.
> + * Callers should make sure they get the most up-to-date as
> + * possible configuration from the connected sub-device,
> + * likely calling this operation as close as possible to
> + * stream on time. The operation is allowed to fail if the
> + * pad index it has been called on is unsupported.
> + *
> + * @set_mbus_config: set the media bus configuration. This operations is
> + * intended to allow, in combination with the
> + * get_mbus_format operation, the negotiation of media bus
> + * configuration parameters between media subdevices.
> + * The initial media bus configuration is retrieved from
> + * the firmware interface and later updated through this
> + * operation if the sub-device allows changing it.
> + * The operation shall not fail if the requested configuration
> + * is not supported, but the driver shall update the received
> + * %config argument to reflect what has been actually applied
> + * to the hardware. The operation is allowed to fail if the
> + * pad index it has been called on is unsupported.
> */
> struct v4l2_subdev_pad_ops {
> int (*init_cfg)(struct v4l2_subdev *sd,
> @@ -710,6 +736,10 @@ struct v4l2_subdev_pad_ops {
> struct v4l2_mbus_frame_desc *fd);
> int (*set_frame_desc)(struct v4l2_subdev *sd, unsigned int pad,
> struct v4l2_mbus_frame_desc *fd);
> + int (*get_mbus_config)(struct v4l2_subdev *sd, unsigned int pad,
> + struct v4l2_mbus_config *config);
> + int (*set_mbus_config)(struct v4l2_subdev *sd, unsigned int pad,
> + struct v4l2_mbus_config *config);
> };
>
> /**
>
next prev parent reply other threads:[~2020-05-18 9:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 16:45 [PATCH v3 0/8] v4l2-subdev: Introduce [g|s]et_mbus_format pad op Jacopo Mondi
2020-05-14 16:45 ` [PATCH v3 1/8] media: v4l2-subdv: Introduce get_mbus_config " Jacopo Mondi
2020-05-14 16:45 ` [PATCH v3 1/8] media: v4l2-subdv: Introduce [s|g]et_mbus_config pad ops Jacopo Mondi
2020-05-18 9:53 ` Hans Verkuil [this message]
2020-05-14 16:45 ` [PATCH v3 2/8] media: i2c: Use the new get_mbus_config pad op Jacopo Mondi
2020-05-14 16:45 ` [PATCH v3 3/8] media: i2c: ov6650: Use new [g|s]_mbus_config op Jacopo Mondi
2020-05-18 10:00 ` Kieran Bingham
2020-05-14 16:45 ` [PATCH v3 4/8] media: pxa_camera: Use the new set_mbus_config op Jacopo Mondi
2020-05-14 16:45 ` [PATCH v3 5/8] media: v4l2-subdev: Deprecate g_mbus_config video op Jacopo Mondi
2020-05-18 8:48 ` Hans Verkuil
2020-05-14 16:45 ` [PATCH v3 6/8] media: i2c: adv748x: Adjust TXA data lanes number Jacopo Mondi
2020-05-14 16:45 ` [PATCH v3 7/8] media: i2c: adv748x: Implement get_mbus_config Jacopo Mondi
2020-05-14 16:45 ` [PATCH v3 8/8] media: rcar-csi2: Negotiate data lanes number Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71508b06-878d-ab11-417c-455dfc3fd6a5@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=dave.stevenson@raspberrypi.com \
--cc=hyun.kwon@xilinx.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).