* [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info
@ 2019-12-03 16:38 Jani Nikula
2019-12-03 16:38 ` [PATCH v3 10/12] media: constify fb ops across all drivers Jani Nikula
2019-12-03 16:42 ` [Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
0 siblings, 2 replies; 7+ messages in thread
From: Jani Nikula @ 2019-12-03 16:38 UTC (permalink / raw)
To: dri-devel, linux-fbdev
Cc: intel-gfx, jani.nikula, Andy Walls, Bernie Thompson,
Bruno Prémont, Daniel Vetter, Hans Verkuil, Jaya Kumar,
Kirti Wankhede, Miguel Ojeda Sandonis, Noralf Trønnes,
Robin van der Gracht, Steve Glendinning, Ville Syrjälä,
ivtv-devel, kvm, linux-input, linux-media, linux-omap
This is v3 of https://patchwork.freedesktop.org/series/70198/.
0day reported some build failures, and I needed to add patches 1-5 and 7
to address them. Patch 8 was amended accordingly (dropped some consts),
but the other patches remain the same from v2, except the ones I merged
already.
BR,
Jani.
Cc: Andy Walls <awalls@md.metrocast.net>
Cc: Bernie Thompson <bernie@plugable.com>
Cc: Bruno Prémont <bonbons@linux-vserver.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Jaya Kumar <jayalk@intworks.biz>
Cc: Kirti Wankhede <kwankhede@nvidia.com>
Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Robin van der Gracht <robin@protonic.nl>
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Cc: ivtv-devel@ivtvdriver.org
Cc: kvm@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Jani Nikula (12):
video: fbdev: atyfb: modify the static fb_ops directly
video: fbdev: mb862xx: modify the static fb_ops directly
video: fbdev: nvidia: modify the static fb_ops directly
video: fbdev: uvesafb: modify the static fb_ops directly
video: fbdev: make fbops member of struct fb_info a const pointer
drm: constify fb ops across all drivers
video: fbdev: intelfb: use const pointer for fb_ops
video: constify fb ops across all drivers
HID: picoLCD: constify fb ops
media: constify fb ops across all drivers
samples: vfio-mdev: constify fb ops
auxdisplay: constify fb ops
drivers/auxdisplay/cfag12864bfb.c | 2 +-
drivers/auxdisplay/ht16k33.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
drivers/gpu/drm/armada/armada_fbdev.c | 2 +-
drivers/gpu/drm/drm_fb_helper.c | 2 +-
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
.../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +-
drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +-
drivers/gpu/drm/msm/msm_fbdev.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 ++--
drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +-
drivers/gpu/drm/radeon/radeon_fb.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +-
drivers/gpu/drm/tegra/fb.c | 2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +-
drivers/hid/hid-picolcd_fb.c | 3 +--
drivers/media/pci/ivtv/ivtvfb.c | 3 +--
drivers/media/platform/vivid/vivid-osd.c | 3 +--
drivers/video/fbdev/68328fb.c | 2 +-
drivers/video/fbdev/acornfb.c | 2 +-
drivers/video/fbdev/amba-clcd.c | 2 +-
drivers/video/fbdev/amifb.c | 2 +-
drivers/video/fbdev/arcfb.c | 2 +-
drivers/video/fbdev/arkfb.c | 2 +-
drivers/video/fbdev/asiliantfb.c | 2 +-
drivers/video/fbdev/atmel_lcdfb.c | 2 +-
drivers/video/fbdev/aty/aty128fb.c | 2 +-
drivers/video/fbdev/aty/atyfb.h | 2 +-
drivers/video/fbdev/aty/atyfb_base.c | 6 +++---
drivers/video/fbdev/aty/mach64_cursor.c | 4 ++--
drivers/video/fbdev/aty/radeon_base.c | 2 +-
drivers/video/fbdev/au1100fb.c | 2 +-
drivers/video/fbdev/au1200fb.c | 2 +-
drivers/video/fbdev/broadsheetfb.c | 2 +-
drivers/video/fbdev/bw2.c | 2 +-
drivers/video/fbdev/carminefb.c | 2 +-
drivers/video/fbdev/cg14.c | 2 +-
drivers/video/fbdev/cg3.c | 2 +-
drivers/video/fbdev/cg6.c | 2 +-
drivers/video/fbdev/chipsfb.c | 2 +-
drivers/video/fbdev/cirrusfb.c | 2 +-
drivers/video/fbdev/clps711x-fb.c | 2 +-
drivers/video/fbdev/cobalt_lcdfb.c | 2 +-
drivers/video/fbdev/controlfb.c | 2 +-
drivers/video/fbdev/cyber2000fb.c | 2 +-
drivers/video/fbdev/da8xx-fb.c | 2 +-
drivers/video/fbdev/dnfb.c | 2 +-
drivers/video/fbdev/efifb.c | 2 +-
drivers/video/fbdev/ep93xx-fb.c | 2 +-
drivers/video/fbdev/fb-puv3.c | 2 +-
drivers/video/fbdev/ffb.c | 2 +-
drivers/video/fbdev/fm2fb.c | 2 +-
drivers/video/fbdev/fsl-diu-fb.c | 2 +-
drivers/video/fbdev/g364fb.c | 2 +-
drivers/video/fbdev/gbefb.c | 2 +-
drivers/video/fbdev/geode/gx1fb_core.c | 2 +-
drivers/video/fbdev/geode/gxfb_core.c | 2 +-
drivers/video/fbdev/geode/lxfb_core.c | 2 +-
drivers/video/fbdev/goldfishfb.c | 2 +-
drivers/video/fbdev/grvga.c | 2 +-
drivers/video/fbdev/gxt4500.c | 2 +-
drivers/video/fbdev/hecubafb.c | 2 +-
drivers/video/fbdev/hgafb.c | 2 +-
drivers/video/fbdev/hitfb.c | 2 +-
drivers/video/fbdev/hpfb.c | 2 +-
drivers/video/fbdev/hyperv_fb.c | 2 +-
drivers/video/fbdev/i740fb.c | 2 +-
drivers/video/fbdev/imsttfb.c | 2 +-
drivers/video/fbdev/imxfb.c | 2 +-
drivers/video/fbdev/intelfb/intelfb.h | 2 +-
drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
drivers/video/fbdev/kyro/fbdev.c | 2 +-
drivers/video/fbdev/leo.c | 2 +-
drivers/video/fbdev/macfb.c | 2 +-
drivers/video/fbdev/matrox/matroxfb_crtc2.c | 2 +-
drivers/video/fbdev/maxinefb.c | 2 +-
drivers/video/fbdev/mb862xx/mb862xxfb.h | 2 +-
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 15 +++++++-------
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 4 +++-
drivers/video/fbdev/mbx/mbxfb.c | 2 +-
drivers/video/fbdev/metronomefb.c | 2 +-
drivers/video/fbdev/mmp/fb/mmpfb.c | 2 +-
drivers/video/fbdev/mx3fb.c | 5 +++--
drivers/video/fbdev/neofb.c | 2 +-
drivers/video/fbdev/nvidia/nvidia.c | 20 ++++++++++---------
drivers/video/fbdev/ocfb.c | 2 +-
drivers/video/fbdev/offb.c | 2 +-
.../video/fbdev/omap2/omapfb/omapfb-main.c | 2 +-
drivers/video/fbdev/p9100.c | 2 +-
drivers/video/fbdev/platinumfb.c | 2 +-
drivers/video/fbdev/pm2fb.c | 2 +-
drivers/video/fbdev/pm3fb.c | 2 +-
drivers/video/fbdev/pmag-aa-fb.c | 2 +-
drivers/video/fbdev/pmag-ba-fb.c | 2 +-
drivers/video/fbdev/pmagb-b-fb.c | 2 +-
drivers/video/fbdev/ps3fb.c | 2 +-
drivers/video/fbdev/pvr2fb.c | 2 +-
drivers/video/fbdev/pxa168fb.c | 2 +-
drivers/video/fbdev/pxafb.c | 4 ++--
drivers/video/fbdev/q40fb.c | 2 +-
drivers/video/fbdev/riva/fbdev.c | 2 +-
drivers/video/fbdev/s3c-fb.c | 2 +-
drivers/video/fbdev/s3c2410fb.c | 2 +-
drivers/video/fbdev/s3fb.c | 2 +-
drivers/video/fbdev/sa1100fb.c | 2 +-
drivers/video/fbdev/savage/savagefb_driver.c | 2 +-
drivers/video/fbdev/sh7760fb.c | 2 +-
drivers/video/fbdev/sh_mobile_lcdcfb.c | 4 ++--
drivers/video/fbdev/simplefb.c | 2 +-
drivers/video/fbdev/sis/sis_main.c | 2 +-
drivers/video/fbdev/skeletonfb.c | 2 +-
drivers/video/fbdev/sm712fb.c | 2 +-
drivers/video/fbdev/smscufx.c | 2 +-
drivers/video/fbdev/ssd1307fb.c | 2 +-
drivers/video/fbdev/sstfb.c | 2 +-
drivers/video/fbdev/stifb.c | 2 +-
drivers/video/fbdev/sunxvr1000.c | 2 +-
drivers/video/fbdev/sunxvr2500.c | 2 +-
drivers/video/fbdev/sunxvr500.c | 2 +-
drivers/video/fbdev/tcx.c | 2 +-
drivers/video/fbdev/tdfxfb.c | 2 +-
drivers/video/fbdev/tgafb.c | 2 +-
drivers/video/fbdev/tmiofb.c | 2 +-
drivers/video/fbdev/tridentfb.c | 2 +-
drivers/video/fbdev/uvesafb.c | 4 ++--
drivers/video/fbdev/valkyriefb.c | 2 +-
drivers/video/fbdev/vfb.c | 2 +-
drivers/video/fbdev/vga16fb.c | 2 +-
drivers/video/fbdev/vt8500lcdfb.c | 2 +-
drivers/video/fbdev/vt8623fb.c | 2 +-
drivers/video/fbdev/w100fb.c | 2 +-
drivers/video/fbdev/wm8505fb.c | 2 +-
drivers/video/fbdev/xen-fbfront.c | 2 +-
drivers/video/fbdev/xilinxfb.c | 2 +-
include/linux/fb.h | 2 +-
samples/vfio-mdev/mdpy-fb.c | 2 +-
136 files changed, 163 insertions(+), 162 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 10/12] media: constify fb ops across all drivers
2019-12-03 16:38 [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
@ 2019-12-03 16:38 ` Jani Nikula
2019-12-04 11:33 ` Sakari Ailus
2019-12-12 9:02 ` Hans Verkuil
2019-12-03 16:42 ` [Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
1 sibling, 2 replies; 7+ messages in thread
From: Jani Nikula @ 2019-12-03 16:38 UTC (permalink / raw)
To: dri-devel, linux-fbdev
Cc: intel-gfx, jani.nikula, Hans Verkuil, Andy Walls, linux-media,
ivtv-devel, Daniel Vetter
Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.
Remove the redundant fbops assignments while at it.
v2:
- actually add const in vivid
- fix typo (Christophe de Dinechin)
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Andy Walls <awalls@md.metrocast.net>
Cc: linux-media@vger.kernel.org
Cc: ivtv-devel@ivtvdriver.org
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/media/pci/ivtv/ivtvfb.c | 3 +--
drivers/media/platform/vivid/vivid-osd.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c
index 95a56cce9b65..f2922b554b09 100644
--- a/drivers/media/pci/ivtv/ivtvfb.c
+++ b/drivers/media/pci/ivtv/ivtvfb.c
@@ -925,7 +925,7 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info)
return 0;
}
-static struct fb_ops ivtvfb_ops = {
+static const struct fb_ops ivtvfb_ops = {
.owner = THIS_MODULE,
.fb_write = ivtvfb_write,
.fb_check_var = ivtvfb_check_var,
@@ -1049,7 +1049,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv)
oi->ivtvfb_info.node = -1;
oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT;
- oi->ivtvfb_info.fbops = &ivtvfb_ops;
oi->ivtvfb_info.par = itv;
oi->ivtvfb_info.var = oi->ivtvfb_defined;
oi->ivtvfb_info.fix = oi->ivtvfb_fix;
diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c
index f2e789bdf4a6..fbaec8acc161 100644
--- a/drivers/media/platform/vivid/vivid-osd.c
+++ b/drivers/media/platform/vivid/vivid-osd.c
@@ -244,7 +244,7 @@ static int vivid_fb_blank(int blank_mode, struct fb_info *info)
return 0;
}
-static struct fb_ops vivid_fb_ops = {
+static const struct fb_ops vivid_fb_ops = {
.owner = THIS_MODULE,
.fb_check_var = vivid_fb_check_var,
.fb_set_par = vivid_fb_set_par,
@@ -311,7 +311,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev)
dev->fb_info.node = -1;
dev->fb_info.flags = FBINFO_FLAG_DEFAULT;
- dev->fb_info.fbops = &vivid_fb_ops;
dev->fb_info.par = dev;
dev->fb_info.var = dev->fb_defined;
dev->fb_info.fix = dev->fb_fix;
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 10/12] media: constify fb ops across all drivers
2019-12-03 16:38 ` [PATCH v3 10/12] media: constify fb ops across all drivers Jani Nikula
@ 2019-12-04 11:33 ` Sakari Ailus
2019-12-05 9:40 ` Jani Nikula
2019-12-12 9:02 ` Hans Verkuil
1 sibling, 1 reply; 7+ messages in thread
From: Sakari Ailus @ 2019-12-04 11:33 UTC (permalink / raw)
To: Jani Nikula
Cc: dri-devel, linux-fbdev, intel-gfx, Hans Verkuil, Andy Walls,
linux-media, ivtv-devel, Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:52PM +0200, Jani Nikula wrote:
> Now that the fbops member of struct fb_info is const, we can start
> making the ops const as well.
>
> Remove the redundant fbops assignments while at it.
>
> v2:
> - actually add const in vivid
> - fix typo (Christophe de Dinechin)
>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: Andy Walls <awalls@md.metrocast.net>
> Cc: linux-media@vger.kernel.org
> Cc: ivtv-devel@ivtvdriver.org
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 10/12] media: constify fb ops across all drivers
2019-12-04 11:33 ` Sakari Ailus
@ 2019-12-05 9:40 ` Jani Nikula
0 siblings, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2019-12-05 9:40 UTC (permalink / raw)
To: Sakari Ailus
Cc: dri-devel, linux-fbdev, intel-gfx, Hans Verkuil, Andy Walls,
linux-media, ivtv-devel, Daniel Vetter
On Wed, 04 Dec 2019, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> On Tue, Dec 03, 2019 at 06:38:52PM +0200, Jani Nikula wrote:
>> Now that the fbops member of struct fb_info is const, we can start
>> making the ops const as well.
>>
>> Remove the redundant fbops assignments while at it.
>>
>> v2:
>> - actually add const in vivid
>> - fix typo (Christophe de Dinechin)
>>
>> Cc: Hans Verkuil <hverkuil@xs4all.nl>
>> Cc: Andy Walls <awalls@md.metrocast.net>
>> Cc: linux-media@vger.kernel.org
>> Cc: ivtv-devel@ivtvdriver.org
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Thanks for the review!
Andy, Hans, may I have your ack to merge this through drm-misc please?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 10/12] media: constify fb ops across all drivers
2019-12-03 16:38 ` [PATCH v3 10/12] media: constify fb ops across all drivers Jani Nikula
2019-12-04 11:33 ` Sakari Ailus
@ 2019-12-12 9:02 ` Hans Verkuil
2019-12-13 10:41 ` Jani Nikula
1 sibling, 1 reply; 7+ messages in thread
From: Hans Verkuil @ 2019-12-12 9:02 UTC (permalink / raw)
To: Jani Nikula, dri-devel, linux-fbdev
Cc: intel-gfx, Andy Walls, linux-media, Daniel Vetter
On 12/3/19 5:38 PM, Jani Nikula wrote:
> Now that the fbops member of struct fb_info is const, we can start
> making the ops const as well.
>
> Remove the redundant fbops assignments while at it.
>
> v2:
> - actually add const in vivid
> - fix typo (Christophe de Dinechin)
>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: Andy Walls <awalls@md.metrocast.net>
> Cc: linux-media@vger.kernel.org
> Cc: ivtv-devel@ivtvdriver.org
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Thanks!
Hans
> ---
> drivers/media/pci/ivtv/ivtvfb.c | 3 +--
> drivers/media/platform/vivid/vivid-osd.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c
> index 95a56cce9b65..f2922b554b09 100644
> --- a/drivers/media/pci/ivtv/ivtvfb.c
> +++ b/drivers/media/pci/ivtv/ivtvfb.c
> @@ -925,7 +925,7 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info)
> return 0;
> }
>
> -static struct fb_ops ivtvfb_ops = {
> +static const struct fb_ops ivtvfb_ops = {
> .owner = THIS_MODULE,
> .fb_write = ivtvfb_write,
> .fb_check_var = ivtvfb_check_var,
> @@ -1049,7 +1049,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv)
>
> oi->ivtvfb_info.node = -1;
> oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT;
> - oi->ivtvfb_info.fbops = &ivtvfb_ops;
> oi->ivtvfb_info.par = itv;
> oi->ivtvfb_info.var = oi->ivtvfb_defined;
> oi->ivtvfb_info.fix = oi->ivtvfb_fix;
> diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c
> index f2e789bdf4a6..fbaec8acc161 100644
> --- a/drivers/media/platform/vivid/vivid-osd.c
> +++ b/drivers/media/platform/vivid/vivid-osd.c
> @@ -244,7 +244,7 @@ static int vivid_fb_blank(int blank_mode, struct fb_info *info)
> return 0;
> }
>
> -static struct fb_ops vivid_fb_ops = {
> +static const struct fb_ops vivid_fb_ops = {
> .owner = THIS_MODULE,
> .fb_check_var = vivid_fb_check_var,
> .fb_set_par = vivid_fb_set_par,
> @@ -311,7 +311,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev)
>
> dev->fb_info.node = -1;
> dev->fb_info.flags = FBINFO_FLAG_DEFAULT;
> - dev->fb_info.fbops = &vivid_fb_ops;
> dev->fb_info.par = dev;
> dev->fb_info.var = dev->fb_defined;
> dev->fb_info.fix = dev->fb_fix;
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 10/12] media: constify fb ops across all drivers
2019-12-12 9:02 ` Hans Verkuil
@ 2019-12-13 10:41 ` Jani Nikula
0 siblings, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2019-12-13 10:41 UTC (permalink / raw)
To: Hans Verkuil, dri-devel, linux-fbdev
Cc: intel-gfx, Andy Walls, linux-media, Daniel Vetter, Sakari Ailus
On Thu, 12 Dec 2019, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 12/3/19 5:38 PM, Jani Nikula wrote:
>> Now that the fbops member of struct fb_info is const, we can start
>> making the ops const as well.
>>
>> Remove the redundant fbops assignments while at it.
>>
>> v2:
>> - actually add const in vivid
>> - fix typo (Christophe de Dinechin)
>>
>> Cc: Hans Verkuil <hverkuil@xs4all.nl>
>> Cc: Andy Walls <awalls@md.metrocast.net>
>> Cc: linux-media@vger.kernel.org
>> Cc: ivtv-devel@ivtvdriver.org
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Pushed to drm-misc-next, thanks for the reviews and acks.
BR,
Jani.
>
> Thanks!
>
> Hans
>
>> ---
>> drivers/media/pci/ivtv/ivtvfb.c | 3 +--
>> drivers/media/platform/vivid/vivid-osd.c | 3 +--
>> 2 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c
>> index 95a56cce9b65..f2922b554b09 100644
>> --- a/drivers/media/pci/ivtv/ivtvfb.c
>> +++ b/drivers/media/pci/ivtv/ivtvfb.c
>> @@ -925,7 +925,7 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info)
>> return 0;
>> }
>>
>> -static struct fb_ops ivtvfb_ops = {
>> +static const struct fb_ops ivtvfb_ops = {
>> .owner = THIS_MODULE,
>> .fb_write = ivtvfb_write,
>> .fb_check_var = ivtvfb_check_var,
>> @@ -1049,7 +1049,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv)
>>
>> oi->ivtvfb_info.node = -1;
>> oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT;
>> - oi->ivtvfb_info.fbops = &ivtvfb_ops;
>> oi->ivtvfb_info.par = itv;
>> oi->ivtvfb_info.var = oi->ivtvfb_defined;
>> oi->ivtvfb_info.fix = oi->ivtvfb_fix;
>> diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c
>> index f2e789bdf4a6..fbaec8acc161 100644
>> --- a/drivers/media/platform/vivid/vivid-osd.c
>> +++ b/drivers/media/platform/vivid/vivid-osd.c
>> @@ -244,7 +244,7 @@ static int vivid_fb_blank(int blank_mode, struct fb_info *info)
>> return 0;
>> }
>>
>> -static struct fb_ops vivid_fb_ops = {
>> +static const struct fb_ops vivid_fb_ops = {
>> .owner = THIS_MODULE,
>> .fb_check_var = vivid_fb_check_var,
>> .fb_set_par = vivid_fb_set_par,
>> @@ -311,7 +311,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev)
>>
>> dev->fb_info.node = -1;
>> dev->fb_info.flags = FBINFO_FLAG_DEFAULT;
>> - dev->fb_info.fbops = &vivid_fb_ops;
>> dev->fb_info.par = dev;
>> dev->fb_info.var = dev->fb_defined;
>> dev->fb_info.fix = dev->fb_fix;
>>
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info
2019-12-03 16:38 [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
2019-12-03 16:38 ` [PATCH v3 10/12] media: constify fb ops across all drivers Jani Nikula
@ 2019-12-03 16:42 ` Jani Nikula
1 sibling, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2019-12-03 16:42 UTC (permalink / raw)
To: dri-devel, linux-fbdev
Cc: Steve Glendinning, Andy Walls, kvm, linux-omap,
Robin van der Gracht, intel-gfx, Bernie Thompson, Kirti Wankhede,
Hans Verkuil, Miguel Ojeda Sandonis, Bruno Prémont,
Noralf Trønnes, ivtv-devel, linux-input, linux-media,
Jaya Kumar
On Tue, 03 Dec 2019, Jani Nikula <jani.nikula@intel.com> wrote:
> This is v3 of https://patchwork.freedesktop.org/series/70198/.
>
> 0day reported some build failures, and I needed to add patches 1-5 and 7
Should be, patches 1-4 and 7.
> to address them. Patch 8 was amended accordingly (dropped some consts),
> but the other patches remain the same from v2, except the ones I merged
> already.
>
> BR,
> Jani.
>
>
> Cc: Andy Walls <awalls@md.metrocast.net>
> Cc: Bernie Thompson <bernie@plugable.com>
> Cc: Bruno Prémont <bonbons@linux-vserver.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: Jaya Kumar <jayalk@intworks.biz>
> Cc: Kirti Wankhede <kwankhede@nvidia.com>
> Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Robin van der Gracht <robin@protonic.nl>
> Cc: Steve Glendinning <steve.glendinning@shawell.net>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: ivtv-devel@ivtvdriver.org
> Cc: kvm@vger.kernel.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
>
> Jani Nikula (12):
> video: fbdev: atyfb: modify the static fb_ops directly
> video: fbdev: mb862xx: modify the static fb_ops directly
> video: fbdev: nvidia: modify the static fb_ops directly
> video: fbdev: uvesafb: modify the static fb_ops directly
> video: fbdev: make fbops member of struct fb_info a const pointer
> drm: constify fb ops across all drivers
> video: fbdev: intelfb: use const pointer for fb_ops
> video: constify fb ops across all drivers
> HID: picoLCD: constify fb ops
> media: constify fb ops across all drivers
> samples: vfio-mdev: constify fb ops
> auxdisplay: constify fb ops
>
> drivers/auxdisplay/cfag12864bfb.c | 2 +-
> drivers/auxdisplay/ht16k33.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
> drivers/gpu/drm/armada/armada_fbdev.c | 2 +-
> drivers/gpu/drm/drm_fb_helper.c | 2 +-
> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +-
> drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +-
> drivers/gpu/drm/msm/msm_fbdev.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 ++--
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +-
> drivers/gpu/drm/radeon/radeon_fb.c | 2 +-
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +-
> drivers/gpu/drm/tegra/fb.c | 2 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +-
> drivers/hid/hid-picolcd_fb.c | 3 +--
> drivers/media/pci/ivtv/ivtvfb.c | 3 +--
> drivers/media/platform/vivid/vivid-osd.c | 3 +--
> drivers/video/fbdev/68328fb.c | 2 +-
> drivers/video/fbdev/acornfb.c | 2 +-
> drivers/video/fbdev/amba-clcd.c | 2 +-
> drivers/video/fbdev/amifb.c | 2 +-
> drivers/video/fbdev/arcfb.c | 2 +-
> drivers/video/fbdev/arkfb.c | 2 +-
> drivers/video/fbdev/asiliantfb.c | 2 +-
> drivers/video/fbdev/atmel_lcdfb.c | 2 +-
> drivers/video/fbdev/aty/aty128fb.c | 2 +-
> drivers/video/fbdev/aty/atyfb.h | 2 +-
> drivers/video/fbdev/aty/atyfb_base.c | 6 +++---
> drivers/video/fbdev/aty/mach64_cursor.c | 4 ++--
> drivers/video/fbdev/aty/radeon_base.c | 2 +-
> drivers/video/fbdev/au1100fb.c | 2 +-
> drivers/video/fbdev/au1200fb.c | 2 +-
> drivers/video/fbdev/broadsheetfb.c | 2 +-
> drivers/video/fbdev/bw2.c | 2 +-
> drivers/video/fbdev/carminefb.c | 2 +-
> drivers/video/fbdev/cg14.c | 2 +-
> drivers/video/fbdev/cg3.c | 2 +-
> drivers/video/fbdev/cg6.c | 2 +-
> drivers/video/fbdev/chipsfb.c | 2 +-
> drivers/video/fbdev/cirrusfb.c | 2 +-
> drivers/video/fbdev/clps711x-fb.c | 2 +-
> drivers/video/fbdev/cobalt_lcdfb.c | 2 +-
> drivers/video/fbdev/controlfb.c | 2 +-
> drivers/video/fbdev/cyber2000fb.c | 2 +-
> drivers/video/fbdev/da8xx-fb.c | 2 +-
> drivers/video/fbdev/dnfb.c | 2 +-
> drivers/video/fbdev/efifb.c | 2 +-
> drivers/video/fbdev/ep93xx-fb.c | 2 +-
> drivers/video/fbdev/fb-puv3.c | 2 +-
> drivers/video/fbdev/ffb.c | 2 +-
> drivers/video/fbdev/fm2fb.c | 2 +-
> drivers/video/fbdev/fsl-diu-fb.c | 2 +-
> drivers/video/fbdev/g364fb.c | 2 +-
> drivers/video/fbdev/gbefb.c | 2 +-
> drivers/video/fbdev/geode/gx1fb_core.c | 2 +-
> drivers/video/fbdev/geode/gxfb_core.c | 2 +-
> drivers/video/fbdev/geode/lxfb_core.c | 2 +-
> drivers/video/fbdev/goldfishfb.c | 2 +-
> drivers/video/fbdev/grvga.c | 2 +-
> drivers/video/fbdev/gxt4500.c | 2 +-
> drivers/video/fbdev/hecubafb.c | 2 +-
> drivers/video/fbdev/hgafb.c | 2 +-
> drivers/video/fbdev/hitfb.c | 2 +-
> drivers/video/fbdev/hpfb.c | 2 +-
> drivers/video/fbdev/hyperv_fb.c | 2 +-
> drivers/video/fbdev/i740fb.c | 2 +-
> drivers/video/fbdev/imsttfb.c | 2 +-
> drivers/video/fbdev/imxfb.c | 2 +-
> drivers/video/fbdev/intelfb/intelfb.h | 2 +-
> drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
> drivers/video/fbdev/kyro/fbdev.c | 2 +-
> drivers/video/fbdev/leo.c | 2 +-
> drivers/video/fbdev/macfb.c | 2 +-
> drivers/video/fbdev/matrox/matroxfb_crtc2.c | 2 +-
> drivers/video/fbdev/maxinefb.c | 2 +-
> drivers/video/fbdev/mb862xx/mb862xxfb.h | 2 +-
> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 15 +++++++-------
> drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 4 +++-
> drivers/video/fbdev/mbx/mbxfb.c | 2 +-
> drivers/video/fbdev/metronomefb.c | 2 +-
> drivers/video/fbdev/mmp/fb/mmpfb.c | 2 +-
> drivers/video/fbdev/mx3fb.c | 5 +++--
> drivers/video/fbdev/neofb.c | 2 +-
> drivers/video/fbdev/nvidia/nvidia.c | 20 ++++++++++---------
> drivers/video/fbdev/ocfb.c | 2 +-
> drivers/video/fbdev/offb.c | 2 +-
> .../video/fbdev/omap2/omapfb/omapfb-main.c | 2 +-
> drivers/video/fbdev/p9100.c | 2 +-
> drivers/video/fbdev/platinumfb.c | 2 +-
> drivers/video/fbdev/pm2fb.c | 2 +-
> drivers/video/fbdev/pm3fb.c | 2 +-
> drivers/video/fbdev/pmag-aa-fb.c | 2 +-
> drivers/video/fbdev/pmag-ba-fb.c | 2 +-
> drivers/video/fbdev/pmagb-b-fb.c | 2 +-
> drivers/video/fbdev/ps3fb.c | 2 +-
> drivers/video/fbdev/pvr2fb.c | 2 +-
> drivers/video/fbdev/pxa168fb.c | 2 +-
> drivers/video/fbdev/pxafb.c | 4 ++--
> drivers/video/fbdev/q40fb.c | 2 +-
> drivers/video/fbdev/riva/fbdev.c | 2 +-
> drivers/video/fbdev/s3c-fb.c | 2 +-
> drivers/video/fbdev/s3c2410fb.c | 2 +-
> drivers/video/fbdev/s3fb.c | 2 +-
> drivers/video/fbdev/sa1100fb.c | 2 +-
> drivers/video/fbdev/savage/savagefb_driver.c | 2 +-
> drivers/video/fbdev/sh7760fb.c | 2 +-
> drivers/video/fbdev/sh_mobile_lcdcfb.c | 4 ++--
> drivers/video/fbdev/simplefb.c | 2 +-
> drivers/video/fbdev/sis/sis_main.c | 2 +-
> drivers/video/fbdev/skeletonfb.c | 2 +-
> drivers/video/fbdev/sm712fb.c | 2 +-
> drivers/video/fbdev/smscufx.c | 2 +-
> drivers/video/fbdev/ssd1307fb.c | 2 +-
> drivers/video/fbdev/sstfb.c | 2 +-
> drivers/video/fbdev/stifb.c | 2 +-
> drivers/video/fbdev/sunxvr1000.c | 2 +-
> drivers/video/fbdev/sunxvr2500.c | 2 +-
> drivers/video/fbdev/sunxvr500.c | 2 +-
> drivers/video/fbdev/tcx.c | 2 +-
> drivers/video/fbdev/tdfxfb.c | 2 +-
> drivers/video/fbdev/tgafb.c | 2 +-
> drivers/video/fbdev/tmiofb.c | 2 +-
> drivers/video/fbdev/tridentfb.c | 2 +-
> drivers/video/fbdev/uvesafb.c | 4 ++--
> drivers/video/fbdev/valkyriefb.c | 2 +-
> drivers/video/fbdev/vfb.c | 2 +-
> drivers/video/fbdev/vga16fb.c | 2 +-
> drivers/video/fbdev/vt8500lcdfb.c | 2 +-
> drivers/video/fbdev/vt8623fb.c | 2 +-
> drivers/video/fbdev/w100fb.c | 2 +-
> drivers/video/fbdev/wm8505fb.c | 2 +-
> drivers/video/fbdev/xen-fbfront.c | 2 +-
> drivers/video/fbdev/xilinxfb.c | 2 +-
> include/linux/fb.h | 2 +-
> samples/vfio-mdev/mdpy-fb.c | 2 +-
> 136 files changed, 163 insertions(+), 162 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-13 10:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 16:38 [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
2019-12-03 16:38 ` [PATCH v3 10/12] media: constify fb ops across all drivers Jani Nikula
2019-12-04 11:33 ` Sakari Ailus
2019-12-05 9:40 ` Jani Nikula
2019-12-12 9:02 ` Hans Verkuil
2019-12-13 10:41 ` Jani Nikula
2019-12-03 16:42 ` [Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).