From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D4DC43331 for ; Mon, 30 Mar 2020 20:19:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFBDD2072E for ; Mon, 30 Mar 2020 20:19:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728376AbgC3UTh (ORCPT ); Mon, 30 Mar 2020 16:19:37 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36212 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727170AbgC3UTh (ORCPT ); Mon, 30 Mar 2020 16:19:37 -0400 Received: from [IPv6:2804:431:e7cc:11ff:4f80:3de:e2b2:5c1d] (unknown [IPv6:2804:431:e7cc:11ff:4f80:3de:e2b2:5c1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: koike) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C4F8B296601; Mon, 30 Mar 2020 21:19:30 +0100 (BST) Subject: Re: [PATCH] media: staging: rkisp1: cap: change RGB24 format to XBGR32 To: Dafna Hirschfeld , linux-media@vger.kernel.org, ezequiel@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org, mchehab@kernel.org, laurent.pinchart@ideasonboard.com References: <20200328135311.21221-1-dafna.hirschfeld@collabora.com> From: Helen Koike Message-ID: <7d387293-5fc8-6d6e-bc5a-03138a247d50@collabora.com> Date: Mon, 30 Mar 2020 17:19:25 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200328135311.21221-1-dafna.hirschfeld@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 3/28/20 10:53 AM, Dafna Hirschfeld wrote: > According to the manual, the YUV->RGB conversion outputs s/manual/datasheet > "24 bit word" that means that each pixel is 4 byte but the last > one should be ignored. This matches format V4L2_PIX_FMT_XBGR32. I think you can re-word this a bit, since 24bits is 3 bytes, and this doesn't mean 4 bytes are used. I guess you meant that datasheet says 4 bytes are used, with 24bits for the RGB and the last byte is ignored. > > Signed-off-by: Dafna Hirschfeld > --- > The patch rebased on to of the patch > "media: staging: rkisp1: cap: remove field fmt_type from struct rkisp1_capture_fmt_cfg" > > drivers/staging/media/rkisp1/rkisp1-capture.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c > index 3abf38362f5a..5f248b68190e 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-capture.c > +++ b/drivers/staging/media/rkisp1/rkisp1-capture.c > @@ -281,7 +281,7 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = { > }, > /* rgb */ > { > - .fourcc = V4L2_PIX_FMT_RGB24, > + .fourcc = V4L2_PIX_FMT_XBGR32, Shouldn't it be V4L2_PIX_FMT_RGBX32 ? Or the colors are inverted as well? Regards, Helen > .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, > .output_format = RKISP1_MI_CTRL_SP_OUTPUT_RGB888, > }, { >