From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zhi Mao <zhi.mao@mediatek.com>,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, sakari.ailus@linux.intel.com
Cc: laurent.pinchart@ideasonboard.com, shengnan.wang@mediatek.com,
yaya.chang@mediatek.com, 10572168@qq.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
yunkec@chromium.org, conor+dt@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
jacopo.mondi@ideasonboard.com, hverkuil-cisco@xs4all.nl,
heiko@sntech.de, jernej.skrabec@gmail.com,
macromorgan@hotmail.com, linus.walleij@linaro.org,
hdegoede@redhat.com, tomi.valkeinen@ideasonboard.com,
gerald.loacker@wolfvision.net, andy.shevchenko@gmail.com,
bingbu.cao@intel.com, dan.scally@ideasonboard.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 1/2] media: dt-bindings: media: i2c: Document GC08A3 bindings
Date: Tue, 9 Jan 2024 10:24:27 +0100 [thread overview]
Message-ID: <7dbe0235-43f3-4060-b7ac-4c429c5aff4e@linaro.org> (raw)
In-Reply-To: <20240109022715.30278-2-zhi.mao@mediatek.com>
On 09/01/2024 03:27, Zhi Mao wrote:
> Add YAML device tree binding for GC08A3 CMOS image sensor,
> and the relevant MAINTAINERS entries.
>
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Subject: only one "media", so:
media: dt-bindings: i2c: add GalaxyCore GC08A3 image sensor
> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
...
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor0@31 {
sensor@31
With above fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Before you reply, fix your email client. It's impossible to read your
responses.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-09 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 2:27 [PATCH v3 0/2] media: i2c: Add support for GC08A3 sensor Zhi Mao
2024-01-09 2:27 ` [PATCH v3 1/2] media: dt-bindings: media: i2c: Document GC08A3 bindings Zhi Mao
2024-01-09 9:24 ` Krzysztof Kozlowski [this message]
2024-02-04 6:34 ` Zhi Mao (毛智)
2024-01-09 2:27 ` [PATCH v3 2/2] media: i2c: Add GC08A3 image sensor driver Zhi Mao
2024-01-09 10:18 ` Sakari Ailus
2024-01-25 2:24 ` Zhi Mao (毛智)
2024-01-25 16:01 ` sakari.ailus
2024-02-04 6:38 ` Zhi Mao (毛智)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dbe0235-43f3-4060-b7ac-4c429c5aff4e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=10572168@qq.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bingbu.cao@intel.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yaya.chang@mediatek.com \
--cc=yunkec@chromium.org \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).