From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F8EC169C4 for ; Mon, 11 Feb 2019 16:01:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51A90218D8 for ; Mon, 11 Feb 2019 16:01:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=lucaceresoli.net header.i=@lucaceresoli.net header.b="FNbZIcye" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730202AbfBKOa5 (ORCPT ); Mon, 11 Feb 2019 09:30:57 -0500 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:58975 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727932AbfBKOax (ORCPT ); Mon, 11 Feb 2019 09:30:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lucaceresoli.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FFBmXTFfBaLH3E7i5uEuHI1tsd9hSjt1JGYFR5EmZAQ=; b=FNbZIcyeIW/IpXcw57jEEOvIQR jqtVa/s3cL/Fw5zTtq5IEDT3STamGaJrm5VmnJ14e9rWQV2vClwUsRLPmei9S5yam02FEw5NTW6Xq FS2+9D+9N/hG0pMyPd+L481GZMUGzX8o8Q8Y/iBcLoJHDoC6V4vyJSOn8DlBPHSCzY8M=; Received: from [109.168.11.45] (port=32896 helo=[192.168.101.224]) by hostingweb31.netsons.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gtCbg-000mJq-3j; Mon, 11 Feb 2019 15:30:48 +0100 Subject: Re: [PATCH v3 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem To: Vishal Sagar , Vishal Sagar , Hyun Kwon , "laurent.pinchart@ideasonboard.com" , "mchehab@kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , Michal Simek , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "sakari.ailus@linux.intel.com" , "hans.verkuil@cisco.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Dinesh Kumar , Sandip Kothari References: <1549025766-135037-1-git-send-email-vishal.sagar@xilinx.com> <1549025766-135037-3-git-send-email-vishal.sagar@xilinx.com> <3923069f-7c69-c601-0ded-f7629696ef9b@lucaceresoli.net> From: Luca Ceresoli Message-ID: <7fc3bd7b-4537-3df5-12ee-55ebec17a8bd@lucaceresoli.net> Date: Mon, 11 Feb 2019 15:30:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, thanks for the quick reply. On 11/02/19 13:43, Vishal Sagar wrote: >>> +static int xcsi2rxss_start_stream(struct xcsi2rxss_state *state) >>> +{ >>> + struct xcsi2rxss_core *core = &state->core; >>> + int ret = 0; >>> + >>> + xcsi2rxss_enable(core); >>> + >>> + ret = xcsi2rxss_reset(core); >>> + if (ret < 0) { >>> + state->streaming = false; >>> + return ret; >>> + } >>> + >>> + xcsi2rxss_intr_enable(core); >>> + state->streaming = true; >> >> Shouldn't you propagate s_stream to the upstream subdev here calling >> v4l2_subdev_call(..., ..., s_stream, 1)? >> > > This is done by the xvip_pipeline_start_stop() in xilinx-dma.c for Xilinx Video pipeline. Indeed it does, however other CSI2 RX drivers do propagate s_stream in their own s_stream. Not strictly related to this driver, but what's the logic for having these two different behaviors? Also xvip_pipeline_start_stop() only follows the graph through entity->pads[0], so it looks like it cannot handle entities with multiple sink pads. How would it be able to handle e.g. the AXI4-Stream Switch [0], which has 2+ sink pads? [0] https://www.xilinx.com/support/documentation/ip_documentation/axis_infrastructure_ip_suite/v1_1/pg085-axi4stream-infrastructure.pdf (page 16). -- Luca