From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA02AC43331 for ; Mon, 30 Mar 2020 19:20:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81D702072E for ; Mon, 30 Mar 2020 19:20:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbgC3TUy (ORCPT ); Mon, 30 Mar 2020 15:20:54 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:35738 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbgC3TUx (ORCPT ); Mon, 30 Mar 2020 15:20:53 -0400 Received: from [IPv6:2804:431:e7cc:11ff:4f80:3de:e2b2:5c1d] (unknown [IPv6:2804:431:e7cc:11ff:4f80:3de:e2b2:5c1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: koike) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id F054329600A; Mon, 30 Mar 2020 20:20:47 +0100 (BST) Subject: Re: [PATCH 4/4] media: staging: rkisp1: cap: remove unsupported formats To: Dafna Hirschfeld , linux-media@vger.kernel.org, ezequiel@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org, mchehab@kernel.org, laurent.pinchart@ideasonboard.com References: <20200326201610.31762-1-dafna.hirschfeld@collabora.com> <20200326201610.31762-5-dafna.hirschfeld@collabora.com> From: Helen Koike Message-ID: <83fc8d9c-16a0-a381-f5b8-5da642d79f5c@collabora.com> Date: Mon, 30 Mar 2020 16:20:44 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200326201610.31762-5-dafna.hirschfeld@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 3/26/20 5:16 PM, Dafna Hirschfeld wrote: > For Ycbcr packed formats only YUYV can be supported by > the driver. This patch removes the other formats. > > Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike > --- > drivers/staging/media/rkisp1/rkisp1-capture.c | 21 ------------------- > 1 file changed, 21 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c > index 2d274e8f565b..076335193f40 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-capture.c > +++ b/drivers/staging/media/rkisp1/rkisp1-capture.c > @@ -98,15 +98,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_mp_fmts[] = { > .fmt_type = RKISP1_FMT_YUV, > .uv_swap = 0, > .write_format = RKISP1_MI_CTRL_MP_WRITE_YUVINT, > - }, { > - .fourcc = V4L2_PIX_FMT_YVYU, > - .fmt_type = RKISP1_FMT_YUV, > - .uv_swap = 1, > - .write_format = RKISP1_MI_CTRL_MP_WRITE_YUVINT, > - }, { > - .fourcc = V4L2_PIX_FMT_VYUY, > - .fmt_type = RKISP1_FMT_YUV, > - .write_format = RKISP1_MI_CTRL_MP_WRITE_YUVINT, > }, { > .fourcc = V4L2_PIX_FMT_YUV422P, > .fmt_type = RKISP1_FMT_YUV, > @@ -234,18 +225,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = { > .uv_swap = 0, > .write_format = RKISP1_MI_CTRL_SP_WRITE_INT, > .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV422, > - }, { > - .fourcc = V4L2_PIX_FMT_YVYU, > - .fmt_type = RKISP1_FMT_YUV, > - .uv_swap = 1, > - .write_format = RKISP1_MI_CTRL_SP_WRITE_INT, > - .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV422, > - }, { > - .fourcc = V4L2_PIX_FMT_VYUY, > - .fmt_type = RKISP1_FMT_YUV, > - .uv_swap = 1, > - .write_format = RKISP1_MI_CTRL_SP_WRITE_INT, > - .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV422, > }, { > .fourcc = V4L2_PIX_FMT_YUV422P, > .fmt_type = RKISP1_FMT_YUV, >