From: Neil Armstrong <narmstrong@baylibre.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dariusz Marcinkiewicz <darekm@google.com>,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, Sean Paul <seanpaul@chromium.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v7 8/9] drm: dw-hdmi: use cec_notifier_conn_(un)register
Date: Mon, 19 Aug 2019 16:47:41 +0200 [thread overview]
Message-ID: <8680ee8a-ff7f-de3c-a185-ff3fb3a93b2b@baylibre.com> (raw)
In-Reply-To: <389b558f-06ec-8ec0-07ab-256dff3d4cb0@xs4all.nl>
On 19/08/2019 16:41, Hans Verkuil wrote:
> On 8/19/19 4:38 PM, Neil Armstrong wrote:
>> Hi Hans,
>>
>> On 19/08/2019 16:05, Hans Verkuil wrote:
>>> On 8/19/19 11:32 AM, Hans Verkuil wrote:
>>>> On 8/14/19 12:45 PM, Dariusz Marcinkiewicz wrote:
>>>>> Use the new cec_notifier_conn_(un)register() functions to
>>>>> (un)register the notifier for the HDMI connector, and fill in
>>>>> the cec_connector_info.
>>>>>
>>>>> Changes since v6:
>>>>> - move cec_notifier_conn_unregister to a bridge detach
>>>>> function,
>>>>> - add a mutex protecting a CEC notifier.
>>>>> Changes since v4:
>>>>> - typo fix
>>>>> Changes since v2:
>>>>> - removed unnecessary NULL check before a call to
>>>>> cec_notifier_conn_unregister,
>>>>> - use cec_notifier_phys_addr_invalidate to invalidate physical
>>>>> address.
>>>>> Changes since v1:
>>>>> Add memory barrier to make sure that the notifier
>>>>> becomes visible to the irq thread once it is fully
>>>>> constructed.
>>>>>
>>>>> Signed-off-by: Dariusz Marcinkiewicz <darekm@google.com>
>>>>
>>>> Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>>>
>>> Tested-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>>
>> Did you test it on an Amlogic platform ? If yes, I don't have to !
>
> Yes, tested on my khadas VIM2 (modified a bit to fix the issue where
> the CEC physical address wasn't invalidated correctly as discussed here
> earlier).
Good, thanks.
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Regards,
>
> Hans
>
>>
>> Neil
>>
>>>
>>> Regards,
>>>
>>> Hans
>>>
>>>>
>>>> Regards,
>>>>
>>>> Hans
>>>>
>>>>> ---
>>>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 45 +++++++++++++++--------
>>>>> 1 file changed, 30 insertions(+), 15 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>>>>> index 83b94b66e464e..55162c9092f71 100644
>>>>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>>>>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>>>>> @@ -190,6 +190,7 @@ struct dw_hdmi {
>>>>> void (*enable_audio)(struct dw_hdmi *hdmi);
>>>>> void (*disable_audio)(struct dw_hdmi *hdmi);
>>>>>
>>>>> + struct mutex cec_notifier_mutex;
>>>>> struct cec_notifier *cec_notifier;
>>>>> };
>>>>>
>>>>> @@ -2194,6 +2195,8 @@ static int dw_hdmi_bridge_attach(struct drm_bridge *bridge)
>>>>> struct dw_hdmi *hdmi = bridge->driver_private;
>>>>> struct drm_encoder *encoder = bridge->encoder;
>>>>> struct drm_connector *connector = &hdmi->connector;
>>>>> + struct cec_connector_info conn_info;
>>>>> + struct cec_notifier *notifier;
>>>>>
>>>>> connector->interlace_allowed = 1;
>>>>> connector->polled = DRM_CONNECTOR_POLL_HPD;
>>>>> @@ -2207,9 +2210,29 @@ static int dw_hdmi_bridge_attach(struct drm_bridge *bridge)
>>>>>
>>>>> drm_connector_attach_encoder(connector, encoder);
>>>>>
>>>>> + cec_fill_conn_info_from_drm(&conn_info, connector);
>>>>> +
>>>>> + notifier = cec_notifier_conn_register(hdmi->dev, NULL, &conn_info);
>>>>> + if (!notifier)
>>>>> + return -ENOMEM;
>>>>> +
>>>>> + mutex_lock(&hdmi->cec_notifier_mutex);
>>>>> + hdmi->cec_notifier = notifier;
>>>>> + mutex_unlock(&hdmi->cec_notifier_mutex);
>>>>> +
>>>>> return 0;
>>>>> }
>>>>>
>>>>> +static void dw_hdmi_bridge_detach(struct drm_bridge *bridge)
>>>>> +{
>>>>> + struct dw_hdmi *hdmi = bridge->driver_private;
>>>>> +
>>>>> + mutex_lock(&hdmi->cec_notifier_mutex);
>>>>> + cec_notifier_conn_unregister(hdmi->cec_notifier);
>>>>> + hdmi->cec_notifier = NULL;
>>>>> + mutex_unlock(&hdmi->cec_notifier_mutex);
>>>>> +}
>>>>> +
>>>>> static enum drm_mode_status
>>>>> dw_hdmi_bridge_mode_valid(struct drm_bridge *bridge,
>>>>> const struct drm_display_mode *mode)
>>>>> @@ -2266,6 +2289,7 @@ static void dw_hdmi_bridge_enable(struct drm_bridge *bridge)
>>>>>
>>>>> static const struct drm_bridge_funcs dw_hdmi_bridge_funcs = {
>>>>> .attach = dw_hdmi_bridge_attach,
>>>>> + .detach = dw_hdmi_bridge_detach,
>>>>> .enable = dw_hdmi_bridge_enable,
>>>>> .disable = dw_hdmi_bridge_disable,
>>>>> .mode_set = dw_hdmi_bridge_mode_set,
>>>>> @@ -2373,9 +2397,11 @@ static irqreturn_t dw_hdmi_irq(int irq, void *dev_id)
>>>>> phy_stat & HDMI_PHY_HPD,
>>>>> phy_stat & HDMI_PHY_RX_SENSE);
>>>>>
>>>>> - if ((phy_stat & (HDMI_PHY_RX_SENSE | HDMI_PHY_HPD)) == 0)
>>>>> - cec_notifier_set_phys_addr(hdmi->cec_notifier,
>>>>> - CEC_PHYS_ADDR_INVALID);
>>>>> + if ((phy_stat & (HDMI_PHY_RX_SENSE | HDMI_PHY_HPD)) == 0) {
>>>>> + mutex_lock(&hdmi->cec_notifier_mutex);
>>>>> + cec_notifier_phys_addr_invalidate(hdmi->cec_notifier);
>>>>> + mutex_unlock(&hdmi->cec_notifier_mutex);
>>>>> + }
>>>>> }
>>>>>
>>>>> if (intr_stat & HDMI_IH_PHY_STAT0_HPD) {
>>>>> @@ -2561,6 +2587,7 @@ __dw_hdmi_probe(struct platform_device *pdev,
>>>>>
>>>>> mutex_init(&hdmi->mutex);
>>>>> mutex_init(&hdmi->audio_mutex);
>>>>> + mutex_init(&hdmi->cec_notifier_mutex);
>>>>> spin_lock_init(&hdmi->audio_lock);
>>>>>
>>>>> ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
>>>>> @@ -2693,12 +2720,6 @@ __dw_hdmi_probe(struct platform_device *pdev,
>>>>> if (ret)
>>>>> goto err_iahb;
>>>>>
>>>>> - hdmi->cec_notifier = cec_notifier_get(dev);
>>>>> - if (!hdmi->cec_notifier) {
>>>>> - ret = -ENOMEM;
>>>>> - goto err_iahb;
>>>>> - }
>>>>> -
>>>>> /*
>>>>> * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator
>>>>> * N and cts values before enabling phy
>>>>> @@ -2796,9 +2817,6 @@ __dw_hdmi_probe(struct platform_device *pdev,
>>>>> hdmi->ddc = NULL;
>>>>> }
>>>>>
>>>>> - if (hdmi->cec_notifier)
>>>>> - cec_notifier_put(hdmi->cec_notifier);
>>>>> -
>>>>> clk_disable_unprepare(hdmi->iahb_clk);
>>>>> if (hdmi->cec_clk)
>>>>> clk_disable_unprepare(hdmi->cec_clk);
>>>>> @@ -2820,9 +2838,6 @@ static void __dw_hdmi_remove(struct dw_hdmi *hdmi)
>>>>> /* Disable all interrupts */
>>>>> hdmi_writeb(hdmi, ~0, HDMI_IH_MUTE_PHY_STAT0);
>>>>>
>>>>> - if (hdmi->cec_notifier)
>>>>> - cec_notifier_put(hdmi->cec_notifier);
>>>>> -
>>>>> clk_disable_unprepare(hdmi->iahb_clk);
>>>>> clk_disable_unprepare(hdmi->isfr_clk);
>>>>> if (hdmi->cec_clk)
>>>>>
>>>>
>>>
>>
>
next prev parent reply other threads:[~2019-08-19 14:47 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 10:44 [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API Dariusz Marcinkiewicz
2019-08-14 10:44 ` [PATCH v7 1/9] drm_dp_cec: add connector info support Dariusz Marcinkiewicz
2019-08-15 18:10 ` Lyude Paul
2019-08-26 9:05 ` Ben Skeggs
2019-08-22 8:08 ` Hans Verkuil
2019-08-26 9:00 ` Hans Verkuil
2019-08-28 15:05 ` Ville Syrjälä
2019-08-14 10:45 ` [PATCH v7 2/9] drm/i915/intel_hdmi: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-08-22 8:03 ` Hans Verkuil
2019-08-26 8:59 ` Hans Verkuil
2019-08-26 12:08 ` Ville Syrjälä
2019-08-14 10:45 ` [PATCH v7 3/9] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register Dariusz Marcinkiewicz
2019-08-19 14:35 ` Neil Armstrong
2019-08-20 7:48 ` Neil Armstrong
2019-08-14 10:45 ` [PATCH v7 4/9] tda9950: " Dariusz Marcinkiewicz
2019-08-14 10:45 ` [PATCH v7 5/9] drm: tda998x: use cec_notifier_conn_(un)register Dariusz Marcinkiewicz
2019-08-19 9:30 ` Hans Verkuil
2019-08-19 11:22 ` [PATCH v7.1 " Dariusz Marcinkiewicz
2019-08-28 7:15 ` [PATCH v7.2 " Dariusz Marcinkiewicz
2019-08-25 13:12 ` [PATCH v7 " Hans Verkuil
2019-08-28 7:18 ` Dariusz Marcinkiewicz
2019-08-14 10:45 ` [PATCH v7 6/9] drm: sti: " Dariusz Marcinkiewicz
2019-08-19 9:34 ` Hans Verkuil
2019-08-22 8:11 ` Hans Verkuil
2019-09-02 13:11 ` Benjamin Gaignard
2019-08-14 10:45 ` [PATCH v7 7/9] drm: tegra: " Dariusz Marcinkiewicz
2019-08-19 9:33 ` Hans Verkuil
2019-08-28 8:09 ` Hans Verkuil
2019-08-28 9:38 ` Thierry Reding
2019-08-28 10:06 ` Hans Verkuil
2019-08-28 11:54 ` Thierry Reding
2019-10-04 8:48 ` Hans Verkuil
2019-10-14 7:51 ` Hans Verkuil
2019-08-28 9:36 ` Thierry Reding
2019-10-14 12:17 ` Thierry Reding
2019-08-14 10:45 ` [PATCH v7 8/9] drm: dw-hdmi: " Dariusz Marcinkiewicz
2019-08-19 9:32 ` Hans Verkuil
2019-08-19 14:05 ` Hans Verkuil
2019-08-19 14:38 ` Neil Armstrong
2019-08-19 14:41 ` Hans Verkuil
2019-08-19 14:47 ` Neil Armstrong [this message]
2019-08-20 7:48 ` Neil Armstrong
2019-08-14 10:45 ` [PATCH v7 9/9] drm: exynos: exynos_hdmi: " Dariusz Marcinkiewicz
2019-08-19 9:32 ` Hans Verkuil
2019-08-28 8:39 ` Sylwester Nawrocki
2019-08-28 12:34 ` [PATCH v7.1 " Dariusz Marcinkiewicz
2019-08-28 12:38 ` [PATCH v7 " Dariusz Marcinkiewicz
2019-08-19 9:38 ` [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API Hans Verkuil
2019-08-19 11:28 ` Dariusz Marcinkiewicz
2019-08-19 12:00 ` Hans Verkuil
2019-08-19 14:48 ` Neil Armstrong
2019-08-19 14:55 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8680ee8a-ff7f-de3c-a185-ff3fb3a93b2b@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=darekm@google.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).