From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90811C43603 for ; Fri, 13 Dec 2019 10:41:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CC48206B7 for ; Fri, 13 Dec 2019 10:41:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbfLMKlj (ORCPT ); Fri, 13 Dec 2019 05:41:39 -0500 Received: from mga06.intel.com ([134.134.136.31]:44851 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbfLMKlj (ORCPT ); Fri, 13 Dec 2019 05:41:39 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2019 02:41:39 -0800 X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="204291289" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2019 02:41:36 -0800 From: Jani Nikula To: Hans Verkuil , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, Andy Walls , linux-media@vger.kernel.org, Daniel Vetter , Sakari Ailus Subject: Re: [PATCH v3 10/12] media: constify fb ops across all drivers In-Reply-To: <966b9db7-b6c2-d3a2-0842-574186418860@xs4all.nl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <71794337f8611271f2c1fdb3882119a58e743a87.1575390741.git.jani.nikula@intel.com> <966b9db7-b6c2-d3a2-0842-574186418860@xs4all.nl> Date: Fri, 13 Dec 2019 12:41:33 +0200 Message-ID: <87a77w33tu.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, 12 Dec 2019, Hans Verkuil wrote: > On 12/3/19 5:38 PM, Jani Nikula wrote: >> Now that the fbops member of struct fb_info is const, we can start >> making the ops const as well. >> >> Remove the redundant fbops assignments while at it. >> >> v2: >> - actually add const in vivid >> - fix typo (Christophe de Dinechin) >> >> Cc: Hans Verkuil >> Cc: Andy Walls >> Cc: linux-media@vger.kernel.org >> Cc: ivtv-devel@ivtvdriver.org >> Reviewed-by: Daniel Vetter >> Signed-off-by: Jani Nikula > > Acked-by: Hans Verkuil Pushed to drm-misc-next, thanks for the reviews and acks. BR, Jani. > > Thanks! > > Hans > >> --- >> drivers/media/pci/ivtv/ivtvfb.c | 3 +-- >> drivers/media/platform/vivid/vivid-osd.c | 3 +-- >> 2 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c >> index 95a56cce9b65..f2922b554b09 100644 >> --- a/drivers/media/pci/ivtv/ivtvfb.c >> +++ b/drivers/media/pci/ivtv/ivtvfb.c >> @@ -925,7 +925,7 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info) >> return 0; >> } >> >> -static struct fb_ops ivtvfb_ops = { >> +static const struct fb_ops ivtvfb_ops = { >> .owner = THIS_MODULE, >> .fb_write = ivtvfb_write, >> .fb_check_var = ivtvfb_check_var, >> @@ -1049,7 +1049,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv) >> >> oi->ivtvfb_info.node = -1; >> oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT; >> - oi->ivtvfb_info.fbops = &ivtvfb_ops; >> oi->ivtvfb_info.par = itv; >> oi->ivtvfb_info.var = oi->ivtvfb_defined; >> oi->ivtvfb_info.fix = oi->ivtvfb_fix; >> diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c >> index f2e789bdf4a6..fbaec8acc161 100644 >> --- a/drivers/media/platform/vivid/vivid-osd.c >> +++ b/drivers/media/platform/vivid/vivid-osd.c >> @@ -244,7 +244,7 @@ static int vivid_fb_blank(int blank_mode, struct fb_info *info) >> return 0; >> } >> >> -static struct fb_ops vivid_fb_ops = { >> +static const struct fb_ops vivid_fb_ops = { >> .owner = THIS_MODULE, >> .fb_check_var = vivid_fb_check_var, >> .fb_set_par = vivid_fb_set_par, >> @@ -311,7 +311,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev) >> >> dev->fb_info.node = -1; >> dev->fb_info.flags = FBINFO_FLAG_DEFAULT; >> - dev->fb_info.fbops = &vivid_fb_ops; >> dev->fb_info.par = dev; >> dev->fb_info.var = dev->fb_defined; >> dev->fb_info.fix = dev->fb_fix; >> > -- Jani Nikula, Intel Open Source Graphics Center