From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E54C282CB for ; Wed, 6 Feb 2019 00:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 746AD217F9 for ; Wed, 6 Feb 2019 00:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728103AbfBFAuy (ORCPT ); Tue, 5 Feb 2019 19:50:54 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:42588 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726062AbfBFAuy (ORCPT ); Tue, 5 Feb 2019 19:50:54 -0500 Date: 06 Feb 2019 09:50:51 +0900 X-IronPort-AV: E=Sophos;i="5.58,337,1544454000"; d="scan'208";a="6929975" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 06 Feb 2019 09:50:51 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id B3519401BA2A; Wed, 6 Feb 2019 09:50:51 +0900 (JST) Message-ID: <87lg2teon7.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Sakari Ailus Cc: Yong Deng , Mauro Carvalho Chehab , Maxime Ripard , Chen-Yu Tsai , , , , Niklas =?ISO-8859-1?Q?S=F6derlund?= Subject: Re: compile error at sun6i_video In-Reply-To: <20190205095216.f2fg5vjvqqhgs6as@valkosipuli.retiisi.org.uk> References: <878syukax3.wl-kuninori.morimoto.gx@renesas.com> <20190205095216.f2fg5vjvqqhgs6as@valkosipuli.retiisi.org.uk> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Sakari Cc Niklas Thank you for your feedback > > /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c: In function 'sun6i_video_start_streaming': > > /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:141:29: error: passing argument 1 of 'media_pipeline_start' from incompatible pointer type [-Werror=incompatible-pointer-types] > > ret = media_pipeline_start(&video->vdev.entity, &video->vdev.pipe); > > ^~~~~~~~~~~~~~~~~~~ (snip) > Do you have the patches Niklas's v4l2/mux (or my vc) branch in your tree? > They change a few things on the way and drivers need to be converted. > Drivers that have been added since the patches were written do need to be > converted as well, and I suppose the sun6i_video driver is one of them. I could find your branch at LinuxTV, and merged vc branch, but unfortunately it can't solve compile issue. I could understand its background. It is OK for me if it will be solved on the next version. I will skip it so far. Thank you for your help Best regards --- Kuninori Morimoto