From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 802373F8FB; Fri, 22 Mar 2024 11:46:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711108019; cv=none; b=czOvuBv11qyleDfdM+7RY+np4UrXZAgkFNv+kFLyViwH3hfLOBQg6cb0v5eKNTiSHZgZqWxte88ykt+XWyPXzNsUd1GccguqNh8V+DYh3a4RIjIt6Lmb4VqNztvcvSeoDhStUDb+xum5UWh6jy4fOQTpTTwwmDmLUjyr1cH/VTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711108019; c=relaxed/simple; bh=medsa2dMRB93xUxNAamarustBHMc8szL/8blQzMu2XM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=KqCCO0sONd6XkcXvLH2sMiuKd4TvPDsRZELtkg+hvap4Nfjs6j1+xKvZHIDg33A4h6Ul8/PJ+pLBudCgpSn1If4Eo8ZPrj1Net99uS+5amwsNELeg2/ofwAfyhVwSm5bZ1BAIDxZnOXFG6Bm2lBkHwm5R+VJsZ6D4W/nVjRolpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=G5vMBiA4; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="G5vMBiA4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711108017; x=1742644017; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=medsa2dMRB93xUxNAamarustBHMc8szL/8blQzMu2XM=; b=G5vMBiA42yhiWIE8tgewMbxzU3aTTmwRMJzer+oJOLOSCZqosL5iesRU Kx3j8Uvhg3YP76EQMRljkul93J0S2/6g+4z7edJ64IjqZ7C4V+8QlZE7r 58o0qHecwpaaVVk2Ryuqe9vnmT9mK3eLu0l8y4xRR5bPHqt9U9VcdlJyj j1YyDeUu3PR9fho/iFkJhSkJi52GKx2URACf9lRbokDTIWG+wTtoWYfgi aBTgiQk45PdrkRvGdSup84hUg+NL6RWaAT6XfBxQzdFV2/aiHGj4sRvWT 78Htgfsbh/dPnxVMCw7CCDdVLqjQ3ce+12VMvTDtE2vOz3UgzUzAaPSAa w==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="23604100" X-IronPort-AV: E=Sophos;i="6.07,145,1708416000"; d="scan'208";a="23604100" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2024 04:46:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,145,1708416000"; d="scan'208";a="19349726" Received: from ghoshsu1-mobl.ger.corp.intel.com (HELO localhost) ([10.252.55.6]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2024 04:46:48 -0700 From: Jani Nikula To: Maxime Ripard Cc: Sui Jingfeng , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , Sebastian Wick , Ville =?utf-8?B?U3lyasOkbMOk?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation In-Reply-To: <20240322-petite-fabulous-bustard-b168ec@houat> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240321-kms-hdmi-connector-state-v10-20-e6c178361898@kernel.org> <07125064-2a78-4515-bb48-655f2aec140f@linux.dev> <87sf0iliyh.fsf@intel.com> <20240322-petite-fabulous-bustard-b168ec@houat> Date: Fri, 22 Mar 2024 13:46:42 +0200 Message-ID: <87plvmjxp9.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, 22 Mar 2024, Maxime Ripard wrote: > On Fri, Mar 22, 2024 at 11:22:14AM +0200, Jani Nikula wrote: >> On Fri, 22 Mar 2024, Sui Jingfeng wrote: >> > Hi, >> > >> > >> > On 2024/3/21 23:29, Maxime Ripard wrote: >> >> Infoframes in KMS is usually handled by a bunch of low-level helpers >> >> that require quite some boilerplate for drivers. This leads to >> >> discrepancies with how drivers generate them, and which are actually >> >> sent. >> >> >> >> Now that we have everything needed to generate them in the HDMI >> >> connector state, we can generate them in our common logic so that >> >> drivers can simply reuse what we precomputed. >> >> >> >> Signed-off-by: Maxime Ripard >> >> --- >> >> drivers/gpu/drm/Kconfig | 1 + >> >> drivers/gpu/drm/drm_atomic_state_helper.c | 338 +++++++++++++++++++++ >> >> drivers/gpu/drm/drm_connector.c | 14 + >> >> .../gpu/drm/tests/drm_atomic_state_helper_test.c | 1 + >> >> drivers/gpu/drm/tests/drm_connector_test.c | 12 + >> >> include/drm/drm_atomic_state_helper.h | 8 + >> >> include/drm/drm_connector.h | 109 +++++++ >> >> 7 files changed, 483 insertions(+) >> >> >> >> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >> >> index 16029435b750..3d3193c7aa5f 100644 >> >> --- a/drivers/gpu/drm/Kconfig >> >> +++ b/drivers/gpu/drm/Kconfig >> >> @@ -97,10 +97,11 @@ config DRM_KUNIT_TEST >> >> If in doubt, say "N". >> >> >> >> config DRM_KMS_HELPER >> >> tristate >> >> depends on DRM >> >> + select DRM_DISPLAY_HDMI_HELPER >> > >> > Should we select DRM_DISPLAY_HELPER here? Otherwise there will have some compile error >> > emerged with default config. >> >> Can we stop abusing select instead of adding more selects to paper over >> the issues? >> >> Use select only for non-visible symbols (no prompts anywhere) and for >> symbols with no dependencies. > > I don't really have an opinion there, but it looks like all the other > helpers Kconfig symbols are using select everywhere, and I don't really > see how we could turn them into visible symbols with depends on without > breaking a number of defconfig. > > Could you expand a bit what you have in mind here? Just my standard grumbling about the rampant select abuse. Maybe one day someone takes the hint and starts fixing things up. :p See the note under "reverse dependencies" at [1]. BR, Jani. [1] https://docs.kernel.org/kbuild/kconfig-language.html#menu-attributes -- Jani Nikula, Intel