From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B0CF1C68E; Fri, 22 Mar 2024 09:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711099375; cv=none; b=CjHlMblr8ECUXpQrX+uFnUL1u/8mfx47rjwUBlkAcoEDsVXKIdv0fyNIUe+2LlVXtt86+dE7yZlRCrZRviO2m/sF0sgQBdOT1GWZfywn1fyftYVLbCJCG2oyAekt1VNwa8DmGCRnzd60NX3G4ctjXccKXgOaRmdhKHXwsfUX1pU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711099375; c=relaxed/simple; bh=dqz+Usb0C8ozA80PCCBjHib9D3xaFY8srzv1b7krGc4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ZDKJILkExpjDsv/u0xbdloXf3d5XdeISfDF2ee2tk/RtLh3ie2XZZwP/Gs24tAfGzAlJP4kTADffqiSgBhrMYTlpZlDffI6Ue0CFz8VFInJxj0pBQlpXWeWbSeTiE2UCLFLb1LQPyW8j/RKso6HYCFVvJi2CcpsiNI8KcGdfih4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JiY11Ppm; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JiY11Ppm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711099374; x=1742635374; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=dqz+Usb0C8ozA80PCCBjHib9D3xaFY8srzv1b7krGc4=; b=JiY11PpmRXeQtvNPar3Agx67K4bpmkUg8NX8/ucBvUx0fYTw79VN/bx5 SA0hPJFJA5EnzDumliH3VjvNNsQTZiGTk+Wt2PXIpUZAKNeExixYvnpED IiJD9SO/H09V2GjQkDqnFZP77oP+YwhPoJbS59M57JauZpbbxjEi8rYMm xJNELC0mJ9JjSmQw4vVmaNvXd/fcYktz44VT2jm0ZVV1NOTD9b5cGFI3q 3CzfJ9qvYCDcb63sczzVkmSK/N+R3kbj90AR+J1NJ5XJkAjcdTRcHUJu5 /fYauQvJ1uz7vl5MspuHOWAlBV/zoxdzWYDyVYERmYXjAKtvgiCSidHqz g==; X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="31575278" X-IronPort-AV: E=Sophos;i="6.07,145,1708416000"; d="scan'208";a="31575278" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2024 02:22:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,145,1708416000"; d="scan'208";a="19508193" Received: from ghoshsu1-mobl.ger.corp.intel.com (HELO localhost) ([10.252.55.6]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2024 02:22:19 -0700 From: Jani Nikula To: Sui Jingfeng , Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: Hans Verkuil , Sebastian Wick , Ville =?utf-8?B?U3lyasOkbMOk?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation In-Reply-To: <07125064-2a78-4515-bb48-655f2aec140f@linux.dev> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240321-kms-hdmi-connector-state-v10-20-e6c178361898@kernel.org> <07125064-2a78-4515-bb48-655f2aec140f@linux.dev> Date: Fri, 22 Mar 2024 11:22:14 +0200 Message-ID: <87sf0iliyh.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, 22 Mar 2024, Sui Jingfeng wrote: > Hi, > > > On 2024/3/21 23:29, Maxime Ripard wrote: >> Infoframes in KMS is usually handled by a bunch of low-level helpers >> that require quite some boilerplate for drivers. This leads to >> discrepancies with how drivers generate them, and which are actually >> sent. >> >> Now that we have everything needed to generate them in the HDMI >> connector state, we can generate them in our common logic so that >> drivers can simply reuse what we precomputed. >> >> Signed-off-by: Maxime Ripard >> --- >> drivers/gpu/drm/Kconfig | 1 + >> drivers/gpu/drm/drm_atomic_state_helper.c | 338 +++++++++++++++++++++ >> drivers/gpu/drm/drm_connector.c | 14 + >> .../gpu/drm/tests/drm_atomic_state_helper_test.c | 1 + >> drivers/gpu/drm/tests/drm_connector_test.c | 12 + >> include/drm/drm_atomic_state_helper.h | 8 + >> include/drm/drm_connector.h | 109 +++++++ >> 7 files changed, 483 insertions(+) >> >> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >> index 16029435b750..3d3193c7aa5f 100644 >> --- a/drivers/gpu/drm/Kconfig >> +++ b/drivers/gpu/drm/Kconfig >> @@ -97,10 +97,11 @@ config DRM_KUNIT_TEST >> If in doubt, say "N". >> >> config DRM_KMS_HELPER >> tristate >> depends on DRM >> + select DRM_DISPLAY_HDMI_HELPER > > Should we select DRM_DISPLAY_HELPER here? Otherwise there will have some compile error > emerged with default config. Can we stop abusing select instead of adding more selects to paper over the issues? Use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. BR, Jani. > > > : drivers/gpu/drm/drm_atomic_state_helper.o: in function `drm_atomic_helper_connector_hdmi_check': > drm_atomic_state_helper.c:(.text+0x15e4): undefined reference to `drm_hdmi_avi_infoframe_colorimetry' > : drm_atomic_state_helper.c:(.text+0x15f0): undefined reference to `drm_hdmi_avi_infoframe_bars' > : drm_atomic_state_helper.c:(.text+0x1638): undefined reference to `drm_hdmi_infoframe_set_hdr_metadata' > make[2]: *** [scripts/Makefile.vmlinux:37: vmlinux] Error 1 > > make[1]: *** [/home/suijingfeng/UpStream/drm-tip/Makefile:1162: vmlinux] Error 2 > > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:240: __sub-make] Error 2 > >> help >> CRTC helpers for KMS drivers. >> >> config DRM_DEBUG_DP_MST_TOPOLOGY_REFS >> bool "Enable refcount backtrace history in the DP MST helpers" -- Jani Nikula, Intel