From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEF3C43603 for ; Thu, 5 Dec 2019 09:40:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D6472464D for ; Thu, 5 Dec 2019 09:40:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729124AbfLEJk4 (ORCPT ); Thu, 5 Dec 2019 04:40:56 -0500 Received: from mga05.intel.com ([192.55.52.43]:42572 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbfLEJk4 (ORCPT ); Thu, 5 Dec 2019 04:40:56 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 01:40:55 -0800 X-IronPort-AV: E=Sophos;i="5.69,280,1571727600"; d="scan'208";a="205715715" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 01:40:52 -0800 From: Jani Nikula To: Sakari Ailus Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, Hans Verkuil , Andy Walls , linux-media@vger.kernel.org, ivtv-devel@ivtvdriver.org, Daniel Vetter Subject: Re: [PATCH v3 10/12] media: constify fb ops across all drivers In-Reply-To: <20191204113315.GG5282@valkosipuli.retiisi.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <71794337f8611271f2c1fdb3882119a58e743a87.1575390741.git.jani.nikula@intel.com> <20191204113315.GG5282@valkosipuli.retiisi.org.uk> Date: Thu, 05 Dec 2019 11:40:49 +0200 Message-ID: <87wobbglem.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, 04 Dec 2019, Sakari Ailus wrote: > On Tue, Dec 03, 2019 at 06:38:52PM +0200, Jani Nikula wrote: >> Now that the fbops member of struct fb_info is const, we can start >> making the ops const as well. >> >> Remove the redundant fbops assignments while at it. >> >> v2: >> - actually add const in vivid >> - fix typo (Christophe de Dinechin) >> >> Cc: Hans Verkuil >> Cc: Andy Walls >> Cc: linux-media@vger.kernel.org >> Cc: ivtv-devel@ivtvdriver.org >> Reviewed-by: Daniel Vetter >> Signed-off-by: Jani Nikula > > Reviewed-by: Sakari Ailus Thanks for the review! Andy, Hans, may I have your ack to merge this through drm-misc please? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center