linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	hverkuil@xs4all.nl
Cc: slongerbeam@gmail.com, linux-imx@nxp.com,
	linux-media@vger.kernel.org, kernel@pengutronix.de,
	shawnguo@kernel.org, mchehab@kernel.org
Subject: Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out
Date: Tue, 30 Jul 2019 05:14:24 -0300	[thread overview]
Message-ID: <8b859fd7758c3f95b45b5b70909be0d2ae2e4f34.camel@collabora.com> (raw)
In-Reply-To: <1561963729.3753.5.camel@pengutronix.de>

Hey Hans,

On Mon, 2019-07-01 at 08:48 +0200, Philipp Zabel wrote:
> On Thu, 2019-06-27 at 19:29 -0300, Fabio Estevam wrote:
> > From: Ezequiel Garcia <ezequiel@collabora.com>
> > 
> > Not all sensors will be able to guarantee a proper initial state.
> > This may be either because the driver is not properly written,
> > or (probably unlikely) because the hardware won't support it.
> > 
> > While the right solution in the former case is to fix the sensor
> > driver, the real world not always allows right solutions, due to lack
> > of available documentation and support on these sensors.
> > 
> > Let's relax this requirement, and allow the driver to support stream start,
> > even if the sensor initial sequence wasn't the expected.
> > 
> > Also improve the warning message to better explain the problem and provide
> > a hint that the sensor driver needs to be fixed.
> > 
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> 
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> 

This seems ready to pick and it has Philipp's and Steve's RB.

Thanks,
Eze


  reply	other threads:[~2019-07-30  8:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 22:29 [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out Fabio Estevam
2019-06-28  1:28 ` Steve Longerbeam
2019-07-01  6:48 ` Philipp Zabel
2019-07-30  8:14   ` Ezequiel Garcia [this message]
2019-08-07 12:06     ` Sakari Ailus
2019-08-07 13:59       ` Ezequiel Garcia
2019-08-08  8:26         ` Sakari Ailus
2019-08-08  8:53           ` Philipp Zabel
2019-08-08 10:18             ` Sakari Ailus
2019-08-08 18:02             ` Steve Longerbeam
2019-08-10 19:27               ` Steve Longerbeam
2019-08-13  8:28               ` Sakari Ailus
2019-08-13 23:27                 ` Steve Longerbeam
2019-08-14  7:16                   ` Sakari Ailus
2019-08-15 20:25                     ` Steve Longerbeam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b859fd7758c3f95b45b5b70909be0d2ae2e4f34.camel@collabora.com \
    --to=ezequiel@collabora.com \
    --cc=festevam@gmail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).