From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F8DC433DB for ; Tue, 12 Jan 2021 11:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 576C323109 for ; Tue, 12 Jan 2021 11:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730870AbhALL6s (ORCPT ); Tue, 12 Jan 2021 06:58:48 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:44040 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727952AbhALL6s (ORCPT ); Tue, 12 Jan 2021 06:58:48 -0500 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 64EB83E; Tue, 12 Jan 2021 12:58:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1610452686; bh=mLDeM5JK2U+Cqu5JzAss8UQMs71epKmUAuHs1GCDLWw=; h=Subject:To:Cc:References:From:Reply-To:Date:In-Reply-To:From; b=JvAs+447Uw6Tc4r331n+6ZF/ZPPWCexdrDyKk6QW8aY3zqVYvGrHKmophDtmm141U YmQSgbHozr8L5Ao/tZmEc7TUy8plKrVSxeUZ/VILXChAtmDUvObmYTcpsKQLUZpsvz 3uEJ2wmLxIYMp/hFRGCULtg2uXgPtQuPl++ZNuWo= Subject: Re: [PATCH 1/9] media: ipu3-cio2: Do not zero reserved fields To: Ricardo Ribalda , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sakari Ailus References: <20210111145445.28854-1-ribalda@chromium.org> From: Kieran Bingham Reply-To: kieran.bingham+renesas@ideasonboard.com Organization: Ideas on Board Message-ID: <8d2ed1cd-ce4d-258c-942e-b0ba1677ea1a@ideasonboard.com> Date: Tue, 12 Jan 2021 11:58:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210111145445.28854-1-ribalda@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Ricardo, On 11/01/2021 14:54, Ricardo Ribalda wrote: > Core code already clears reserved fields of struct > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero > v4l2_plane_pix_format reserved fields"). > > Cc: Sakari Ailus > Signed-off-by: Ricardo Ribalda Reviewed-by: Kieran Bingham > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > index 36e354ecf71e..c5376de8cb8a 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > @@ -1094,12 +1094,9 @@ static int cio2_v4l2_try_fmt(struct file *file, void *fh, struct v4l2_format *f) > mpix->pixelformat = fmt->fourcc; > mpix->colorspace = V4L2_COLORSPACE_RAW; > mpix->field = V4L2_FIELD_NONE; > - memset(mpix->reserved, 0, sizeof(mpix->reserved)); > mpix->plane_fmt[0].bytesperline = cio2_bytesperline(mpix->width); > mpix->plane_fmt[0].sizeimage = mpix->plane_fmt[0].bytesperline * > mpix->height; > - memset(mpix->plane_fmt[0].reserved, 0, > - sizeof(mpix->plane_fmt[0].reserved)); > > /* use default */ > mpix->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; >