From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3094C6FD1C for ; Fri, 24 Mar 2023 10:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231678AbjCXKSt (ORCPT ); Fri, 24 Mar 2023 06:18:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231651AbjCXKSs (ORCPT ); Fri, 24 Mar 2023 06:18:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27C5EA5D5 for ; Fri, 24 Mar 2023 03:18:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 99CF8629F8 for ; Fri, 24 Mar 2023 10:18:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9279C433EF for ; Fri, 24 Mar 2023 10:18:43 +0000 (UTC) Message-ID: <8d39dc5d-8831-c12d-7126-3934d52d1108@xs4all.nl> Date: Fri, 24 Mar 2023 11:18:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Hans Verkuil Subject: Re: [PATCHv2 00/19] saa7146: convert to vb2 To: linux-media@vger.kernel.org References: <20230323155343.2399473-1-hverkuil-cisco@xs4all.nl> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 23/03/2023 18:23, Hans Verkuil wrote: > On 23/03/2023 16:53, Hans Verkuil wrote: >> This series converts the saa7146 driver to vb2. >> >> Tested with my mxb board, Hexium Orion and Gemini boards and av7110 boards >> (DVB-C and DVB-T). >> >> I don't have a av7110 card with analog video capture, so that remains >> untested. >> >> Note that the first patch fixes a regression that the removal of overlay >> support introduced. >> >> Regards, >> >> Hans > > Just ignore this series, something is still wrong. No, it's fine after all. I noticed that the Hexium Gemini card swaps the U and V components, but I discovered that it was like that for a long time, even in kernel 5.10. I can make it work by changing a h_offset value, but I will have to do a bit more testing later. It's independent of this work, so I leave this series as-is. Regards, Hans > > Regards, > > Hans > >> >> Hans Verkuil (19): >> media: common: saa7146: disable clipping >> common/saa7146: fix VFL direction for vbi output >> media: pci: saa7146: hexium_orion: initialize input 0 >> media: saa7146: drop 'dev' and 'resources' from struct saa7146_fh >> media: common: saa7146: drop 'fmt' from struct saa7146_buf >> media: common: saa7146: replace BUG_ON by WARN_ON >> staging: media: av7110: replace BUG_ON by WARN_ON >> media: common: saa7146: fix broken V4L2_PIX_FMT_YUV422P support >> media: common: saa7146: use for_each_sg_dma_page >> media: saa7146: convert to vb2 >> media: common: saa7146: fix compliance problems with field handling >> media: common: saa7146: check minimum video format size >> media: common: saa7146: fall back to V4L2_PIX_FMT_BGR24 >> media: common: saa7146: allow S_STD(G_STD) >> media: mxb: update the tvnorms when changing input >> media: common: saa7146: add support for missing >> .vidioc_try_fmt_vbi_cap >> media: mxb: allow tuner/input/audio ioctls for vbi >> media: pci: saa7146: advertise only those TV standard that are >> supported >> staging: media: av7110: fix VBI output support >> >> drivers/media/common/saa7146/Kconfig | 2 +- >> drivers/media/common/saa7146/saa7146_core.c | 40 +- >> drivers/media/common/saa7146/saa7146_fops.c | 349 +++------- >> drivers/media/common/saa7146/saa7146_hlp.c | 61 +- >> drivers/media/common/saa7146/saa7146_vbi.c | 287 ++++----- >> drivers/media/common/saa7146/saa7146_video.c | 642 ++++++------------- >> drivers/media/pci/saa7146/hexium_gemini.c | 23 +- >> drivers/media/pci/saa7146/hexium_orion.c | 24 +- >> drivers/media/pci/saa7146/mxb.c | 53 +- >> drivers/media/pci/ttpci/budget-av.c | 4 +- >> drivers/staging/media/av7110/av7110.c | 6 +- >> drivers/staging/media/av7110/av7110_hw.c | 3 +- >> drivers/staging/media/av7110/av7110_v4l.c | 116 ++-- >> include/media/drv-intf/saa7146_vv.h | 44 +- >> 14 files changed, 598 insertions(+), 1056 deletions(-) >> >