From: Pavel Skripkin <paskripkin@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: Alaa Emad <alaaemadhossney.ae@gmail.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>,
syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com
Subject: Re: [PATCH] media: sq905.c: fix uninitialized variable
Date: Fri, 26 Mar 2021 10:24:29 +0300 [thread overview]
Message-ID: <913828319c9e0b6281ad32361e0246fc95d2c138.camel@gmail.com> (raw)
In-Reply-To: <CACT4Y+Y8f6-c6zYCN=d0557xEryAzBfS9n2m=vBcdjHSi5gYcw@mail.gmail.com>
Hi!
On Fri, 2021-03-26 at 08:14 +0100, 'Dmitry Vyukov' via syzkaller wrote:
> On Fri, Mar 26, 2021 at 8:11 AM Greg KH <gregkh@linuxfoundation.org>
> wrote:
> >
> > On Thu, Mar 25, 2021 at 11:22:02PM +0200, Alaa Emad wrote:
> > > Reported-by: syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com
> > > Signed-off-by: Alaa Emad <alaaemadhossney.ae@gmail.com>
> > > ---
> >
> > I know I do not take patches with no changelog text, but other
> > maintainers might be more leniant :(
>
> I wonder if it's the right fix or not.
> Initializing variables will, of course, silence the warning, but it's
> not necessarily the right fix. I suspect there is something wrong in
> how ret/act_len are user/checked.
>
There is a problem in usb_bulk_msg() call. It could return before
act_len initialization, so i think, act_len should be intialized with
smth wrong like 0 or -1. BTW, I already send patch for that, but it was
marked as obsoleted.
--
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-03-26 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 21:22 [PATCH] media: sq905.c: fix uninitialized variable Alaa Emad
2021-03-26 7:11 ` Greg KH
2021-03-26 7:14 ` Dmitry Vyukov
2021-03-26 7:24 ` Pavel Skripkin [this message]
2021-03-26 7:40 ` Dmitry Vyukov
2021-03-26 7:53 ` Pavel Skripkin
2021-03-26 8:06 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=913828319c9e0b6281ad32361e0246fc95d2c138.camel@gmail.com \
--to=paskripkin@gmail.com \
--cc=alaaemadhossney.ae@gmail.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).