From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F20C761A6 for ; Wed, 5 Apr 2023 12:45:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238035AbjDEMpK (ORCPT ); Wed, 5 Apr 2023 08:45:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238085AbjDEMpH (ORCPT ); Wed, 5 Apr 2023 08:45:07 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59C9F1BC5; Wed, 5 Apr 2023 05:45:06 -0700 (PDT) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1pk2Vc-0005Va-JN; Wed, 05 Apr 2023 14:45:04 +0200 Message-ID: <92c59571-2df0-026b-ea8e-f693c2ecfd69@leemhuis.info> Date: Wed, 5 Apr 2023 14:45:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/3] venus: firmware: Correct non-pix start and end addresses Content-Language: en-US, de-DE From: "Linux regression tracking #update (Thorsten Leemhuis)" To: Matthias Kaehlcke , Stanimir Varbanov Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Fritz Koenig , Nathan Hebert Reply-To: Linux regressions mailing list , Linux regressions mailing list References: <20221005083730.963322-1-stanimir.varbanov@linaro.org> <20221005083730.963322-3-stanimir.varbanov@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1680698706;98d2f05d; X-HE-SMSGID: 1pk2Vc-0005Va-JN Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org [TLDR: This mail in primarily relevant for Linux kernel regression tracking. See link in footer if these mails annoy you.] On 05.02.23 12:00, Linux kernel regression tracking (#adding) wrote: > On 26.01.23 20:19, Matthias Kaehlcke wrote: > >> On Wed, Oct 05, 2022 at 11:37:29AM +0300, Stanimir Varbanov wrote: >>> The default values for those registers are zero. >>> >>> Signed-off-by: Stanimir Varbanov >>> --- >>> drivers/media/platform/qcom/venus/firmware.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c >>> index 3851cedc3329..71e43611d1cf 100644 >>> --- a/drivers/media/platform/qcom/venus/firmware.c >>> +++ b/drivers/media/platform/qcom/venus/firmware.c >>> @@ -38,8 +38,8 @@ static void venus_reset_cpu(struct venus_core *core) >>> writel(fw_size, wrapper_base + WRAPPER_FW_END_ADDR); >>> writel(0, wrapper_base + WRAPPER_CPA_START_ADDR); >>> writel(fw_size, wrapper_base + WRAPPER_CPA_END_ADDR); >>> - writel(fw_size, wrapper_base + WRAPPER_NONPIX_START_ADDR); >>> - writel(fw_size, wrapper_base + WRAPPER_NONPIX_END_ADDR); >>> + writel(0, wrapper_base + WRAPPER_NONPIX_START_ADDR); >>> + writel(0, wrapper_base + WRAPPER_NONPIX_END_ADDR); >>> >>> if (IS_V6(core)) { >>> /* Bring XTSS out of reset */ >> >> I found that this commit prevents the AOSS from entering sleep mode during >> system suspend at least on sc7180 and sc7280. AOSS not entering sleep mode >> leads to a (apparently significant) increase in S3 power consumption, on >> trogdor and herobrine it prevents the system from staying suspended, because >> the embedded controller detect the condition and wakes the sytem up again. > > Thanks for the report. To be sure the issue doesn't fall through the > cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression > tracking bot: > > #regzbot ^introduced a837e5161cfffbb32 > #regzbot title meida: venus: firmware: AOSS doesn't seel anymore on at > least sc7180 and sc7280 > #regzbot ignore-activity #regzbot fix: f95b8ea79c47c0ad #regzbot ignore-activity Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr That page also explains what to do if mails like this annoy you.