From: linmiaohe <linmiaohe@huawei.com>
To: Jason Gunthorpe <jgg@ziepe.ca>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
"airlied@redhat.com" <airlied@redhat.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"willy@infradead.org" <willy@infradead.org>,
"jhubbard@nvidia.com" <jhubbard@nvidia.com>
Subject: Re: [PATCH 1/6] mm: mmap: fix fput in error path
Date: Sat, 10 Oct 2020 01:48:04 +0000 [thread overview]
Message-ID: <94449b58fbcf474488f144c38d51418f@huawei.com> (raw)
Jason Gunthorpe <jgg@ziepe.ca> wrote:
> On Fri, Oct 09, 2020 at 03:04:20PM -0700, Andrew Morton wrote:
>> On Fri, 9 Oct 2020 17:03:37 +0200 "Christian König" <ckoenig.leichtzumerken@gmail.com> wrote:
>>
>> > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..."
>> > adds a workaround for a bug in mmap_region.
>> >
>> > As the comment states ->mmap() callback can change
>> > vma->vm_file and so we might call fput() on the wrong file.
>> >
>> > Revert the workaround and proper fix this in mmap_region.
>> >
>>
>> Doesn't this patch series address the same thing as
>> https://lkml.kernel.org/r/20200916090733.31427-1-linmiaohe@huawei.com?
>
>Same basic issue, looks like both of these patches should be combined to plug it fully.
>
>Jason
I think so too. Both of these patches fix the fput at possible wrong @file due to ->mmap() callback can change vma->vm_file.
next reply other threads:[~2020-10-10 2:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 1:48 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-09 15:03 [PATCH 1/6] mm: mmap: fix fput in error path Christian König
2020-10-09 15:15 ` Jason Gunthorpe
2020-10-09 22:04 ` Andrew Morton
2020-10-09 22:25 ` Jason Gunthorpe
2020-10-12 8:13 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94449b58fbcf474488f144c38d51418f@huawei.com \
--to=linmiaohe@huawei.com \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sumit.semwal@linaro.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).