From: "Zhi Mao (毛智)" <zhi.mao@mediatek.com>
To: "conor@kernel.org" <conor@kernel.org>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>
Cc: "heiko@sntech.de" <heiko@sntech.de>,
"tomi.valkeinen@ideasonboard.com"
<tomi.valkeinen@ideasonboard.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"yunkec@chromium.org" <yunkec@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dan.scally@ideasonboard.com" <dan.scally@ideasonboard.com>,
"gerald.loacker@wolfvision.net" <gerald.loacker@wolfvision.net>,
"Shengnan Wang (王圣男)" <shengnan.wang@mediatek.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"Yaya Chang (張雅清)" <Yaya.Chang@mediatek.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"jacopo.mondi@ideasonboard.com" <jacopo.mondi@ideasonboard.com>,
"jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"bingbu.cao@intel.com" <bingbu.cao@intel.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"10572168@qq.com" <10572168@qq.com>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"macromorgan@hotmail.com" <macromorgan@hotmail.com>
Subject: Re: [PATCH 1/2] media: dt-bindings: media: i2c: Document GC08A3 bindings
Date: Tue, 9 Jan 2024 09:11:32 +0000 [thread overview]
Message-ID: <96fee4c737300e6b834ae0761c161edb6bf48aec.camel@mediatek.com> (raw)
In-Reply-To: <20231207102505.GI29417@pendragon.ideasonboard.com>
On Thu, 2023-12-07 at 12:25 +0200, Laurent Pinchart wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On Thu, Nov 23, 2023 at 05:31:35PM +0000, Conor Dooley wrote:
> > On Thu, Nov 23, 2023 at 07:51:03PM +0800, Zhi Mao wrote:
> > > Add YAML device tree binding for GC08A3 CMOS image sensor,
> > > and the relevant MAINTAINERS entries.
> > >
> > > Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
> >
> > Please test your bindings.
> >
> > > ---
> > > .../bindings/media/i2c/galaxycore,gc08a3.yaml | 128
> ++++++++++++++++++
> > > .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> > > 2 files changed, 130 insertions(+)
> > > create mode 100644
> Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
> > >
> > > diff --git
> a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
> b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
> > > new file mode 100644
> > > index 000000000000..089ea321da91
> > > --- /dev/null
> > > +++
> b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
> > > @@ -0,0 +1,128 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id:
> http://devicetree.org/schemas/media/i2c/galaxycore,gc08a3.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: GalaxyCore gc08a3 1/4" 8M Pixel MIPI CSI-2 sensor
> > > +
> > > +maintainers:
> > > + - Zhi Mao <zhi.mao@mediatek.com>
> > > +
> > > +description: |-
> >
> > The |- is not needed, you have no formatting to preserve.
> >
> > > + The gc08a3 is a raw image sensor with an MIPI CSI-2 image data
> > > + interface and CCI (I2C compatible) control bus. The output
> format
> > > + is raw Bayer.
> > > +
> > > +properties:
> > > + compatible:
> > > + const: GalaxyCore,gc08a3
> >
> > Please remove the capitals.
> >
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + clocks:
> > > + items:
> > > + - description: Reference to the mclk clock.
> >
> > Pointless, just use maxItems: 1.
> >
> > > +
> > > + assigned-clocks:
> > > + maxItems: 1
> > > +
> > > + assigned-clock-rates:
> > > + maxItems: 1
> > > +
> > > + enable-gpios:
> > > + description: Reference to the GPIO connected to the RESETB
> pin. Active low.
> > > + maxItems: 1
> > > +
>
> If that's the RESETB pin, it should be reset-gpios.
[mtk]: yes, it's reset-pin, fixed in patch:v3.
and some other comments also fixed, please review patch:v3.
https://lore.kernel.org/linux-media/20240109022715.30278-1-zhi.mao@mediatek.com/
>
> > > + vddio-supply:
> > > + description: Definition of the regulator used for the VDDIO
> power supply.
> > > +
> > > + vdda-supply:
> > > + description: Definition of the regulator used for the VDDA
> power supply.
> > > +
> > > + vddd-supply:
> > > + description: Definition of the regulator used for the VDDD
> power supply.
> >
> > These descriptions can all be replaced with "foo-supply: true" IMO.
> >
> > > + port:
> > > + $ref: /schemas/graph.yaml#/$defs/port-base
> > > + unevaluatedProperties: false
> > > +
> > > + properties:
> > > + endpoint:
> > > + $ref: /schemas/media/video-interfaces.yaml#
> > > + unevaluatedProperties: false
> > > +
> > > + properties:
> > > + data-lanes:
> > > + oneOf:
> > > + - items:
> > > + - const: 1
> > > + - const: 2
> > > + - const: 3
> > > + - const: 4
> > > + - items:
> > > + - const: 1
> > > + - const: 2
> > > +
> > > + link-frequencies: true
> > > +
> > > + required:
> > > + - data-lanes
> > > + - link-frequencies
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > + - clocks
> >
> > > + - assigned-clocks
> > > + - assigned-clock-rates
> >
> > Why are these required?
> >
> > > + - vddio-supply
> > > + - vdda-supply
> > > + - vddd-supply
> > > + - port
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > + - |
> > > + #include <dt-bindings/gpio/gpio.h>
> > > +
> > > + i2c {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + sensor0@2 {
> > > + status = "okay";
> > > + compatible = "GalaxyCore,gc08a3";
> > > + reg = <0x31>;
> > > +
> > > + clocks = <&topckgen CLK_TOP_CAMTG>,
> > > + <&topckgen CLK_TOP_UNIVPLL_192M_D8>;
> > > + clock-names = "xvclk", "freq_mux";
> > > + clock-frequency = <24000000>;
> > > +
> > > + assigned-clocks = <&topckgen CLK_TOP_CAMTG>,
> > > + <&topckgen CLK_TOP_UNIVPLL_192M_D8>;
> > > + assigned-clock-parents = <&topckgen
> CLK_TOP_UNIVPLL_192M_D8>;
> > > + assigned-clock-rates = <0>, <24000000>;
> > > +
> > > + enable-gpios = <&pio 19 GPIO_ACTIVE_HIGH>;
> > > +
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&camera_pins_cam0>;
> > > +
> > > + avdd-supply = <&mt6359_vfe28_ldo_reg>;
> > > +
> > > + port {
> > > + sensor0_out_2: endpoint {
> > > + data-lanes = <1 2 3 4>;
> > > + link-frequencies = /bits/ 64 <336000000
> 207000000>;
> > > + remote-endpoint = <&seninf_csi_port_0_in_2>;
> > > + };
> > > + };
> > > + };
> > > +
> > > + };
> > > +
> > > +...
> > > diff --git a/Documentation/devicetree/bindings/vendor-
> prefixes.yaml b/Documentation/devicetree/bindings/vendor-
> prefixes.yaml
> > > index 309b94c328c8..a0bbec0bfee2 100644
> > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > > @@ -502,6 +502,8 @@ patternProperties:
> > > description: Fujitsu Ltd.
> > > "^fxtec,.*":
> > > description: FX Technology Ltd.
> > > + "^GalaxyCore,.*":
> > > + description: GalaxyCore Inc.
> > > "^gardena,.*":
> > > description: GARDENA GmbH
> > > "^gateway,.*":
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2024-01-09 9:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 11:51 [PATCH 0/2] media: i2c: Add support for GC08A3 sensor Zhi Mao
2023-11-23 11:51 ` [PATCH 1/2] media: dt-bindings: media: i2c: Document GC08A3 bindings Zhi Mao
2023-11-23 12:16 ` Rob Herring
2023-11-23 17:31 ` Conor Dooley
2023-12-07 10:25 ` Laurent Pinchart
2024-01-09 9:11 ` Zhi Mao (毛智) [this message]
2024-01-09 9:18 ` Laurent Pinchart
2023-11-23 11:51 ` [PATCH 2/2] media: i2c: Add GC08A3 image sensor driver Zhi Mao
2023-11-24 7:56 ` kernel test robot
2023-11-24 8:09 ` Krzysztof Kozlowski
2023-12-07 11:06 ` Laurent Pinchart
2024-01-09 9:25 ` Zhi Mao (毛智)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96fee4c737300e6b834ae0761c161edb6bf48aec.camel@mediatek.com \
--to=zhi.mao@mediatek.com \
--cc=10572168@qq.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Yaya.Chang@mediatek.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bingbu.cao@intel.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yunkec@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).