linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: "yong.zhi@intel.com" <yong.zhi@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"Christian.Koenig@amd.com" <Christian.Koenig@amd.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"jgg@mellanox.com" <jgg@mellanox.com>, "hch@lst.de" <hch@lst.de>,
	"tian.shu.qiu@intel.com" <tian.shu.qiu@intel.com>,
	"bingbu.cao@intel.com" <bingbu.cao@intel.com>,
	"daniel@fooishbar.org" <daniel@fooishbar.org>,
	"shiraz.saleem@intel.com" <shiraz.saleem@intel.com>,
	"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2] lib/scatterlist: Provide a DMA page iterator
Date: Fri, 8 Feb 2019 07:44:36 +0000	[thread overview]
Message-ID: <97c4d30915593e8a81cb6cd5f44dc09c9fc1343c.camel@vmware.com> (raw)
In-Reply-To: <20190207222647.GA30974@ziepe.ca>

On Thu, 2019-02-07 at 22:26 +0000, Jason Gunthorpe wrote:
> Commit 2db76d7c3c6d ("lib/scatterlist: sg_page_iter: support sg lists
> w/o
> backing pages") introduced the sg_page_iter_dma_address() function
> without
> providing a way to use it in the general case. If the sg_dma_len() is
> not
> equal to the sg length callers cannot safely use the
> for_each_sg_page/sg_page_iter_dma_address combination.
> 
> Resolve this API mistake by providing a DMA specific iterator,
> for_each_sg_dma_page(), that uses the right length so
> sg_page_iter_dma_address() works as expected with all sglists.
> 
> A new iterator type is introduced to provide compile-time safety
> against
> wrongly mixing accessors and iterators.
> 
> Acked-by: Christoph Hellwig <hch@lst.de> (for scatterlist)
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> 

For the vmwgfx part, 
Acked-by: Thomas Hellstrom <thellstrom@vmware.com>

I'll take a deeper look to provide a vmwgfx fix as a follow up.

Thanks,
Thomas


  parent reply	other threads:[~2019-02-08  7:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 22:26 [PATCH v2] lib/scatterlist: Provide a DMA page iterator Jason Gunthorpe
2019-02-08  4:31 ` Miguel Ojeda
2019-02-08  7:44 ` Thomas Hellstrom [this message]
2019-02-08 16:38 ` Jason Gunthorpe
2019-02-11 22:26 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97c4d30915593e8a81cb6cd5f44dc09c9fc1343c.camel@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=Christian.Koenig@amd.com \
    --cc=bingbu.cao@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@fooishbar.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@lst.de \
    --cc=jgg@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shiraz.saleem@intel.com \
    --cc=tian.shu.qiu@intel.com \
    --cc=yong.zhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).