From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 994DAC433E2 for ; Fri, 26 Mar 2021 15:29:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 688E361A2B for ; Fri, 26 Mar 2021 15:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230259AbhCZP2r (ORCPT ); Fri, 26 Mar 2021 11:28:47 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:38088 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230115AbhCZP2i (ORCPT ); Fri, 26 Mar 2021 11:28:38 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 80C151F470A1 Message-ID: <986ee841d0c512a6f0ffe9dfa2e0803980b02aa0.camel@collabora.com> Subject: Re: [PATCH v6 13/13] arm64: dts: imx8mq: Add node to G2 hardware From: Ezequiel Garcia To: Benjamin Gaignard , Philipp Zabel Cc: mchehab@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, lee.jones@linaro.org, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@siol.net, hverkuil-cisco@xs4all.nl, emil.l.velikov@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, kernel@collabora.com Date: Fri, 26 Mar 2021 12:28:25 -0300 In-Reply-To: <4df3c9e4-0983-6007-f3b3-323882f903cf@collabora.com> References: <20210318082046.51546-1-benjamin.gaignard@collabora.com> <20210318082046.51546-14-benjamin.gaignard@collabora.com> <20210326142440.GD8441@pengutronix.de> <4df3c9e4-0983-6007-f3b3-323882f903cf@collabora.com> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, 2021-03-26 at 15:33 +0100, Benjamin Gaignard wrote: > > Le 26/03/2021 à 15:24, Philipp Zabel a écrit : > > On Thu, Mar 18, 2021 at 09:20:46AM +0100, Benjamin Gaignard wrote: > > > Split VPU node in two: one for G1 and one for G2 since they are > > > different hardware blocks. > > > Add syscon for hardware control block. > > > Remove reg-names property that is useless. > > > Each VPU node only need one interrupt. > > > > > > Signed-off-by: Benjamin Gaignard > > > --- > > > version 5: > > >   - use syscon instead of VPU reset > > > > > >   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 43 ++++++++++++++++++----- > > >   1 file changed, 34 insertions(+), 9 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > index 17c449e12c2e..b537d153ebbd 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > @@ -1329,15 +1329,16 @@ usb3_phy1: usb-phy@382f0040 { > > >                         status = "disabled"; > > >                 }; > > >   > > > -               vpu: video-codec@38300000 { > > > +               vpu_ctrl: syscon@38320000 { > > > +                       compatible = "nxp,imx8mq-vpu-ctrl", "syscon"; > > > +                       reg = <0x38320000 0x10000>; > > > +               }; > > > + > > > +               vpu_g1: video-codec@38300000 { > > >                         compatible = "nxp,imx8mq-vpu"; > > > -                       reg = <0x38300000 0x10000>, > > > -                             <0x38310000 0x10000>, > > > -                             <0x38320000 0x10000>; > > > -                       reg-names = "g1", "g2", "ctrl"; > > > -                       interrupts = , > > > -                                    ; > > > -                       interrupt-names = "g1", "g2"; > > > +                       reg = <0x38300000 0x10000>; > > > +                       interrupts = ; > > > +                       interrupt-names = "g1"; > > >                         clocks = <&clk IMX8MQ_CLK_VPU_G1_ROOT>, > > >                                  <&clk IMX8MQ_CLK_VPU_G2_ROOT>, > > >                                  <&clk IMX8MQ_CLK_VPU_DEC_ROOT>; > > > @@ -1350,9 +1351,33 @@ vpu: video-codec@38300000 { > > >                                                  <&clk IMX8MQ_VPU_PLL_OUT>, > > >                                                  <&clk IMX8MQ_SYS1_PLL_800M>, > > >                                                  <&clk IMX8MQ_VPU_PLL>; > > > -                       assigned-clock-rates = <600000000>, <600000000>, > > > +                       assigned-clock-rates = <600000000>, <300000000>, > > I'd like to see this mentioned in the commit message. > > Yes I would do that. > The value comes from the datasheet. > > > > > > +                                              <800000000>, <0>; > > > +                       power-domains = <&pgc_vpu>; > > > +                       nxp,imx8mq-vpu-ctrl = <&vpu_ctrl>; > > > +               }; > > > + > > > +               vpu_g2: video-codec@38310000 { > > > +                       compatible = "nxp,imx8mq-vpu-g2"; > > > +                       reg = <0x38310000 0x10000>; > > > +                       interrupts = ; > > > +                       interrupt-names = "g2"; > > > +                       clocks = <&clk IMX8MQ_CLK_VPU_G1_ROOT>, > > > +                                <&clk IMX8MQ_CLK_VPU_G2_ROOT>, > > > +                                <&clk IMX8MQ_CLK_VPU_DEC_ROOT>; > > > +                       clock-names = "g1", "g2",  "bus"; > > > +                       assigned-clocks = <&clk IMX8MQ_CLK_VPU_G1>, > > Can the G1 clock configuration be dropped from the G2 device node and > > the G2 clock configuration from the G1 device node? It looks weird that > > these devices configure each other's clocks. > > No because if only one device node is enabled we need to configure the both > clocks anyway. > Since this is akward, how about adding a comment here in the dtsi to clarify it? Thanks, Ezequiel