From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83019C433E0 for ; Fri, 10 Jul 2020 21:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6447C2075D for ; Fri, 10 Jul 2020 21:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbgGJVtY (ORCPT ); Fri, 10 Jul 2020 17:49:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbgGJVtY (ORCPT ); Fri, 10 Jul 2020 17:49:24 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C324C08C5DC; Fri, 10 Jul 2020 14:49:24 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nicolas) with ESMTPSA id BAA9D2A6AC8 Message-ID: <9a897ef99048077233685b121b03bd750e4d4a83.camel@collabora.com> Subject: Re: [RFC 07/12] media: uapi: h264: Add DPB entry field reference flags From: Nicolas Dufresne To: Ezequiel Garcia , Boris Brezillon Cc: Jonas Karlman , Mauro Carvalho Chehab , Hans Verkuil , Philipp Zabel , Paul Kocialkowski , "linux-media@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Fri, 10 Jul 2020 17:49:07 -0400 In-Reply-To: <05b6cff6ba230c0ab6a562e17926d8503e2dfadd.camel@collabora.com> References: <20190901124531.23645-1-jonas@kwiboo.se> <233509924f72d69824920d9312373eced68674c0.camel@collabora.com> <20200710101333.05077f18@collabora.com> <6232d8475e169ee53b5864959af21d14bf0fc620.camel@collabora.com> <20200710140502.627b2b54@collabora.com> <05b6cff6ba230c0ab6a562e17926d8503e2dfadd.camel@collabora.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Le vendredi 10 juillet 2020 à 09:25 -0300, Ezequiel Garcia a écrit : > +Nicolas > > On Fri, 2020-07-10 at 14:05 +0200, Boris Brezillon wrote: > > On Fri, 10 Jul 2020 08:50:28 -0300 > > Ezequiel Garcia wrote: > > > > > On Fri, 2020-07-10 at 10:13 +0200, Boris Brezillon wrote: > > > > On Fri, 10 Jul 2020 01:21:07 -0300 > > > > Ezequiel Garcia wrote: > > > > > > > > > Hello Jonas, > > > > > > > > > > In the context of the uAPI cleanup, > > > > > I'm revisiting this patch. > > > > > > > > > > On Sun, 2019-09-01 at 12:45 +0000, Jonas Karlman wrote: > > > > > > Add DPB entry flags to help indicate when a reference frame is a > > > > > > field picture > > > > > > and how the DPB entry is referenced, top or bottom field or full > > > > > > frame. > > > > > > > > > > > > Signed-off-by: Jonas Karlman > > > > > > --- > > > > > > Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 12 ++++++++++++ > > > > > > include/media/h264-ctrls.h | 4 ++++ > > > > > > 2 files changed, 16 insertions(+) > > > > > > > > > > > > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > > > > > > b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > > > > > > index bc5dd8e76567..eb6c32668ad7 100644 > > > > > > --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > > > > > > +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > > > > > > @@ -2022,6 +2022,18 @@ enum > > > > > > v4l2_mpeg_video_h264_hierarchical_coding_type - > > > > > > * - ``V4L2_H264_DPB_ENTRY_FLAG_LONG_TERM`` > > > > > > - 0x00000004 > > > > > > - The DPB entry is a long term reference frame > > > > > > + * - ``V4L2_H264_DPB_ENTRY_FLAG_FIELD_PICTURE`` > > > > > > + - 0x00000008 > > > > > > + - The DPB entry is a field picture > > > > > > + * - ``V4L2_H264_DPB_ENTRY_FLAG_REF_TOP`` > > > > > > + - 0x00000010 > > > > > > + - The DPB entry is a top field reference > > > > > > + * - ``V4L2_H264_DPB_ENTRY_FLAG_REF_BOTTOM`` > > > > > > + - 0x00000020 > > > > > > + - The DPB entry is a bottom field reference > > > > > > + * - ``V4L2_H264_DPB_ENTRY_FLAG_REF_FRAME`` > > > > > > + - 0x00000030 > > > > > > + - The DPB entry is a reference frame > > > > > > > > > > > > ``V4L2_CID_MPEG_VIDEO_H264_DECODE_MODE (enum)`` > > > > > > Specifies the decoding mode to use. Currently exposes slice- > > > > > > based and > > > > > > diff --git a/include/media/h264-ctrls.h b/include/media/h264-ctrls.h > > > > > > index e877bf1d537c..76020ebd1e6c 100644 > > > > > > --- a/include/media/h264-ctrls.h > > > > > > +++ b/include/media/h264-ctrls.h > > > > > > @@ -185,6 +185,10 @@ struct v4l2_ctrl_h264_slice_params { > > > > > > #define V4L2_H264_DPB_ENTRY_FLAG_VALID 0x01 > > > > > > #define V4L2_H264_DPB_ENTRY_FLAG_ACTIVE 0x02 > > > > > > #define V4L2_H264_DPB_ENTRY_FLAG_LONG_TERM 0x04 > > > > > > +#define V4L2_H264_DPB_ENTRY_FLAG_FIELD_PICTURE 0x08 > > > > > > +#define V4L2_H264_DPB_ENTRY_FLAG_REF_TOP 0x10 > > > > > > +#define V4L2_H264_DPB_ENTRY_FLAG_REF_BOTTOM 0x20 > > > > > > +#define V4L2_H264_DPB_ENTRY_FLAG_REF_FRAME 0x30 > > > > > > > > > > > > > > > > I've been going thru the H264 spec and I'm unsure, > > > > > are all these flags semantically needed? > > > > > > > > > > For instance, if one of REF_BOTTOM or REF_TOP (or both) > > > > > are set, doesn't that indicate it's a field picture? > > > > > > > > > > Or conversely, if neither REF_BOTTOM or REF_TOP are set, > > > > > then it's a frame picture? > > > > > > > > I think that's what I was trying to do here [1] > > > > > > > > [1]https://patchwork.kernel.org/patch/11392095/ > > > > > > Right. Aren't we missing a DPB_ENTRY_FLAG_TOP_FIELD? > > > > > > If I understand correctly, the DPB can contain: > > > > > > * frames (FLAG_FIELD not set) > > > * a field pair, with a single field (FLAG_FIELD and either TOP or BOTTOM). > > > * a field pair, with boths fields (FLAG_FIELD and both TOP or BOTTOM). > > > > Well, my understand is that, if the buffer contains both a TOP and > > BOTTOM field, it actually becomes a full frame, so you actually have > > those cases: > > > > * FLAG_FIELD not set: this a frame (note that a TOP/BOTTOM field > > decoded buffer can become of frame if it's complemented with the > > missing field later during the decoding) > > * FLAG_FIELD set + BOTTOM_FIELD not set: this is a TOP field > > * FLAG_FIELD set + BOTTOM_FIELD set: this is a BOTTOM field > > * FLAG_FIELD not set + BOTTOM_FIELD set: invalid combination Let's admit, while this work, it's odd. Can we just move to that instewad ? FLAG_TOP_FIELD FLAG_BOTTOM_FIELD FLAG_FRAME = (FLAG_TOP_FIELD | FLAG_BOTTOM_FIELD) So it can be used as a flag, but also is a proper enum and there is no longer an invalid combination. > > > > but I might be wrong. > > Yes, perhaps that's correct. I was trying to think strictly > in terms of the H264 semantics, to define a clean interface. > > From the mpp code, looks like the above is enough for rkvdec > (although I haven't done any tests). > > Ezequiel > > >