linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Eugen.Hristev@microchip.com>
To: <hverkuil@xs4all.nl>, <linux-media@vger.kernel.org>
Cc: <p.zabel@pengutronix.de>
Subject: Re: [GIT PULL FOR v5.3] atmel-isc and coda enhancements
Date: Thu, 2 May 2019 13:24:12 +0000	[thread overview]
Message-ID: <9d5fbba6-0835-8665-9e47-9fbc17ca6022@microchip.com> (raw)
In-Reply-To: <1fc4f310-aa97-fa5f-ed1b-1253caabb003@xs4all.nl>

Hello Hans,

Would be great if you could at least get this into 5.2 :

media: atmel: atmel-isc: make try_fmt error less verbose

I noticed several sensor drivers act in a way that makes this message 
appear a lot, when the sensors actually work fine. They just return 
errors in try_fmt if the format is not supported, which is not a proper 
way to do it, but oh well, we have to cope with that in the caller.
Applications like gstreamer will call this many times from something 
like an enum_fmt iteration, which will eventually work, but, the 
atmel_isc will keep printing faulty messages, which is not exactly 
something desired in this situation.

(or if it's not possible now then maybe as -rc patch later on...)

Thanks,
Eugen

On 02.05.2019 16:13, Hans Verkuil wrote:

> This previous PR https://patchwork.linuxtv.org/patch/55818/ is now split
> in two, one with patches for 5.2 and one with stuff that can go into 5.3.
> 
> This PR contains the patches with new features for 5.3.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit 7afa8db323e37b9174cf78a1c9ab0ae7a9f5e7dd:
> 
>    media: vsp1: Add support for missing 16-bit RGB555 formats (2019-04-25 11:07:05 -0400)
> 
> are available in the Git repository at:
> 
>    git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3a
> 
> for you to fetch changes up to 73d1351fb7d7dafd88d15848bfacfe9f16b13351:
> 
>    media: coda: use v4l2_m2m_buf_copy_metadata (2019-05-02 15:04:53 +0200)
> 
> ----------------------------------------------------------------
> Tag branch
> 
> ----------------------------------------------------------------
> Eugen Hristev (4):
>        media: atmel: atmel-isc: reworked white balance feature
>        media: v4l2-ctrl: fix flags for DO_WHITE_BALANCE
>        media: atmel: atmel-isc: add support for DO_WHITE_BALANCE
>        media: atmel: atmel-isc: make try_fmt error less verbose
> 
> Philipp Zabel (12):
>        media: coda: move register debugging to coda_debug level 3
>        media: coda: move job ready message to coda_debug level 2
>        media: coda: add coda_frame_type_char helper
>        media: coda: improve decoder job finished debug message
>        media: coda: demote s_ctrl debug messages to level 2
>        media: coda: add menu strings to s_ctrl debug output
>        media: coda: update profile and level controls after sequence initialization
>        media: coda: add decoder MPEG-4 profile and level controls
>        media: v4l2-ctrl: add MPEG-2 profile and level controls
>        media: coda: add decoder MPEG-2 profile and level controls
>        media: coda: add lockdep asserts
>        media: coda: use v4l2_m2m_buf_copy_metadata
> 
>   Documentation/media/uapi/v4l/ext-ctrls-codec.rst |  56 +++++++++++++++++++
>   drivers/media/platform/atmel/atmel-isc-regs.h    |   6 ++-
>   drivers/media/platform/atmel/atmel-isc.c         | 263 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------
>   drivers/media/platform/coda/Makefile             |   2 +-
>   drivers/media/platform/coda/coda-bit.c           |  69 +++++++++++++++++++-----
>   drivers/media/platform/coda/coda-common.c        | 129 +++++++++++++++++++++++++++++++++-----------
>   drivers/media/platform/coda/coda-mpeg2.c         |  44 +++++++++++++++
>   drivers/media/platform/coda/coda-mpeg4.c         |  48 +++++++++++++++++
>   drivers/media/platform/coda/coda.h               |  14 +++++
>   drivers/media/platform/coda/coda_regs.h          |   2 +-
>   drivers/media/v4l2-core/v4l2-ctrls.c             |  24 +++++++++
>   include/uapi/linux/v4l2-controls.h               |  18 +++++++
>   12 files changed, 597 insertions(+), 78 deletions(-)
>   create mode 100644 drivers/media/platform/coda/coda-mpeg2.c
>   create mode 100644 drivers/media/platform/coda/coda-mpeg4.c
> 

  reply	other threads:[~2019-05-02 13:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02 13:13 [GIT PULL FOR v5.3] atmel-isc and coda enhancements Hans Verkuil
2019-05-02 13:24 ` Eugen.Hristev [this message]
2019-05-21 11:32 ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d5fbba6-0835-8665-9e47-9fbc17ca6022@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).