From: Ken Sloat <KSloat@aampglobal.com>
To: "Eugen.Hristev@microchip.com" <Eugen.Hristev@microchip.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"Nicolas.Ferre@microchip.com" <Nicolas.Ferre@microchip.com>,
"sakari.ailus@iki.fi" <sakari.ailus@iki.fi>,
"hverkuil@xs4all.nl" <hverkuil@xs4all.nl>
Subject: RE: [PATCH] media: atmel: atmel-isc: reworked driver and formats
Date: Mon, 18 Feb 2019 13:37:26 +0000 [thread overview]
Message-ID: <BL0PR07MB4115ECEE3BED0B46C342F4A9AD630@BL0PR07MB4115.namprd07.prod.outlook.com> (raw)
In-Reply-To: <1550219467-9532-1-git-send-email-eugen.hristev@microchip.com>
> -----Original Message-----
> From: Eugen.Hristev@microchip.com <Eugen.Hristev@microchip.com>
> Sent: Friday, February 15, 2019 3:38 AM
> To: linux-media@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; mchehab@kernel.org;
> Nicolas.Ferre@microchip.com; Ken Sloat <KSloat@aampglobal.com>;
> sakari.ailus@iki.fi; hverkuil@xs4all.nl
> Cc: Eugen.Hristev@microchip.com
> Subject: [PATCH] media: atmel: atmel-isc: reworked driver and formats
>
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> This change is a redesign in the formats and the way the ISC is configured
> w.r.t. sensor format and the output format from the ISC.
> I have changed the splitting between sensor output (which is also ISC input)
> and ISC output.
> The sensor format represents the way the sensor is configured, and what ISC
> is receiving.
> The format configuration represents the way ISC is interpreting the data and
> formatting the output to the subsystem.
> Now it's much easier to figure out what is the ISC configuration for input, and
> what is the configuration for output.
> The non-raw format can be obtained directly from sensor or it can be done
> inside the ISC. The controller format list will include a configuration for each
> format.
> The old supported formats are still in place, if we want to dump the sensor
> format directly to the output, the try format routine will detect and configure
> the pipeline accordingly.
> This also fixes the previous issues when the raw format was NULL which
> resulted in many crashes for sensors which did not have the expected/tested
> formats.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> Hello Ken and possibly others using ISC driver,
>
> I would appreciate if you could test this patch with your sensor, because I do
> not wish to break anything in your setups.
> Feedback is appreciated if any errors appear, so I can fix them.
> I tested with ov5640, ov7670, ov7740(only in 4.19 because on latest it's
> broken for me...) Rebased this patch on top of mediatree.git/master Thanks!
>
> Eugen
>
Hi Eugen,
No problem I will try to test sometime this week on my setup. I appreciate you keeping me in the loop.
Thanks,
Ken
next prev parent reply other threads:[~2019-02-18 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 8:37 [PATCH] media: atmel: atmel-isc: reworked driver and formats Eugen.Hristev
2019-02-18 13:37 ` Ken Sloat [this message]
2019-03-11 14:25 ` Hans Verkuil
2019-03-11 14:36 ` Hans Verkuil
2019-03-11 15:05 ` Eugen.Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR07MB4115ECEE3BED0B46C342F4A9AD630@BL0PR07MB4115.namprd07.prod.outlook.com \
--to=ksloat@aampglobal.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).