From: "Zhi, Yong" <yong.zhi@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"Mani, Rajmohan" <rajmohan.mani@intel.com>,
"tfiga@chromium.org" <tfiga@chromium.org>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
"Cao, Bingbu" <bingbu.cao@intel.com>
Subject: RE: [PATCH v2 2/2] media: ipu3-imgu: Remove dead code for NULL check
Date: Fri, 1 Feb 2019 15:47:42 +0000 [thread overview]
Message-ID: <C193D76D23A22742993887E6D207B54D3DB6C079@ORSMSX106.amr.corp.intel.com> (raw)
In-Reply-To: <20190201104322.r2lgas55wc5pgq6s@paasikivi.fi.intel.com>
Hi, Sakari,
> -----Original Message-----
> From: Sakari Ailus [mailto:sakari.ailus@linux.intel.com]
> Sent: Friday, February 1, 2019 2:43 AM
> To: Zhi, Yong <yong.zhi@intel.com>
> Cc: linux-media@vger.kernel.org; Mani, Rajmohan
> <rajmohan.mani@intel.com>; tfiga@chromium.org;
> laurent.pinchart@ideasonboard.com; hans.verkuil@cisco.com;
> mchehab@kernel.org; dan.carpenter@oracle.com; Qiu, Tian Shu
> <tian.shu.qiu@intel.com>; Cao, Bingbu <bingbu.cao@intel.com>
> Subject: Re: [PATCH v2 2/2] media: ipu3-imgu: Remove dead code for NULL
> check
>
> Hi Yong,
>
> On Wed, Jan 16, 2019 at 09:18:47AM -0800, Yong Zhi wrote:
> > Since ipu3_css_buf_dequeue() never returns NULL, remove the dead code
> > to fix static checker warning:
> >
> > drivers/staging/media/ipu3/ipu3.c:493 imgu_isr_threaded()
> > warn: 'b' is an error pointer or valid
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> [Bug report:
> > https://lore.kernel.org/linux-media/20190104122856.GA1169@kadam/]
> > Signed-off-by: Yong Zhi <yong.zhi@intel.com>
> > Reviewed-by: Tomasz Figa <tfiga@chromium.org>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> I don't see Laurent's Reviewed-by: tag on the list. Did you get that from him
> off-list? If he hasn't given one, please send v3 without that tag.
>
The bug report link was suggested by Laurent, so that I assume he reviewed the patch, I can re-send without the tag if this does not count.
> Thanks.
>
> --
> Sakari Ailus
> sakari.ailus@linux.intel.com
prev parent reply other threads:[~2019-02-01 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 17:18 [PATCH v2 1/2] media: ipu3-imgu: Use MENU type for mode control Yong Zhi
2019-01-16 17:18 ` [PATCH v2 2/2] media: ipu3-imgu: Remove dead code for NULL check Yong Zhi
2019-02-01 10:43 ` Sakari Ailus
2019-02-01 15:47 ` Zhi, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C193D76D23A22742993887E6D207B54D3DB6C079@ORSMSX106.amr.corp.intel.com \
--to=yong.zhi@intel.com \
--cc=bingbu.cao@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).