From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07926C4338F for ; Thu, 5 Aug 2021 11:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD5ED610A8 for ; Thu, 5 Aug 2021 11:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241116AbhHELwW (ORCPT ); Thu, 5 Aug 2021 07:52:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241131AbhHELwV (ORCPT ); Thu, 5 Aug 2021 07:52:21 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B79CBC0613C1 for ; Thu, 5 Aug 2021 04:52:06 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id z7so6282822iog.13 for ; Thu, 05 Aug 2021 04:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f4GRvnSd2SfTisSbPOnvrb1AGqj2A6VfpqkuBFd8fVE=; b=RWa/9OFA5awZx3nilxSRf38QZA0f7ubdiVCjTcKfbkE6DezE9w4XMThdZXYqSnnP5q yLejaEgrb0dLym3yOlSQi8X7hH1DKT+OE/XS3F/GtWC18T+WO/5VvBhdl/6uIMAZYsEL Ey3GcEd+6nlnFLkN9iEACLdTqz/rTF7G78jbO9FNQrCtjIZtxQP7FZKEy4of+A+3S/xW hOk/2dfaPt1XYEcLvHDzfzp1ri5mWwCcp3JPcRN0KemjmPuMNHgec454Ea98OJbxoedd HoaSAJgbmS5FX08kMgqhGkl2kK/WXSX+Ay76zBA6ij4ju+SXFZ8u9ojXfeKUJGJPpmSX 5zxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f4GRvnSd2SfTisSbPOnvrb1AGqj2A6VfpqkuBFd8fVE=; b=DK4WDLRyvHYhZxYY2Ir53LVIyHxL3Y0sfH29aAxDVkhFfPIfUQQ5dbkipQqspiPCxD d2R94eY87jguBFcxFJqxDF+JTrowaw2nbwebW/1/TyHKZGTYl1Xjtdfe4fVodpTFfb0G 5cRWgRoQg742Ja+qLxCHT+1MN8nrvGU5RzLZH5hpzc7VVQfVg25eiAa7mrqQ63j/USR2 07QTQWGALGjQSz+GG6EjKx670HF3SYDE34Is+/4gz3Ho18Z8ofxzMIEHx0XLMooOb67L UPrCFSnpLxGzRm1XvypFZWkLrevuQt3PB/eQC7iz+0zbkWpnDEh2dGIluz2HqmCkhSE+ e+Ig== X-Gm-Message-State: AOAM530n+iQ4jGL+3gCm/ciCFYXxA6zgcqusAvjO2IfVCHtMxv9AtAoH 3iNDLbucXlxNrAe47nV28VUel6shd/clwUyFjgZRwg== X-Google-Smtp-Source: ABdhPJzGQPitS//icrJkZI9zrnhgfKCvXOkyoNpJVFRpO/Os1R43Br1+wcD58Q5kYse0TOwb7aERr1q8UeqA5ufhZCE= X-Received: by 2002:a6b:ea18:: with SMTP id m24mr972480ioc.76.1628164326010; Thu, 05 Aug 2021 04:52:06 -0700 (PDT) MIME-Version: 1.0 References: <20210705053258.1614177-1-acourbot@chromium.org> <20210705053258.1614177-13-acourbot@chromium.org> In-Reply-To: From: Tzung-Bi Shih Date: Thu, 5 Aug 2021 19:51:55 +0800 Message-ID: Subject: Re: [PATCH v6 12/14] media: mtk-vcodec: vdec: add media device if using stateless api To: Dafna Hirschfeld Cc: Alexandre Courbot , Tiffany Lin , Andrew-CT Chen , Hans Verkuil , Yunfei Dong , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Collabora Kernel ML , Enric Balletbo i Serra Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Jul 20, 2021 at 12:22 AM Dafna Hirschfeld wrote: > On 05.07.21 07:32, Alexandre Courbot wrote: > > + mtk_v4l2_debug(0, "media registered as /dev/media%d", vfd_dec->num); > the media's node minor is not vfd_dec->num IIUC, it should be vfd_dec->minor[1]. Will fix in the next version. [1]: https://elixir.bootlin.com/linux/v5.14-rc4/source/include/media/v4l2-dev.h#L243 > > struct mtk_vcodec_dev { > This structs has a lot of duplicated fields for enc/dec > Since the device represents either a decoder or an encoder, > I think all those dupliactes can be removed, so for example > instead of having both 'dec_irq' and 'enc_irq' we can have just 'irq' I understand the struct may contain duplicate fields. However I prefer to separate the refactor into another series. Would provide the fixes later.