From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02783C07E96 for ; Thu, 8 Jul 2021 10:05:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF60661C5B for ; Thu, 8 Jul 2021 10:05:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231450AbhGHKHu (ORCPT ); Thu, 8 Jul 2021 06:07:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbhGHKHt (ORCPT ); Thu, 8 Jul 2021 06:07:49 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB75DC06175F for ; Thu, 8 Jul 2021 03:05:07 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id u7so7484644ion.3 for ; Thu, 08 Jul 2021 03:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R4fhY/yLoZMmhCqnp0rYwJfbvJ3m+VsDi3PuO02Dh10=; b=UYLH/VW8SI7ZogoX7fR4NWP4DRGl1d62SfimYKsYGCETDopjoL/y+RsptFQTSoByGW q+sENfaHQCddz+goHWQTbvBYRlZpPNGTD+hwSbScS+9stYayGZQXolfj/woo+NmCRBFa jGhhZ2GepPegJFGXuvZ83xSc31slF8PwiWyq/CFpd9Wkx+YE6ESZv0Bd/Zg2Bn1QN4L3 XlwQ5Gw1bepr7GNdQBbKm28jDLcSJf11PX8aOk5pdKA+hC4hLLRMYbVPpSJHXz2ar6DR UDOSQX01Z+z/FHqmL6RR7vDsF7HIoczBZVtLjl/NWXDfF8VnYSiP+1906qUiWuzmA55S 3mlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R4fhY/yLoZMmhCqnp0rYwJfbvJ3m+VsDi3PuO02Dh10=; b=UacvIFhLpsCWW1JyjsMkKdHqPgw77kJ/ZaME4a+5K8IKQ3tBv2pLiLoDxI9iMS10ss TgdjzaTvHRr3zXEArEgdbD5K4LWTxWrVcYi9e6rulE/cJ+6Ne4wh5lKG/zL0dcHTBEZE 6Qsd9lEJn9PTkjUpIPF/41KG4tGWN5gbZ+oqZ37OsfX6qpskC4pdSjTM7TB+Obd+Vnmc tDTU3bKwDFZYnLjNRgsHAGHcmmPE7/rZSSLg4qy6FU6HE9rG2TQjxCUALJLyzieYGdQf Q1xjxmyqd1eXAiofpvOARSMLfbrq0sYmM3un+0OeXzyvf3fBIfOeDo9ba7Jv52F9lIvy fx1w== X-Gm-Message-State: AOAM5302osoIYlS2NAc3KamQ3rNX6kBhBIe0LFJJzYC5tyiVTQMZRDlh 0rodbnZMpaIEF3oifk3shgDPRmtNp0HXyAO7rU9Sfw== X-Google-Smtp-Source: ABdhPJxdKSoYDqcwBIX1WQ4+fbUqa84UqW8rvefJuvTTO1vwGh4lLoujDgkp/mZyijH1oUQhvQsnJcYa+CxvYJZElwI= X-Received: by 2002:a02:9402:: with SMTP id a2mr26130879jai.110.1625738705769; Thu, 08 Jul 2021 03:05:05 -0700 (PDT) MIME-Version: 1.0 References: <20210707062157.21176-1-yunfei.dong@mediatek.com> <20210707062157.21176-5-yunfei.dong@mediatek.com> In-Reply-To: <20210707062157.21176-5-yunfei.dong@mediatek.com> From: Tzung-Bi Shih Date: Thu, 8 Jul 2021 18:04:54 +0800 Message-ID: Subject: Re: [PATCH v1, 04/14] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong wrote: > .../media/mediatek-vcodec-decoder.txt | 169 ++++++++++++++++++ > .../media/mediatek-vcodec-encoder.txt | 73 ++++++++ > 2 files changed, 242 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-decoder.txt > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vcodec-encoder.txt The patch is weird. Its title says "separate" but the changes are all creating new content. Would expect the patch to remove content from some files (e.g. Documentation/devicetree/bindings/media/mediatek-vcodec.txt) and separate into 2 files. Also would expect the patch is a refactor which shouldn't introduce any new things.