From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F1FDC433E9 for ; Mon, 11 Jan 2021 18:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 126DE22AAF for ; Mon, 11 Jan 2021 18:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390233AbhAKSMM (ORCPT ); Mon, 11 Jan 2021 13:12:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390230AbhAKSMM (ORCPT ); Mon, 11 Jan 2021 13:12:12 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E30EC061786 for ; Mon, 11 Jan 2021 10:11:31 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id w1so909667ejf.11 for ; Mon, 11 Jan 2021 10:11:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZheorGSTfgd88VVFRSNsRcjuZSZpq1vykcWg/KvDChs=; b=gs12mhRbkRDLQX/6SckZEyeDpBAdQGlKd4nf/EyWDLEj07/LTf4rYxSUIAPjPFM+PY tC9J3o7p5a4hFG5SPMQ/aBZVGX2bnJ1IBXAWbEFrDOuuYtr7RTgRSbu8M+0CJqzJ7Itn DbnSM1kONKRe+ynT8uTAKESH8tYuaQHn4Y/x6Lk4Pr/wBxxd1y+nnP80GDqQGOg7kwMi WPfuKnQ5RuVQ2nqflScTu8mWUqjSloWUhP+RhXQiZG9e0Xav40Q32v0EfscPAMnUhoIT 64YxKGAkWkI7gHnpn4uoBJaSV9D/ZQKQH54fa8lb11gbGqHA18ZOvuA2b7Rz+lRaFtdl 8yJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZheorGSTfgd88VVFRSNsRcjuZSZpq1vykcWg/KvDChs=; b=F3HLeVFkZJT5tj25gH1JOgzNTI1u2O4mlCfnkd6pDweINFnV/B32ZwdTNfCaNamUWV h8uU1brEDjDFsZvsYqA7P5ACuu5jWUsK4XnvYQsqwX2FKyJni2NNG2KwkGdaaYq31wzC 7IMJwjHTuuFFTlF15UsrRSBiMsk24YaNoFbiiaemHOlj7Q2JS4hzQkd/Q1gsvD2szsCL Co+7FbnOvr1uZ2Q23tWTAN/mTWVpuF5PhwRjQqKiz9C48Da5kN+aCUTQEI1CJ5g0OAlr gvNlZL7z2QPXrWZK3nqbBUnAyMLQH//19ePpQ7z/SV3DtGfz5gLVMz3FTSIOxtzTHXTl vaXQ== X-Gm-Message-State: AOAM532G5NuH9/UQ+BHR6+xotnvBE5LhKloO+prWkIDYDGyaXjrt1/zD aJQ5vW3V5z4W1Kf9y9BRku8PsbRs8fidnRX7ScMZMQ== X-Google-Smtp-Source: ABdhPJzxgFsUtoVLIF49QjS3VoJV2KHCOv1fviyrbLtL5fuWpUiZwQi1Wh1a6uPJ25egRkVpTjsjP0y69emZDFIBZm0= X-Received: by 2002:a17:906:e84:: with SMTP id p4mr490149ejf.141.1610388690333; Mon, 11 Jan 2021 10:11:30 -0800 (PST) MIME-Version: 1.0 References: <20210111145445.28854-1-ribalda@chromium.org> <20210111145445.28854-7-ribalda@chromium.org> In-Reply-To: <20210111145445.28854-7-ribalda@chromium.org> From: Ezequiel Garcia Date: Mon, 11 Jan 2021 15:11:18 -0300 Message-ID: Subject: Re: [PATCH 6/9] media: sum4i-csi: Do not zero reserved fields To: Ricardo Ribalda Cc: linux-media , Linux Kernel Mailing List , Maxime Ripard , Chen-Yu Tsai Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Ricardo, Thanks a lot for doing this media-wide cleanup. Aside from a silly typo here in the commit title, s/sum4i-csi/sun4i-csi, all the patches seem fine. Thanks, Ezequiel On Mon, 11 Jan 2021 at 11:56, Ricardo Ribalda wrote: > > Core code already clears reserved fields of struct > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero > v4l2_plane_pix_format reserved fields"). > > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Signed-off-by: Ricardo Ribalda > --- > drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c > index 1a2f65d83a6c..4785faddf630 100644 > --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c > +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c > @@ -113,8 +113,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi, > pix->num_planes = _fmt->num_planes; > pix->pixelformat = _fmt->fourcc; > > - memset(pix->reserved, 0, sizeof(pix->reserved)); > - > /* Align the width and height on the subsampling */ > width = ALIGN(pix->width, _fmt->hsub); > height = ALIGN(pix->height, _fmt->vsub); > @@ -131,8 +129,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi, > bpl = pix->width / hsub * _fmt->bpp[i] / 8; > pix->plane_fmt[i].bytesperline = bpl; > pix->plane_fmt[i].sizeimage = bpl * pix->height / vsub; > - memset(pix->plane_fmt[i].reserved, 0, > - sizeof(pix->plane_fmt[i].reserved)); > } > } > > -- > 2.30.0.284.gd98b1dd5eaa7-goog >