Re: [PATCH v9 00/22] uvcvideo: Fix v4l2-compliance errors

From: Tomasz Figa <tfiga@chromium.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ricardo Ribalda <ribalda@chromium.org>
Subject: Re: [PATCH v9 00/22] uvcvideo: Fix v4l2-compliance errors
Date: Tue, 25 May 2021 17:06:35 +0900	[thread overview]
Message-ID: <CAAFQd5AegMJCrcV7Qpb0oUQLjSiDa+Q7=ojrZs+z+WDSwLq6Ng@mail.gmail.com> (raw)
In-Reply-To: <20210326095840.364424-1-ribalda@chromium.org>

Hi everyone,

On Fri, Mar 26, 2021 at 6:58 PM Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> *v4l2-compliance -m /dev/media0 -a -f
> Total for uvcvideo device /dev/media0: 8, Succeeded: 6, Failed: 2, Warnings: 0
> Total for uvcvideo device /dev/video0: 54, Succeeded: 50, Failed: 4, Warnings: 2
> Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
> Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 102,
> Failed: 6, Warnings: 2
>
> After fixing all of them we go down to:
>
> Total for uvcvideo device /dev/media0: 8, Succeeded: 8, Failed: 0, Warnings: 0
> Total for uvcvideo device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0
> Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
> Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 108,
> Failed: 0, Warnings: 0
>
> YES, NO MORE WARNINGS :)
>
> Note that we depend on:
>
> https://patchwork.linuxtv.org/project/linux-media/patch/20210317143453.483470-1-ribalda@chromium.org/
>
> With Hans patch we can also pass v4l2-compliance -s.
>
> Changelog from v8 (Thanks to Hans)
> - 3 patches from Hans
> - Add Reviewed-by
>
> Hans Verkuil (4):
>   uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE
>   uvcvideo: improve error handling in uvc_query_ctrl()
>   uvcvideo: don't spam the log in uvc_ctrl_restore_values()
>   uvc: use vb2 ioctl and fop helpers
>
> Ricardo Ribalda (18):
>   media: v4l2-ioctl: Fix check_ext_ctrls
>   media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL
>   media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL
>   media: v4l2-ioctl: S_CTRL output the right value
>   media: uvcvideo: Remove s_ctrl and g_ctrl
>   media: uvcvideo: Set capability in s_param
>   media: uvcvideo: Return -EIO for control errors
>   media: uvcvideo: refactor __uvc_ctrl_add_mapping
>   media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS
>   media: uvcvideo: Use dev->name for querycap()
>   media: uvcvideo: Set unique vdev name based in type
>   media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE
>   media: uvcvideo: Use control names from framework
>   media: uvcvideo: Check controls flags before accessing them
>   media: uvcvideo: Set error_idx during ctrl_commit errors
>   media: uvcvideo: Return -EACCES to inactive controls
>   media: docs: Document the behaviour of uvcdriver
>   media: uvcvideo: Downgrade control error messages
>
>  .../userspace-api/media/v4l/vidioc-g-ctrl.rst |   5 +
>  .../media/v4l/vidioc-g-ext-ctrls.rst          |   5 +
>  drivers/media/usb/pvrusb2/pvrusb2-v4l2.c      |   4 -
>  drivers/media/usb/uvc/uvc_ctrl.c              | 343 +++++++++++----
>  drivers/media/usb/uvc/uvc_driver.c            |  22 +-
>  drivers/media/usb/uvc/uvc_metadata.c          |  10 +-
>  drivers/media/usb/uvc/uvc_queue.c             | 143 -------
>  drivers/media/usb/uvc/uvc_v4l2.c              | 389 +++---------------
>  drivers/media/usb/uvc/uvc_video.c             |  51 ++-
>  drivers/media/usb/uvc/uvcvideo.h              |  54 +--
>  drivers/media/v4l2-core/v4l2-ioctl.c          |  67 +--
>  11 files changed, 444 insertions(+), 649 deletions(-)
>
> --
> 2.31.0.291.g576ba9dcdaf-goog
>

Any comments on this? Could we have this merged?

Thanks,
Tomasz