From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D172EC433FF for ; Fri, 9 Aug 2019 08:15:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9141B20B7C for ; Fri, 9 Aug 2019 08:15:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Cw9EXq82" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405612AbfHIIP2 (ORCPT ); Fri, 9 Aug 2019 04:15:28 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:45986 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbfHIIP1 (ORCPT ); Fri, 9 Aug 2019 04:15:27 -0400 Received: by mail-ed1-f67.google.com with SMTP id x19so88121498eda.12 for ; Fri, 09 Aug 2019 01:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DhlV3mGwU57S5uU/9S38xCSvL+IZrv6wUmIj2HFWWUQ=; b=Cw9EXq82OVoxnWyFa/ORrROmYriVej1qHYyJkvd0Y/Ao2zwD02RQKysU4iEXdypzzS fZUJtPRYvHMZ8Cs3FHbI6C9J5A6uzi0JkcsjFJt6T3KKBiUpv1rHxbJwnqZlynOcaa1r oKV54KMG+GQSkgqf8IGEDQnhTmetVzlQfJyX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DhlV3mGwU57S5uU/9S38xCSvL+IZrv6wUmIj2HFWWUQ=; b=DbEZycQV8pWxijdiOio2a57FbmzVTXem3N6GDKJlJVqJP24npJ2YNwOBR4lpr3fAhW BF+FffMoYRT8UikS012Q2WNASdKPbo5v61vEJlXwclrB7p9CM3+vm3JaTNrX6MeG7k4X /b7pjogMySI/F+e6OrZ1Jl/zA6RjnkGSGr5FfmGuQpbRHzQ3aRYe8pDkxQBrGGyNh9b6 tFPxZRCuPI7WWPVCtrdm/E+ADylCPgKZVAhXFBirzz510CMud91GIQ4cx4C9t2/ex8K7 gL847sgOOvfFxztVznrZiP1MQXg39PevyasUWi9kgXLXsmpSR9N840gDbGOIW7/qBTXD 19kQ== X-Gm-Message-State: APjAAAXSzFp3q2iuo3hxEKwygwIZcmcVwM8n0nKh3lB0cwMVLs2QpVLG 4fA4yQKiA1GGh6wYxIP06UzyuucAe2Vx3A== X-Google-Smtp-Source: APXvYqxePLpub5/uYZ8s+ZPkjk8wPwVa2zN/3J1FDJseYbn1g0twd0uP6RYHabWDS3y98ESnl+la2w== X-Received: by 2002:a17:906:3948:: with SMTP id g8mr17390797eje.240.1565338525093; Fri, 09 Aug 2019 01:15:25 -0700 (PDT) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com. [209.85.221.51]) by smtp.gmail.com with ESMTPSA id w35sm22363481edd.32.2019.08.09.01.15.24 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 09 Aug 2019 01:15:24 -0700 (PDT) Received: by mail-wr1-f51.google.com with SMTP id z1so97397012wru.13 for ; Fri, 09 Aug 2019 01:15:24 -0700 (PDT) X-Received: by 2002:a5d:49c5:: with SMTP id t5mr9090444wrs.48.1565338053713; Fri, 09 Aug 2019 01:07:33 -0700 (PDT) MIME-Version: 1.0 References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-5-git-send-email-Jerry-Ch.chen@mediatek.com> <1564380061.15267.383.camel@mtksdccf07> <1564401491.15267.405.camel@mtksdccf07> In-Reply-To: <1564401491.15267.405.camel@mtksdccf07> From: Tomasz Figa Date: Fri, 9 Aug 2019 17:07:21 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver To: "Enrico Weigelt, metux IT consult" Cc: Jerry-ch Chen , Hans Verkuil , Sakari Ailus , "matthias.bgg@gmail.com" , "mchehab@kernel.org" , "shik@chromium.org" , "devicetree@vger.kernel.org" , =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , =?UTF-8?B?UnlubiBXdSAo5ZCz6IKy5oGpKQ==?= , srv_heupstream , =?UTF-8?B?UG8tWWFuZyBIdWFuZyAo6buD5p+P6Zm9KQ==?= , "suleiman@chromium.org" , =?UTF-8?B?SnVuZ28gTGluICjmnpfmmI7kv4op?= , =?UTF-8?B?U2ogSHVhbmcgKOm7g+S/oeeSiyk=?= , "yuzhao@chromium.org" , "linux-mediatek@lists.infradead.org" , "zwisler@chromium.org" , =?UTF-8?B?Q2hyaXN0aWUgWXUgKOa4uOmbheaDoCk=?= , =?UTF-8?B?RnJlZGVyaWMgQ2hlbiAo6Zmz5L+K5YWDKQ==?= , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "laurent.pinchart+renesas@ideasonboard.com" , "hans.verkuil@cisco.com" Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jul 29, 2019 at 8:58 PM Jerry-ch Chen wrote: > > Hi Tomasz, > > On Mon, 2019-07-29 at 17:57 +0800, Tomasz Figa wrote: > > On Mon, Jul 29, 2019 at 3:01 PM Jerry-ch Chen > > wrote: > > > > > > Hi Enrico, > > > > > > On Tue, 2019-07-09 at 18:56 +0800, Enrico Weigelt, metux IT consult > > > wrote: > > > > On 09.07.19 10:41, Jerry-ch Chen wrote: > > > > > > > > Hi, > > > > > > > > > > > > > diff --git a/drivers/media/platform/mtk-isp/fd/mtk_fd.h b/drivers/media/platform/mtk-isp/fd/mtk_fd.h > > > > > new file mode 100644 > > > > > index 0000000..289999b > > > > > --- /dev/null > > > > > +++ b/drivers/media/platform/mtk-isp/fd/mtk_fd.h > > > > > @@ -0,0 +1,157 @@ > > > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > > > +// > > > > > +// Copyright (c) 2018 MediaTek Inc. > > > > > + > > > > > +#ifndef __MTK_FD_HW_H__ > > > > > +#define __MTK_FD_HW_H__ > > > > > + > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > > +#define MTK_FD_OUTPUT_MIN_WIDTH 26U > > > > > +#define MTK_FD_OUTPUT_MIN_HEIGHT 26U > > > > > +#define MTK_FD_OUTPUT_MAX_WIDTH 640U > > > > > +#define MTK_FD_OUTPUT_MAX_HEIGHT 480U > > > > > + > > > > > +/* Control the user defined image widths and heights > > > > > + * to be scaled and performed face detection in FD HW. > > > > > + * MTK FD support up to 14 user defined image sizes to perform face detection. > > > > > + */ > > > > > +#define V4L2_CID_MTK_FD_SCALE_IMG_WIDTH (V4L2_CID_USER_MTK_FD_BASE + 1) > > > > > +#define V4L2_CID_MTK_FD_SCALE_IMG_HEIGHT (V4L2_CID_USER_MTK_FD_BASE + 2) > > > > > > > > I've got a *really* bad feeling about introducing chip specific > > > > uapi stuff. (by the way: uapi stuff belongs into include/uapi/...) > > > > > > > Thanks for your comments, > > > > > > If we remain chip-specific control IDs, I will move the uapi stuff into > > > inlcude/uapi/mtk_fd.h (filename TBD) > > > > > > > Maybe you could tell us what that's *really* about, so we can find some > > > > standard / chip-independent api for these things. That's one of the > > > > major point of the kernel: hardware abstraction. > > > > > > > I am not sure if it is possible for us to add some standard > > > v4l2-controls for face detection, a further explanations of controls are > > > listed below. > > > > > > In v4l2-controls, there exists V4L2_CID_DETECT_CLASS, but I haven't > > > found the standards or api that can be used for face detection yet. > > > https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/v4l2-controls.h#L1092 > > > > > > For detecting certain face angle and head direction, we would need > > > V4L2_CID_DETECT_ANGLE, V4L2_CID_DETECT_DIRECTION controls for user to > > > specify the angle and direction to be detected. > > > In MTK FD driver, we support the following angles and directions to be > > > selected by user, and they are both multiple selected . > > > FD_angle_table[] = {-90, -45, 0 , 45, 90} > > > FD_direction_table[] = {0, 30, 60, 90, 120, 150, ..., 330} > > > > > > Assuming these v4l2-controls are array of V4L2_CTRL_TYPE_U16 with > > > dimension 5 and 12. > > > User can select the desired angle and directions to be detected into > > > arrays and bring it to driver by these controls, however, the more they > > > select, the longer execution time needed by HW. > > > > > > > Sounds like we need some kind of a menu bitmask control here, but I > > don't see V4L2 having anything like that. > > > > Hans, Sakari, any ideas? > > > > > For detecting different sizes of faces and increase the detection speed, > > > FD driver might need to scales down the input image into different > > > smaller sizes > > > > Do you mean the FD hardware would do the scaling or the driver code > > itself? It would be undesirable to do such scaling in a kernel driver, > > so if that's not something handled by the hardware, the downscaled > > image might need to be provided from the userspace. > > > Thanks for your comments. > > Yes, FD hardware will do the scaling itself, so driver could set the > sizes. > > > >, besides driver default values, user or proprietary > > > algorithm library can manually set the desired image sizes, therefore, > > > we would need the following controls: > > > V4L2_CID_DETECT_SCALE_DOWN_IMG_WIDTH and > > > V4L2_CID_DETECT_SCALE_DOWN_IMG_HEIGHT. > > > In MTK FD driver, we implement these controls as array of > > > V4L2_CTRL_TYPE_U16 with the dimension 15. > > > > Why 15? > > > It consists of one input image size and 14 down-scaled image sizes, > the amount 15 (or say 14) is defined by the MTK FD algo library, > therefore I remain the number of 15 here for communicate with the > library. > Maybe it should be defined as following? > MTK_FD_MAX_SCALE_SIZE_NUM 14 > and > MTK_FD_SCALE_ARR_NUM 15 > > > > > > > For controlling detection speed, we would need the > > > V4L2_CID_DETECT_SPEED, the faster speedup implies the lower accuracy of > > > detection, In MTK FD driver, the max level of speedup is 7, and default > > > value is 0. > > > > > > For MTK FD algorithm user library, they would need select extra > > > detection features(models) used in HW, we need > > > V4L2_CID_MTK_FD_EXTRA_MODEL, this will be set to 1 for using extra > > > model. However, we are considering make this control more > > > chip-independent and can be added into standard. > > > for example, V4L2_CID_DETECTION_FD_MODEL or ...FD_ALGO, > > > drivers can define the detection algorithm or detection model to be used > > > for users to select. How do you think? > > > > Sounds like something that could be a menu control, so it could vary > > between drivers. > > > Ok, and maybe it should be created by v4l2_ctrl_new_int_menu(...)? > > > > > > > In short, I summery the control IDs as following: > > > V4L2_CID_DETECT_ANGLE: set the angle of face in degrees. 90 ~ -90 > > > degrees. > > > V4L2_CID_DETECT_DIRECTION: set the rotation of the head in degrees. > > > 0~330 degrees. > > > V4L2_CID_DETECT_SCALE_DOWN_IMG_WIDTH: set the image widths for an input > > > image to be scaled down for face detection > > > V4L2_CID_DETECT_SCALE_DOWN_IMG_HEIGHT: set the image heights for an > > > input image to be scaled down for face detection > > > V4L2_CID_DETECT_SPEED: set the detection speed, usually reducing > > > accuracy. > > > V4L2_CID_DETECTION_FD_MODEL: select the detection model or algorithm to > > > be used by face detection driver. > > > > > > > > +#define ENABLE_FD 0x111 > > > > > +#define FD_HW_ENABLE 0x4 > > > > > +#define FD_INT_EN 0x15c > > > > > +#define FD_INT 0x168 > > > > > +#define FD_RESULT 0x178 > > > > > +#define FD_IRQ_MASK 0x001 > > > > > + > > > > > +#define RS_MAX_BUF_SIZE 2288788 > > > > > +#define FD_MAX_SPEEDUP 7 > > > > > +#define FD_MAX_POSE_VAL 0xfffffffffffffff > > > > > +#define FD_DEF_POSE_VAL 0x3ff > > > > > +#define MAX_FD_SEL_NUM 1026 > > > > > > > > If that file is supposed to be included by anything beyond the driver > > > > itself, we need proper prefixing. (same for anything else in here) > > > > > > > I will fix it as following: > > > > > > #define FD_ENABLE 0x111 > > > > > > #define FD_REG_OFFSET_HW_ENABLE 0x4 > > > #define FD_REG_OFFSET_INT_EN 0x15c > > > #define FD_REG_OFFSET_INT_VAL 0x168 > > > #define FD_REG_OFFSET_RESULT 0x178 > > > > > > #define FD_IRQ_MASK 1 > > > #define FD_MAX_RS_BUF_SIZE 2288788 > > > #define FD_MAX_SPEEDUP 7 > > > #define FD_MAX_RESULT_NUM 1026 > > > > > > > I'd suggest the MTK_FD_ prefix. > > > Ok, I will use MTK_FD_ prefix. > > > > > > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > > > > > index 3dcfc61..eae876e 100644 > > > > > --- a/include/uapi/linux/v4l2-controls.h > > > > > +++ b/include/uapi/linux/v4l2-controls.h > > > > > @@ -192,6 +192,10 @@ enum v4l2_colorfx { > > > > > * We reserve 16 controls for this driver. */ > > > > > #define V4L2_CID_USER_IMX_BASE (V4L2_CID_USER_BASE + 0x10b0) > > > > > > > > > > +/* The base for the mediatek FD driver controls */ > > > > > +/* We reserve 16 controls for this driver. */ > > > > > +#define V4L2_CID_USER_MTK_FD_BASE (V4L2_CID_USER_BASE + 0x10d0) > > > > > > > > Why only the base, but not the actual IDs in uapi ? > > > > > > > I will put actual IDs in uapi/ for user to reference. Enrico, any thoughts on the explanation that Jerry provided and further discussion above? Thanks, Tomasz