From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ECE3C4727C for ; Thu, 1 Oct 2020 15:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A9D0207F7 for ; Thu, 1 Oct 2020 15:17:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="asQXqF6E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732546AbgJAPRx (ORCPT ); Thu, 1 Oct 2020 11:17:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732342AbgJAPRx (ORCPT ); Thu, 1 Oct 2020 11:17:53 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D47B4C0613E2 for ; Thu, 1 Oct 2020 08:17:52 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id i1so6059053edv.2 for ; Thu, 01 Oct 2020 08:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+CuSbWcGM2/Qd+9ER9Dz6b9GN8ltVla+ip6oPSoq7yA=; b=asQXqF6EWzCUzXqxbcDXbt9m4zzm/5boX5W4/LzPP5T4J4uRzRwdxLLZF7aIP/yGd2 qnD7xHSuOVI3mb9vo2B8rB15ug0PX7qCe2rL5ruqcWJaBF70TH4dJgLINsnLwqRsL94I im/ruZ1vDoa0IdAY+BwQ4F8IMdQUCpXt8Jjd8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+CuSbWcGM2/Qd+9ER9Dz6b9GN8ltVla+ip6oPSoq7yA=; b=KO7tgOUEhIIan9Ln/0unFUlizIjnthjQPuVHHbs4GUGZ2EqjvU7Zmt5+R7pJzuIxfj goSzQYGSwupqSOM1hkQ6wMJ8RliGriA6evZ9NlWgfbw4VcS4IpGYVMC+WZjS22qEIGrJ fIOehxwOaghbVUrP6XmX0SjEUD00a2uRYHJMI+SjwtDRziyOjq8Dlri5i/yHgt6h1MTd SgLKqX0gAx1EYMdT7E4PnWKfke+w+PNjuVx7rE9vlYSuhOTIXdR3Fi0s1/beo2m7Afcz d7T/8xQFZXa1QV5FDSTjL1C3pKWcTpy89jGK3dMVjhyFhevTtIeA8eZ+j8Va7yk7JxxE GnNw== X-Gm-Message-State: AOAM532qQnQ8Sruht3WX/dlEr98f8PZSjdZ4LoRSH4TJrcEWN1dhu+HV Hp0GHWY7rxpl/E/+BLB37kKU106sYs824A== X-Google-Smtp-Source: ABdhPJx/MCSydsIknyKXsfELVGQiCswGvHsiAhuVaGp2YEl3lohFWslOUqGSua7S2EAxRzRmveph2w== X-Received: by 2002:aa7:d60f:: with SMTP id c15mr9006783edr.102.1601565471126; Thu, 01 Oct 2020 08:17:51 -0700 (PDT) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com. [209.85.221.46]) by smtp.gmail.com with ESMTPSA id z17sm4396608edi.90.2020.10.01.08.17.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2020 08:17:50 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id j2so6253616wrx.7 for ; Thu, 01 Oct 2020 08:17:49 -0700 (PDT) X-Received: by 2002:a5d:6552:: with SMTP id z18mr9352555wrv.32.1601565468929; Thu, 01 Oct 2020 08:17:48 -0700 (PDT) MIME-Version: 1.0 References: <1600968674-11559-1-git-send-email-dikshita@codeaurora.org> <1600968674-11559-3-git-send-email-dikshita@codeaurora.org> In-Reply-To: From: Tomasz Figa Date: Thu, 1 Oct 2020 17:17:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] venus: venc: fix handlig of S_SELECTION and G_SELECTION To: Stanimir Varbanov Cc: Dikshita Agarwal , Linux Media Mailing List , Linux Kernel Mailing List , linux-arm-msm , Vikash Garodia Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Oct 1, 2020 at 3:32 AM Stanimir Varbanov wrote: > > Hi Tomasz, > > On 9/25/20 11:55 PM, Tomasz Figa wrote: > > Hi Dikshita, Stanimir, > > > > On Thu, Sep 24, 2020 at 7:31 PM Dikshita Agarwal > > wrote: > >> > >> From: Stanimir Varbanov > >> > >> - return correct width and height for G_SELECTION > >> - if requested rectangle wxh doesn't match with capture port wxh > >> adjust the rectangle to supported wxh. > >> > >> Signed-off-by: Dikshita Agarwal > >> --- > >> drivers/media/platform/qcom/venus/venc.c | 20 ++++++++++++-------- > >> 1 file changed, 12 insertions(+), 8 deletions(-) > >> > >> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c > >> index 7d2aaa8..a2cc12d 100644 > >> --- a/drivers/media/platform/qcom/venus/venc.c > >> +++ b/drivers/media/platform/qcom/venus/venc.c > >> @@ -463,13 +463,13 @@ static int venc_g_fmt(struct file *file, void *fh, struct v4l2_format *f) > >> switch (s->target) { > >> case V4L2_SEL_TGT_CROP_DEFAULT: > >> case V4L2_SEL_TGT_CROP_BOUNDS: > >> - s->r.width = inst->width; > >> - s->r.height = inst->height; > >> - break; > >> - case V4L2_SEL_TGT_CROP: > >> s->r.width = inst->out_width; > >> s->r.height = inst->out_height; > >> break; > >> + case V4L2_SEL_TGT_CROP: > >> + s->r.width = inst->width; > >> + s->r.height = inst->height; > >> + break; > >> default: > >> return -EINVAL; > >> }inter > >> @@ -490,10 +490,14 @@ static int venc_g_fmt(struct file *file, void *fh, struct v4l2_format *f) > >> > >> switch (s->target) { > >> case V4L2_SEL_TGT_CROP: > >> - if (s->r.width != inst->out_width || > >> - s->r.height != inst->out_height || > >> - s->r.top != 0 || s->r.left != 0) > >> - return -EINVAL; > >> + if (s->r.width != inst->width || > >> + s->r.height != inst->height || > >> + s->r.top != 0 || s->r.left != 0) { > >> + s->r.top = 0; > >> + s->r.left = 0; > >> + s->r.width = inst->width; > >> + s->r.height = inst->height; > > > > What's the point of exposing the selection API if no selection can > > actually be done? > > If someone can guarantee that dropping of s_selection will not break > userspace applications I'm fine with removing it. Indeed the specification could be made more clear about this. The visible rectangle configuration is described as optional, so I'd consider the capability to be optional as well. Of course it doesn't change the fact that something that is optional in the API may be mandatory for some specific integrations, like Chrome OS or Android. > > I implemented g/s_selection with the idea to add crop functionality > later because with current firmware interface it needs more work. I suggested one thing internally, but not sure if it was understood correctly: Most of the encoders only support partial cropping, with the rectangle limited to top = 0 and left = 0, in other words, only setting the visible width and height. This can be easily implemented on most of the hardware, even those that don't have dedicated cropping capability, by configuring the hardware as follows: stride = CAPTURE format width (or bytesperline) width = CROP width height = CROP height I believe Android requires the hardware to support stride and AFAIK this hardware is also commonly used on Android, so perhaps it's possible to achieve the above without any firmware changes? Best regards, Tomasz