From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0AC7C7618F for ; Fri, 26 Jul 2019 05:15:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69B8E21951 for ; Fri, 26 Jul 2019 05:15:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZBIvhCvH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725864AbfGZFPa (ORCPT ); Fri, 26 Jul 2019 01:15:30 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:34062 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725781AbfGZFPa (ORCPT ); Fri, 26 Jul 2019 01:15:30 -0400 Received: by mail-ed1-f66.google.com with SMTP id s49so17324284edb.1 for ; Thu, 25 Jul 2019 22:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=evwEOy3DAtV16NqcUka5UGTz9T6aRrk1pQfUhjz7kyM=; b=ZBIvhCvHNC04mPpW5vAoOuVtbo2QAUddYCwID6pWL5rm8y3h6wUgKF17LCqRjpx/a9 Gd9kgqgCuTSVnqHPByGCI4TjnPe5L26wKUcVclXK+knZ5jc+o0MIAiJFtcW5g6cgCmqZ tgSzX+Xl6wHiy8U19ptEi0DiTywgjb1n9I9dQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=evwEOy3DAtV16NqcUka5UGTz9T6aRrk1pQfUhjz7kyM=; b=QQYLLFnxRKoML1Y7GAP2qxABhpREnCI5Boosjktw2jsLF8+KHihd5i4RghclDK2y/L 1lCd367y9wCb0ebh8B+ax8MG6aqtVI/LSK4dCNJbdw3b05u+UKFsOL9Ex5N3ILDwTQde U8fCOjBN7wiF7jIHy2e3TDU6ZrEXGV44Gj3hZrsy/4MuQylO4PWUGNhqTn0ui3wnbOgS 5hPl/NF0xaaHUrZGR6bRYnD4QLgNqLPPD8L8LpOGCA1DtjH6jQssn371HFjFOeXHElMd bbxJFekoGqRk7nvzkUXhGXZ7ogSB/DP39F45V5N8s2xYnWCNFm5cj/snLp8OqlIXmIV9 H1vQ== X-Gm-Message-State: APjAAAX609Cy4P3FW0IWqm1fJnzTVf1zchwky25BO2uW9HMzkizoweCB WxqUt1SEl3Vver6TAwyVGfcGI0uCSyx5eQ== X-Google-Smtp-Source: APXvYqwa3vq12kN2voYcm4SxAbbGj4nkn9IndLaMPxCyapSmqo7OCejCE9nE9UbTTIQnYKm9+9v87g== X-Received: by 2002:a17:906:2289:: with SMTP id p9mr11789392eja.249.1564118127961; Thu, 25 Jul 2019 22:15:27 -0700 (PDT) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com. [209.85.221.53]) by smtp.gmail.com with ESMTPSA id n15sm13522479edd.49.2019.07.25.22.15.26 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 22:15:27 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id z1so52941507wru.13 for ; Thu, 25 Jul 2019 22:15:26 -0700 (PDT) X-Received: by 2002:adf:e541:: with SMTP id z1mr9178545wrm.48.1564118126310; Thu, 25 Jul 2019 22:15:26 -0700 (PDT) MIME-Version: 1.0 References: <20190611035344.29814-1-jungo.lin@mediatek.com> <20190611035344.29814-10-jungo.lin@mediatek.com> <20190701072532.GB137710@chromium.org> <1562297618.1212.46.camel@mtksdccf07> <1562313579.1212.73.camel@mtksdccf07> <1563870117.1212.455.camel@mtksdccf07> In-Reply-To: <1563870117.1212.455.camel@mtksdccf07> From: Tomasz Figa Date: Fri, 26 Jul 2019 14:15:14 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC, v3 9/9] media: platform: Add Mediatek ISP P1 shared memory device To: Jungo Lin Cc: devicetree@vger.kernel.org, =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , Mauro Carvalho Chehab , =?UTF-8?B?UnlubiBXdSAo5ZCz6IKy5oGpKQ==?= , srv_heupstream , Rob Herring , =?UTF-8?B?UnlhbiBZdSAo5L2Z5a2f5L+uKQ==?= , =?UTF-8?B?RnJhbmtpZSBDaGl1ICjpgrHmloflh7Ep?= , Hans Verkuil , Matthias Brugger , Sj Huang , "moderated list:ARM/Mediatek SoC support" , Laurent Pinchart , ddavenport@chromium.org, =?UTF-8?B?RnJlZGVyaWMgQ2hlbiAo6Zmz5L+K5YWDKQ==?= , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Linux Media Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Jul 23, 2019 at 5:22 PM Jungo Lin wrote: > > Hi, Tomasz: > > On Tue, 2019-07-23 at 16:20 +0900, Tomasz Figa wrote: > > Hi Jungo, > > > > On Fri, Jul 5, 2019 at 4:59 PM Jungo Lin wrote: > > > > > > Hi Tomasz: > > > > > > On Fri, 2019-07-05 at 13:22 +0900, Tomasz Figa wrote: > > > > Hi Jungo, > > > > > > > > On Fri, Jul 5, 2019 at 12:33 PM Jungo Lin wrote: > > > > > > > > > > Hi Tomasz, > > > > > > [snip] > > > > > > > > After applying your suggestion in SCP device driver, we could remove > > > > > mtk_cam-smem.h/c. Currently, we use dma_alloc_coherent with SCP device > > > > > to get SCP address. We could touch the buffer with this SCP address in > > > > > SCP processor. > > > > > > > > > > After that, we use dma_map_page_attrs with P1 device which supports > > > > > IOMMU domain to get IOVA address. For this address, we will assign > > > > > it to our ISP HW device to proceed. > > > > > > > > > > Below is the snippet for ISP P1 compose buffer initialization. > > > > > > > > > > ptr = dma_alloc_coherent(p1_dev->cam_dev.smem_dev, > > > > > MAX_COMPOSER_SIZE, &addr, GFP_KERNEL); > > > > > if (!ptr) { > > > > > dev_err(dev, "failed to allocate compose memory\n"); > > > > > return -ENOMEM; > > > > > } > > > > > isp_ctx->scp_mem_pa = addr; > > > > > > > > addr contains a DMA address, not a physical address. Could we call it > > > > scp_mem_dma instead? > > > > > > > > > dev_dbg(dev, "scp addr:%pad\n", &addr); > > > > > > > > > > /* get iova address */ > > > > > addr = dma_map_page_attrs(dev, phys_to_page(addr), 0, > > > > > > > > addr is a DMA address, so phys_to_page() can't be called on it. The > > > > simplest thing here would be to use dma_map_single() with ptr as the > > > > CPU address expected. > > > > > > > > > > We have changed to use ma_map_single() with ptr, but encounter IOMMU > > > error. From the debug log of iommu_dma_map_page[3], we got > > > 0x0000000054800000 instead of expected address: 0x0000000050800000[2]. > > > There is a address offset(0x4000000). If we change to use > > > dma_map_page_attrs with phys_to_page(addr), the address is correct as we > > > expected[2]. Do you have any suggestion on this issue? Do we miss > > > something? > > > > Sorry for the late reply. Could you show me the code changes you made > > to use dma_map_single()? It would sound like the virtual address > > passed to dma_map_single() isn't correct. > > > > Best regards, > > Tomasz > > > > > Please check the below code snippet in today's testing. > > p1_dev->cam_dev.smem_dev = &p1_dev->scp_pdev->dev; > ptr = dma_alloc_coherent(p1_dev->cam_dev.smem_dev, > MTK_ISP_COMPOSER_MEM_SIZE, &addr, GFP_KERNEL); > if (!ptr) { > dev_err(dev, "failed to allocate compose memory\n"); > return -ENOMEM; > } > p1_dev->composer_scp_addr = addr; > p1_dev->composer_virt_addr = ptr; > dev_info(dev, "scp addr:%pad va:%pK\n", &addr, ptr); > > /* get iova address */ > addr = dma_map_single(dev, ptr, MTK_ISP_COMPOSER_MEM_SIZE, > DMA_BIDIRECTIONAL); > if (dma_mapping_error(dev, addr)) { > dma_free_coherent(p1_dev->cam_dev.smem_dev, > MTK_ISP_COMPOSER_MEM_SIZE, > ptr, p1_dev->composer_scp_addr); > dev_err(dev, "Failed to map scp iova\n"); > ret = -ENOMEM; > goto fail_free_mem; > } > p1_dev->composer_iova = addr; > dev_info(dev, "scp iova addr:%pad\n", &addr); > > Moreover, below is extracted log[2]. > > We guess the virtual address which is returned by dma_alloc_coherent > function is not valid kernel logical address. It is actually returned by > memremap() in dma_init_coherent_memory(). Moreover, dma_map_single() > will call virt_to_page() function. For virt_to_page function, it > requires a logical address[1]. > > [1]https://www.oreilly.com/library/view/linux-device-drivers/0596005903/ch15.html > Indeed virt_to_page() works only with kernel LOWMEM addresses. Whether virt_to_page() is the right thing to do in dma_map_single() is a good question, but let's assume it was implemented like this for a reason. However, you also can't call phys_to_page() on the DMA addresses returned by dma_alloc_*() either. It works just by luck, because SCP DMA addresses and CPU physical addresses are numerically the same. Could you try dma_get_sgtable() with the SCP struct device and then dma_map_sg() with the P1 struct device? Best regards, Tomasz > [2] > 322 [ 1.238269] mtk-cam-p1 1a006000.camisp: scp > addr:0x0000000052000000 va:00000000a3adc471 > 323 [ 1.239582] mtk-cam-p1 1a006000.camisp: scp iova > addr:0x00000000fde00000 > 7716 [ 1.238963] mtk-cam-p1 1a006000.camisp: scp > addr:0x0000000052000000 va:0000000042ec580f > 7717 [ 1.240276] mtk-cam-p1 1a006000.camisp: scp iova > addr:0x00000000fde00000 > 15088 [ 1.239309] mtk-cam-p1 1a006000.camisp: scp > addr:0x0000000052000000 va:000000005e5b3462 > 15089 [ 1.240626] mtk-cam-p1 1a006000.camisp: scp iova > addr:0x00000000fde00000 > > Best regards, > > Jungo > > > > > > > [1] > > > [ 1.344786] __dma_alloc_from_coherent: 0x800000 PAGE_SHIFT:12 > > > device_base:0x0000000050000000 dma:0x0000000050800000 > > > virt_base:ffffff8014000000 va:ffffff8014800000 > > > > > > [ 1.346890] mtk-cam 1a000000.camisp: scp addr:0x0000000050800000 > > > va:ffffff8014800000 > > > > > > [ 1.347864] iommu_dma_map_page:0x0000000054800000 offset:0 > > > [ 1.348562] mtk-cam 1a000000.camisp: iova addr:0x00000000fde00000 > > > > > > [2] > > > [ 1.346738] __dma_alloc_from_coherent: 0x800000 PAGE_SHIFT:12 > > > device_base:0x0000000050000000 dma:0x0000000050800000 > > > virt_base:ffffff8014000000 va:ffffff8014800000 > > > [ 1.348841] mtk-cam 1a000000.camisp: scp addr:0x0000000050800000 > > > va:ffffff8014800000 > > > [ 1.349816] iommu_dma_map_page:0x0000000050800000 offset:0 > > > [ 1.350514] mtk-cam 1a000000.camisp: iova addr:0x00000000fde00000 > > > > > > > > > [3] > > > dma_addr_t iommu_dma_map_page(struct device *dev, struct page *page, > > > unsigned long offset, size_t size, int prot) > > > { > > > phys_addr_t phys = page_to_phys(page); > > > pr_err("iommu_dma_map_page:%pa offset:%lu\n", &phys, offset); > > > > > > return __iommu_dma_map(dev, page_to_phys(page) + offset, size, prot, > > > iommu_get_dma_domain(dev)); > > > } > > > > > > [snip] > > > > > > Best regards, > > > > > > Jungo > > > > > > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > >