From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA1CC4727E for ; Fri, 25 Sep 2020 20:56:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA44C21D42 for ; Fri, 25 Sep 2020 20:56:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iKie1V+t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727733AbgIYU4M (ORCPT ); Fri, 25 Sep 2020 16:56:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727346AbgIYU4M (ORCPT ); Fri, 25 Sep 2020 16:56:12 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5131EC0613CE for ; Fri, 25 Sep 2020 13:56:12 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id k14so3927257edo.1 for ; Fri, 25 Sep 2020 13:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ln/na7/qnWvF6dKKBZBvNo59RWL2+7IcVO9uS/RNFZ8=; b=iKie1V+tvcVyQuqfE4WQdCxzYbXhY7etZPsfwaGvN/SGilfmMrqKaq+Jwde5MhVhYL PatFJw1D9j9NZHdM371ewnyJvHgnz0Wj019YJz6Ec/Z/Pw4BMV1bBYty2cYOf/xzuSjg MvuR80FHP81gG8k0tGUxeEnZkqrdjxJ8GFhFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ln/na7/qnWvF6dKKBZBvNo59RWL2+7IcVO9uS/RNFZ8=; b=PTV9jVhkI7d/JI5Nb5axv3b/zKOvSE0Yuw+ZS8n4b3lpqRFjKWA3QmhS5LOxlIz/bd VCxogpVkPR6OaWFqpFOvwOLJrS2ummLCdWYjh/zsXeGfgNpaZryYaAuFlKaR7t5BemIk N0xm8+uOXX4fg0nDZ54OkvZF8HF5vyjdHcYXJUSc1f2kxx0Y0IGBoywHwZng8zGiR2yt +8iDhwpi9Z3XayTE191gJ3uV/Ieh82T2G4uLoBccbWpvQTcGtd4Sp/CJ1nIYO9C4xHGG lPTVf4Bjs5WCPgc+hZ8hLPt1C7M+0MCGs+hPdtmCCT6dnXJUT/nIzdG6Rf4KZHdbKqDH v/sA== X-Gm-Message-State: AOAM5339Yd5DPqBqxi8I79XcJegViLuNLAJY4N8zS8eSOb9ZFW8SqRgm AuiKo8zBlrYKrO98Tb/Dlj/DjWcpe2mlew== X-Google-Smtp-Source: ABdhPJxSMOZcWaNjy/10QSFrl51VfW4f8KXEFZayzuml/GS/Jsgt6Ff6omOjUJ9SwHG0n2UpDHcC/g== X-Received: by 2002:a50:ce09:: with SMTP id y9mr3266114edi.91.1601067370768; Fri, 25 Sep 2020 13:56:10 -0700 (PDT) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com. [209.85.128.42]) by smtp.gmail.com with ESMTPSA id m10sm2553540ejx.123.2020.09.25.13.56.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 13:56:10 -0700 (PDT) Received: by mail-wm1-f42.google.com with SMTP id y15so541881wmi.0 for ; Fri, 25 Sep 2020 13:56:09 -0700 (PDT) X-Received: by 2002:a1c:a5c8:: with SMTP id o191mr391963wme.127.1601067369520; Fri, 25 Sep 2020 13:56:09 -0700 (PDT) MIME-Version: 1.0 References: <1600968674-11559-1-git-send-email-dikshita@codeaurora.org> <1600968674-11559-3-git-send-email-dikshita@codeaurora.org> In-Reply-To: <1600968674-11559-3-git-send-email-dikshita@codeaurora.org> From: Tomasz Figa Date: Fri, 25 Sep 2020 22:55:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] venus: venc: fix handlig of S_SELECTION and G_SELECTION To: Dikshita Agarwal , Stanimir Varbanov Cc: Linux Media Mailing List , Linux Kernel Mailing List , linux-arm-msm , Vikash Garodia Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Dikshita, Stanimir, On Thu, Sep 24, 2020 at 7:31 PM Dikshita Agarwal wrote: > > From: Stanimir Varbanov > > - return correct width and height for G_SELECTION > - if requested rectangle wxh doesn't match with capture port wxh > adjust the rectangle to supported wxh. > > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/venus/venc.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c > index 7d2aaa8..a2cc12d 100644 > --- a/drivers/media/platform/qcom/venus/venc.c > +++ b/drivers/media/platform/qcom/venus/venc.c > @@ -463,13 +463,13 @@ static int venc_g_fmt(struct file *file, void *fh, struct v4l2_format *f) > switch (s->target) { > case V4L2_SEL_TGT_CROP_DEFAULT: > case V4L2_SEL_TGT_CROP_BOUNDS: > - s->r.width = inst->width; > - s->r.height = inst->height; > - break; > - case V4L2_SEL_TGT_CROP: > s->r.width = inst->out_width; > s->r.height = inst->out_height; > break; > + case V4L2_SEL_TGT_CROP: > + s->r.width = inst->width; > + s->r.height = inst->height; > + break; > default: > return -EINVAL; > } > @@ -490,10 +490,14 @@ static int venc_g_fmt(struct file *file, void *fh, struct v4l2_format *f) > > switch (s->target) { > case V4L2_SEL_TGT_CROP: > - if (s->r.width != inst->out_width || > - s->r.height != inst->out_height || > - s->r.top != 0 || s->r.left != 0) > - return -EINVAL; > + if (s->r.width != inst->width || > + s->r.height != inst->height || > + s->r.top != 0 || s->r.left != 0) { > + s->r.top = 0; > + s->r.left = 0; > + s->r.width = inst->width; > + s->r.height = inst->height; What's the point of exposing the selection API if no selection can actually be done? Best regards, Tomasz