linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomasz Figa <tfiga@chromium.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"Mani, Rajmohan" <rajmohan.mani@intel.com>
Subject: Re: [PATCH 1/5] staging: imgu: Switch to __aligned() from __attribute__((aligned()))
Date: Thu, 7 Mar 2019 12:00:59 +0900	[thread overview]
Message-ID: <CAAFQd5CwQaOivM81fQ4aGYWZTsUEhKOr55XvtwGYSJDJkSELpQ@mail.gmail.com> (raw)
In-Reply-To: <CAAFQd5D=kTUEdzc4gStvKH45SMhDycDO_5ipJGaD=+aduiPESw@mail.gmail.com>

On Thu, Mar 7, 2019 at 12:00 PM Tomasz Figa <tfiga@chromium.org> wrote:
>
> Hi Sakari,
>
> On Wed, Feb 20, 2019 at 8:21 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> >
> > __aligned() is preferred. The patch has been generated using the following
> > command in the drivers/staging/media/ipu3 directory:
> >
> > $ git grep -l 'aligned(32)' | \
> >         xargs perl -i -pe \
> >         's/__attribute__\s*\(\(\s*aligned\s*\(([0-9]+)\s*\)\s*\)\)/__aligned($1)/g;'
>
> Thanks for the patch. These structs are expected to move to uapi/ once
> the driver leaves staging. Is __aligned() now accessible to uapi
> headers?

Ah, just noticed the v2 of the series doesn't include this patch.
Sorry for the noise.

Best regards,
Tomasz

  reply	other threads:[~2019-03-07  3:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 11:19 [PATCH 0/5] Fix most ImgU driver compiler / checker warnings Sakari Ailus
2019-02-20 11:19 ` [PATCH 1/5] staging: imgu: Switch to __aligned() from __attribute__((aligned())) Sakari Ailus
2019-03-07  3:00   ` Tomasz Figa
2019-03-07  3:00     ` Tomasz Figa [this message]
2019-03-07  7:57       ` Sakari Ailus
2019-02-20 11:19 ` [PATCH 2/5] staging: imgu: Fix struct ipu3_uapi_awb_fr_config_s alignment Sakari Ailus
2019-05-27 16:39   ` Jacopo Mondi
2019-02-20 11:19 ` [PATCH 3/5] staging: imgu: Remove redundant checks Sakari Ailus
2019-02-20 11:19 ` [PATCH 4/5] staging: imgu: Address compiler / checker warnings in MMU code Sakari Ailus
2019-02-20 11:19 ` [PATCH 5/5] Revert "media: ipu3: shut up warnings produced with W=1" Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAFQd5CwQaOivM81fQ4aGYWZTsUEhKOr55XvtwGYSJDJkSELpQ@mail.gmail.com \
    --to=tfiga@chromium.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rajmohan.mani@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).