From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2935FC433F5 for ; Wed, 1 Dec 2021 23:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353923AbhLBACE (ORCPT ); Wed, 1 Dec 2021 19:02:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353917AbhLBACD (ORCPT ); Wed, 1 Dec 2021 19:02:03 -0500 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BF2EC06174A for ; Wed, 1 Dec 2021 15:58:42 -0800 (PST) Received: by mail-qt1-x82d.google.com with SMTP id o17so25886390qtk.1 for ; Wed, 01 Dec 2021 15:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=UiQtL7PYDLYrQNpaKD6zuScFDLJgXtjIiVUSuenai/weJwHaNZGd50drPKnS644xJI FsIUoEA38p0/+CgS2GnR18T3SWsehh9cfFdQhsGcYNw83eEXy2yN0V551YDlQed1a5ia suumy0/x42VakjEbn2dWsY6UEt7ktkLXMzUVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=XQtAiqjU0tc9QX+EFQe5i8bsBbpe17qO/xRhJ86sBgm58g6LLOstHp+1hAFwTExsy/ KwyB+/FIzHJDk0+GKmH3qjkYCargZNbaOQKTSG5u3aazXylJX2EliD0bsWYDRQi48NVn UfuxPuxKBrdNC7BmsvPWGuj2UEcOlHnH1b6r07DQnwyi2NeoR3ep3DTUe6V4nBtg4Fb2 THXH6L3HprOZmaaFj0TP1h9zyj00YJQYVk6IJi1RMZm6ONQsY91DhknobaZyV39ZTNja 6iPiFIIA+IEqLo3LEMsenzPY+bphg3Hkx+hZJ30fidf9vm+YZytZ26FJZqiuxNBP9J8o Yj4A== X-Gm-Message-State: AOAM532EB8d2AK0WITJ6IOAAx3QiHi2U3DZmKRbuysy+z6d5iYlPdFUf 0sMCmFvZY+5ci02L+QGRC8z/iyMB8SwQexJskVg4eg== X-Google-Smtp-Source: ABdhPJxjAowIZNevtYxc/JYBCkiAIs98qYglgiULGYpJOCGmpv/QaOf2gRWJM912xU3UVIlhW8QOcnJt6ZYIil4W+Lg= X-Received: by 2002:a05:622a:130e:: with SMTP id v14mr10542855qtk.458.1638403121278; Wed, 01 Dec 2021 15:58:41 -0800 (PST) MIME-Version: 1.0 References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-3-yunfei.dong@mediatek.com> In-Reply-To: From: Steve Cho Date: Wed, 1 Dec 2021 15:58:30 -0800 Message-ID: Subject: Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 3:55 PM Steve Cho wrote: > > LGTM. > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > > > Vdec and venc can use the same function to wake up interrupt event. > > > > Reviewed-by: Tzung-Bi Shih > > Reviewed-by: AngeloGioacchino Del Regno > > Signed-off-by: Yunfei Dong > > --- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 +-------- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++++++++ > > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 -------- > > 3 files changed, 9 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > index 59caf2163349..055d50e52720 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > @@ -31,13 +31,6 @@ > > module_param(mtk_v4l2_dbg_level, int, 0644); > > module_param(mtk_vcodec_dbg, bool, 0644); > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > -{ > > - ctx->int_cond = 1; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > { > > struct mtk_vcodec_dev *dev = priv; > > @@ -69,7 +62,7 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > writel((readl(vdec_misc_addr) & ~VDEC_IRQ_CLR), > > dev->reg_base[VDEC_MISC] + VDEC_IRQ_CFG_REG); > > > > - wake_up_ctx(ctx); > > + wake_up_ctx(ctx, MTK_INST_IRQ_RECEIVED); > > Assuming setting up reason doesn't change functionality. > > > > > mtk_v4l2_debug(3, > > "mtk_vcodec_dec_irq_handler :wake up ctx %d, dec_done_status=%x", > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index 581522177308..1d2370608d0d 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -473,4 +473,12 @@ static inline struct mtk_vcodec_ctx *ctrl_to_ctx(struct v4l2_ctrl *ctrl) > > return container_of(ctrl->handler, struct mtk_vcodec_ctx, ctrl_hdl); > > } > > > > +/* Wake up context wait_queue */ > > +static inline void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > +{ > > + ctx->int_cond = 1; > > + ctx->int_type = reason; > > + wake_up_interruptible(&ctx->queue); > > +} > > + > > #endif /* _MTK_VCODEC_DRV_H_ */ > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > index eed67394cf46..7c3487fb3498 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > @@ -65,14 +65,6 @@ static const struct mtk_video_fmt mtk_video_formats_capture_vp8[] = { > > }, > > }; > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > -{ > > - ctx->int_cond = 1; > > - ctx->int_type = reason; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static void clean_irq_status(unsigned int irq_status, void __iomem *addr) > > { > > if (irq_status & MTK_VENC_IRQ_STATUS_PAUSE) > > -- > > 2.25.1 > >