From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-media@vger.kernel.org
Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Marco Felsch <m.felsch@pengutronix.de>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v2 1/3] media: mt9m111: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY
Date: Fri, 11 Jan 2019 22:17:10 +0900 [thread overview]
Message-ID: <CAC5umygV4adR=zQzp1s+kg5gYYJvYBpt_szeR8ipz=bawRMY=Q@mail.gmail.com> (raw)
In-Reply-To: <1547134109-21449-2-git-send-email-akinobu.mita@gmail.com>
2019年1月11日(金) 0:28 Akinobu Mita <akinobu.mita@gmail.com>:
</akinobu.mita@gmail.com>
>
> The VIDIOC_SUBDEV_G_FMT ioctl for this driver doesn't recognize
> V4L2_SUBDEV_FORMAT_TRY and always works as if V4L2_SUBDEV_FORMAT_ACTIVE
> is specified.
>
> Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>
> Cc: Marco Felsch <m.felsch@pengutronix.de>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
> * v2
> - Use format->pad for the argument of v4l2_subdev_get_try_format().
>
> drivers/media/i2c/mt9m111.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
> index d639b9b..eb5bf71 100644
> --- a/drivers/media/i2c/mt9m111.c
> +++ b/drivers/media/i2c/mt9m111.c
> @@ -528,6 +528,16 @@ static int mt9m111_get_fmt(struct v4l2_subdev *sd,
> if (format->pad)
> return -EINVAL;
>
> + if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
> +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API
> + mf = v4l2_subdev_get_try_format(sd, cfg, format->pad);
> + format->format = *mf;
> + return 0;
> +#else
> + return -ENOTTY;
> +#endif
> + }
> +
> mf->width = mt9m111->width;
> mf->height = mt9m111->height;
> mf->code = mt9m111->fmt->code;
> @@ -1089,6 +1099,26 @@ static int mt9m111_s_stream(struct v4l2_subdev *sd, int enable)
> return 0;
> }
>
> +static int mt9m111_init_cfg(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg)
> +{
> +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API
> + struct mt9m111 *mt9m111 = container_of(sd, struct mt9m111, subdev);
> + struct v4l2_mbus_framefmt *format =
> + v4l2_subdev_get_try_format(sd, cfg, 0);
> +
> + format->width = mt9m111->width;
> + format->height = mt9m111->height;
> + format->code = mt9m111->fmt->code;
> + format->colorspace = mt9m111->fmt->colorspace;
Oops, I made the same mistake that I did for mt9m001 driver.
This should be the default configuration instead of current one.
next prev parent reply other threads:[~2019-01-11 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 15:28 [PATCH v2 0/3] media: bugfixes for mt9m111 driver Akinobu Mita
2019-01-10 15:28 ` [PATCH v2 1/3] media: mt9m111: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY Akinobu Mita
2019-01-11 13:17 ` Akinobu Mita [this message]
2019-01-10 15:28 ` [PATCH v2 2/3] media: mt9m111: set all mbus format field when G_FMT and S_FMT ioctls Akinobu Mita
2019-01-10 15:28 ` [PATCH v2 3/3] media: mt9m111: set initial frame size other than 0x0 Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC5umygV4adR=zQzp1s+kg5gYYJvYBpt_szeR8ipz=bawRMY=Q@mail.gmail.com' \
--to=akinobu.mita@gmail.com \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=linux-media@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=m.grzeschik@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).